[HDFS-11857] Ozone : need to refactor StorageContainerLocationProtocolServerSideTranslatorPB

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Target Version/s: ozone
• Assignee: Chen Liang
• Reporter: Chen Liang
• Created: 19/May/17 20:49
• Updated: 19/May/17 23:13
• Resolved: 19/May/17 22:59

Description

Currently, StorageContainerLocationProtocolServerSideTranslatorPB has two protocol impls:
StorageContainerLocationProtocol impl
ScmBlockLocationProtocol blockImpl.
the class provides container-related services by invoking impl, and block-related services by invoking blockImpl. Namely, on server side, the implementation makes a distinguish between "container protocol" and "block protocol".

An issue is that, currently, everywhere except for the server side is viewing "container protocol" and "block protocol" as different. More specifically, StorageContainerLocationProtocol.proto still includes both container operation and block operation in itself alone. As a result of this difference, it is difficult to implement certain APIs (e.g. putKey) properly from client side.

This JIRA merges "block protocol" back to "container protocol" in StorageContainerLocationProtocolServerSideTranslatorPB, to unblock the implementation of other APIs for client side.

Please note that, in the long run, separating these two protocols does seem to be the right way. This JIRA is only a temporary solution to unblock developing other APIs. Will need to revisit these protocols in the future.

Thanks xyao for the offline discussion.