[HDFS-11850] Ozone: Stack Overflow in XceiverClientManager because of race condition in accessing openClient

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: ozone
• Assignee: Mukul Kumar Singh
• Reporter: Mukul Kumar Singh
• Created: 18/May/17 14:52
• Updated: 26/Apr/18 21:50
• Resolved: 22/May/17 17:21

Description

There is a possible race condition in accessing the open client has, it is because of unlocked access of the hash in acquireClient.

This can cause stack overflow and also leaking client in all probabilities

        at com.google.common.cache.LocalCache$Segment.put(LocalCache.java:3019)
        at com.google.common.cache.LocalCache.put(LocalCache.java:4365)
        at com.google.common.cache.LocalCache$LocalManualCache.put(LocalCache.java:5077)
        at org.apache.hadoop.scm.XceiverClientManager$1.onRemoval(XceiverClientManager.java:85)
        at com.google.common.cache.LocalCache.processPendingNotifications(LocalCache.java:1966)
        at com.google.common.cache.LocalCache$Segment.runUnlockedCleanup(LocalCache.java:3650)
        at com.google.common.cache.LocalCache$Segment.postWriteCleanup(LocalCache.java:3626)
        at com.google.common.cache.LocalCache$Segment.put(LocalCache.java:3019)
        at com.google.common.cache.LocalCache.put(LocalCache.java:4365)
        at com.google.common.cache.LocalCache$LocalManualCache.put(LocalCache.java:5077)
        at org.apache.hadoop.scm.XceiverClientManager$1.onRemoval(XceiverClientManager.java:85)
        at com.google.common.cache.LocalCache.processPendingNotifications(LocalCache.java:1966)
        at com.google.common.cache.LocalCache$Segment.runUnlockedCleanup(LocalCache.java:3650)
        at com.google.common.cache.LocalCache$Segment.postWriteCleanup(LocalCache.java:3626)
        at com.google.common.cache.LocalCache$Segment.put(LocalCache.java:3019)
        at com.google.common.cache.LocalCache.put(LocalCache.java:4365)
        at com.google.common.cache.LocalCache$LocalManualCache.put(LocalCache.java:5077)
        at org.apache.hadoop.scm.XceiverClientManager$1.onRemoval(XceiverClientManager.java:85)
        at com.google.common.cache.LocalCache.processPendingNotifications(LocalCache.java:1966)
        at com.google.common.cache.LocalCache$Segment.runUnlockedCleanup(LocalCache.java:3650)