Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11832

Switch leftover logs to slf4j format in BlockManager.java

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.7.0, 2.8.0, 3.0.0-alpha1
    • 3.0.0-alpha4
    • namenode
    • None

    Description

      HDFS-7706 Switch BlockManager logging to use slf4j. But the logging formats were not modified appropriately. For example:
      if (LOG.isDebugEnabled())

      { LOG.debug("blocks = " + java.util.Arrays.asList(blocks)); }

      These codes should be modified to:
      LOG.debug("blocks = {}", java.util.Arrays.asList(blocks));

      Attachments

        1. HDFS-11832.001.patch
          16 kB
          Chen Liang
        2. HDFS-11832.002.patch
          16 kB
          Hui Xu
        3. HDFS-11832.003.patch
          18 kB
          Hui Xu
        4. HDFS-11832.004.patch
          18 kB
          Chen Liang
        5. HDFS-11832.005.patch
          18 kB
          Hui Xu

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            vagarychen Chen Liang
            10075197 Hui Xu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack

                  Issue deployment