Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1183

Remove some duplicate code in NamenodeJspHelper.java

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.1
    • Fix Version/s: 0.22.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This patch refactors out some duplicate code in generateNodeData and generateDecommissioningNodeData in NamenodeJspHelper.java.

        Activity

        Hide
        Jakob Homan added a comment -

        +1. Looks good. Will commit in the morning, pending Hudson.

        Show
        Jakob Homan added a comment - +1. Looks good. Will commit in the morning, pending Hudson.
        Hide
        Jakob Homan added a comment -

        Hudson's back. Re-triggering.

        Show
        Jakob Homan added a comment - Hudson's back. Re-triggering.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12446225/HDFS-1183.patch
        against trunk revision 951178.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/188/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/188/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/188/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/188/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446225/HDFS-1183.patch against trunk revision 951178. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/188/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/188/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/188/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/188/console This message is automatically generated.
        Hide
        Jakob Homan added a comment -

        +1. Core failed test is known bad (https://issues.apache.org/jira/browse/HDFS-615), contrib test failure is unrelated, and existing tests cover this refactor.

        Show
        Jakob Homan added a comment - +1. Core failed test is known bad ( https://issues.apache.org/jira/browse/HDFS-615 ), contrib test failure is unrelated, and existing tests cover this refactor.
        Hide
        Jakob Homan added a comment -

        I've committed this. Thanks, Jeff! Resolving as fixed.

        Show
        Jakob Homan added a comment - I've committed this. Thanks, Jeff! Resolving as fixed.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #298 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/298/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #298 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/298/ )

          People

          • Assignee:
            Jeff Ames
            Reporter:
            Jeff Ames
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development