Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1178

The NameNode servlets should not use RPC to connect to the NameNode

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently some of the NameNode servlets use RPC to connect from the NameNode to itself. They should do it more directly with the NameNode object.

      1. direct-nn.patch
        15 kB
        Owen O'Malley
      2. h1178-01.patch
        14 kB
        Kan Zhang
      3. h1178-03.patch
        15 kB
        Kan Zhang
      4. hdfs-1178-y20.patch
        11 kB
        Owen O'Malley
      5. hdfs-1178-y20.patch
        9 kB
        Owen O'Malley

        Issue Links

          Activity

          Hide
          Owen O'Malley added a comment -

          This patch fixes the problem in yahoo 20. I'll upload a trunk patch later.

          Show
          Owen O'Malley added a comment - This patch fixes the problem in yahoo 20. I'll upload a trunk patch later.
          Hide
          Owen O'Malley added a comment -

          This patch updates it to use the user from the token rather than a fake user.

          Show
          Owen O'Malley added a comment - This patch updates it to use the user from the token rather than a fake user.
          Hide
          Devaraj Das added a comment -

          +1

          Show
          Devaraj Das added a comment - +1
          Hide
          Owen O'Malley added a comment -

          I fixed the error handling. This is for y20, so don't commit it.

          Show
          Owen O'Malley added a comment - I fixed the error handling. This is for y20, so don't commit it.
          Hide
          Jakob Homan added a comment -

          +1 for direct-nn.patch.

          Show
          Jakob Homan added a comment - +1 for direct-nn.patch.
          Hide
          Kan Zhang added a comment -

          a port for trunk.

          Show
          Kan Zhang added a comment - a port for trunk.
          Hide
          Jakob Homan added a comment -

          +1. Kan, do you want to run test-patch manually with a patched common jar, or do you want to wait for the common part to be committed and run it through Hudson?

          Show
          Jakob Homan added a comment - +1. Kan, do you want to run test-patch manually with a patched common jar, or do you want to wait for the common part to be committed and run it through Hudson?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12450354/h1178-01.patch
          against trunk revision 967293.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/446/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/446/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/446/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/446/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12450354/h1178-01.patch against trunk revision 967293. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/446/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/446/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/446/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/446/console This message is automatically generated.
          Hide
          Kan Zhang added a comment -

          Addressed findbugs warning and removed a couple unnecessary imports. re-run Hudson.

          Show
          Kan Zhang added a comment - Addressed findbugs warning and removed a couple unnecessary imports. re-run Hudson.
          Hide
          Kan Zhang added a comment -

          No new test added since this is a re-factoring patch. Existing tests apply.

          Show
          Kan Zhang added a comment - No new test added since this is a re-factoring patch. Existing tests apply.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12450495/h1178-03.patch
          against trunk revision 979396.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/223/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/223/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/223/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/223/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12450495/h1178-03.patch against trunk revision 979396. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/223/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/223/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/223/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/223/console This message is automatically generated.
          Hide
          Jakob Homan added a comment -

          Failed tests appear to be all previously identified as known-bad and very not likely to be related to this patch: https://issues.apache.org/jira/browse/HDFS-1315?focusedCommentId=12891700&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12891700. I'm going to go ahead and commit.

          Show
          Jakob Homan added a comment - Failed tests appear to be all previously identified as known-bad and very not likely to be related to this patch: https://issues.apache.org/jira/browse/HDFS-1315?focusedCommentId=12891700&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12891700 . I'm going to go ahead and commit.
          Hide
          Jakob Homan added a comment -

          I've committed this. Thanks Kan and Owen. Resolving as fixed.

          Show
          Jakob Homan added a comment - I've committed this. Thanks Kan and Owen. Resolving as fixed.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #354 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/354/)
          HDFS-1178. The NameNode servlets should not use RPC to connect to the NameNode. Contributed by Kan Zhang.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #354 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/354/ ) HDFS-1178 . The NameNode servlets should not use RPC to connect to the NameNode. Contributed by Kan Zhang.

            People

            • Assignee:
              Owen O'Malley
              Reporter:
              Owen O'Malley
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development