Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.4
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      There are 1 findbugs warning in branch-2.7.
      https://builds.apache.org/job/PreCommit-HDFS-Build/19204/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html

      Inconsistent synchronization of org.apache.hadoop.hdfs.DFSOutputStream.bytesCurBlock; locked 96% of time
      Bug type IS2_INCONSISTENT_SYNC
      In class org.apache.hadoop.hdfs.DFSOutputStream
      Field org.apache.hadoop.hdfs.DFSOutputStream.bytesCurBlock
      Synchronized 96% of the time
      Unsynchronized access at DFSOutputStream.java:[line 2009]
      Synchronized access at DFSOutputStream.java:[line 2376]
      (snip)
      

        Issue Links

          Activity

          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to branch-2.7. Thanks Chen Liang for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to branch-2.7. Thanks Chen Liang for the contribution!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, I ran the failed tests locally and all of them passed.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, I ran the failed tests locally and all of them passed.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 29s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 5m 59s branch-2.7 passed
          +1 compile 0m 59s branch-2.7 passed with JDK v1.8.0_131
          +1 compile 1m 1s branch-2.7 passed with JDK v1.7.0_121
          +1 checkstyle 0m 25s branch-2.7 passed
          +1 mvnsite 0m 59s branch-2.7 passed
          +1 mvneclipse 0m 15s branch-2.7 passed
          -1 findbugs 2m 56s hadoop-hdfs-project/hadoop-hdfs in branch-2.7 has 1 extant Findbugs warnings.
          +1 javadoc 0m 58s branch-2.7 passed with JDK v1.8.0_131
          +1 javadoc 1m 41s branch-2.7 passed with JDK v1.7.0_121
          +1 mvninstall 0m 51s the patch passed
          +1 compile 0m 55s the patch passed with JDK v1.8.0_131
          +1 javac 0m 55s the patch passed
          +1 compile 0m 59s the patch passed with JDK v1.7.0_121
          +1 javac 0m 59s the patch passed
          -0 checkstyle 0m 22s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 119 unchanged - 1 fixed = 120 total (was 120)
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          -1 whitespace 0m 0s The patch has 1263 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 30s The patch 70 line(s) with tabs.
          +1 findbugs 3m 7s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
          +1 javadoc 1m 4s the patch passed with JDK v1.8.0_131
          +1 javadoc 1m 43s the patch passed with JDK v1.7.0_121
          -1 unit 47m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_121.
          -1 asflicense 0m 19s The patch generated 3 ASF License warnings.
          129m 43s



          Reason Tests
          JDK v1.8.0_131 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.server.namenode.ha.TestDNFencing
          JDK v1.8.0_131 Timed out junit tests org.apache.hadoop.hdfs.web.TestWebHdfsTokens
          JDK v1.7.0_121 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.server.namenode.ha.TestDNFencing



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HDFS-11766
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867007/HDFS-11766-branch-2.7.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3a4e8f202c01 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / c7c4108
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19350/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19350/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19350/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19350/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19350/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19350/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/19350/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19350/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 5m 59s branch-2.7 passed +1 compile 0m 59s branch-2.7 passed with JDK v1.8.0_131 +1 compile 1m 1s branch-2.7 passed with JDK v1.7.0_121 +1 checkstyle 0m 25s branch-2.7 passed +1 mvnsite 0m 59s branch-2.7 passed +1 mvneclipse 0m 15s branch-2.7 passed -1 findbugs 2m 56s hadoop-hdfs-project/hadoop-hdfs in branch-2.7 has 1 extant Findbugs warnings. +1 javadoc 0m 58s branch-2.7 passed with JDK v1.8.0_131 +1 javadoc 1m 41s branch-2.7 passed with JDK v1.7.0_121 +1 mvninstall 0m 51s the patch passed +1 compile 0m 55s the patch passed with JDK v1.8.0_131 +1 javac 0m 55s the patch passed +1 compile 0m 59s the patch passed with JDK v1.7.0_121 +1 javac 0m 59s the patch passed -0 checkstyle 0m 22s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 119 unchanged - 1 fixed = 120 total (was 120) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 13s the patch passed -1 whitespace 0m 0s The patch has 1263 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 30s The patch 70 line(s) with tabs. +1 findbugs 3m 7s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) +1 javadoc 1m 4s the patch passed with JDK v1.8.0_131 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_121 -1 unit 47m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_121. -1 asflicense 0m 19s The patch generated 3 ASF License warnings. 129m 43s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.ha.TestDNFencing JDK v1.8.0_131 Timed out junit tests org.apache.hadoop.hdfs.web.TestWebHdfsTokens JDK v1.7.0_121 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.ha.TestDNFencing Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HDFS-11766 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867007/HDFS-11766-branch-2.7.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3a4e8f202c01 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / c7c4108 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19350/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19350/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19350/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19350/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19350/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19350/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/19350/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19350/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vagarychen Chen Liang added a comment -

          Post v001 patch to add the synchronization.

          Show
          vagarychen Chen Liang added a comment - Post v001 patch to add the synchronization.

            People

            • Assignee:
              vagarychen Chen Liang
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development