Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11738

Hedged pread takes more time when block moved from initial locations

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1, 2.8.3
    • Component/s: hdfs-client
    • Labels:
      None

      Description

      Scenario :
      Same as HDFS-11708.

      During Hedge read,
      1. First two locations fails to read the data in hedged mode.
      2. chooseData refetches locations and adds a future to read from DN3.
      3. after adding future to DN3, main thread goes for refetching locations in loop and stucks there till all 3 retries to fetch locations exhausted, which consumes ~20 seconds with exponential retry time.

      1. HDFS-11738-01.patch
        28 kB
        Vinayakumar B
      2. HDFS-11738-02.patch
        14 kB
        Vinayakumar B
      3. HDFS-11738-03.patch
        13 kB
        Vinayakumar B
      4. HDFS-11738-04.patch
        14 kB
        Vinayakumar B
      5. HDFS-11738-05.patch
        12 kB
        Vinayakumar B
      6. HDFS-11738-branch-2.8-committed.patch
        12 kB
        Vinayakumar B
      7. HDFS-11738-branch-2-committed.patch
        13 kB
        Vinayakumar B

        Issue Links

          Activity

          Hide
          vinayrpet Vinayakumar B added a comment -

          Test added in HDFS-11708 detected this issue. So no more test has been added.
          If the source changes removed then test will timeout (actually takes more than 40 seconds to complete), but finally read will succeed if there was no timeout.

          Current patch includes both HDFS-11708 and HDFS-11738 changes as HDFS-11708 is not committed yet.

          Show
          vinayrpet Vinayakumar B added a comment - Test added in HDFS-11708 detected this issue. So no more test has been added. If the source changes removed then test will timeout (actually takes more than 40 seconds to complete), but finally read will succeed if there was no timeout. Current patch includes both HDFS-11708 and HDFS-11738 changes as HDFS-11708 is not committed yet.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 23s Maven dependency ordering for branch
          +1 mvninstall 13m 30s trunk passed
          +1 compile 1m 26s trunk passed
          +1 checkstyle 0m 42s trunk passed
          +1 mvnsite 1m 26s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          -1 findbugs 1m 19s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 41s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 1m 1s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 20s the patch passed
          +1 compile 1m 23s the patch passed
          +1 javac 1m 23s the patch passed
          -0 checkstyle 0m 40s hadoop-hdfs-project: The patch generated 1 new + 178 unchanged - 4 fixed = 179 total (was 182)
          +1 mvnsite 1m 22s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 11s the patch passed
          +1 javadoc 0m 56s the patch passed
          +1 unit 1m 10s hadoop-hdfs-client in the patch passed.
          -1 unit 71m 40s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          106m 7s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.TestMetadataVersionOutput
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.namenode.TestStartup
          Timed out junit tests org.apache.hadoop.hdfs.TestPread



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11738
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865942/HDFS-11738-01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ae9517076db7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b0f54ea
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19267/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19267/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19267/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/19267/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19267/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19267/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 23s Maven dependency ordering for branch +1 mvninstall 13m 30s trunk passed +1 compile 1m 26s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 1m 26s trunk passed +1 mvneclipse 0m 28s trunk passed -1 findbugs 1m 19s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 41s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 1s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 20s the patch passed +1 compile 1m 23s the patch passed +1 javac 1m 23s the patch passed -0 checkstyle 0m 40s hadoop-hdfs-project: The patch generated 1 new + 178 unchanged - 4 fixed = 179 total (was 182) +1 mvnsite 1m 22s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 11s the patch passed +1 javadoc 0m 56s the patch passed +1 unit 1m 10s hadoop-hdfs-client in the patch passed. -1 unit 71m 40s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 106m 7s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestMetadataVersionOutput   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.TestStartup Timed out junit tests org.apache.hadoop.hdfs.TestPread Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11738 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865942/HDFS-11738-01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ae9517076db7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b0f54ea Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19267/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19267/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19267/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19267/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19267/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19267/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Test failures and findbugs are unrelated.

          Show
          vinayrpet Vinayakumar B added a comment - Test failures and findbugs are unrelated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Hi Zhe Zhang,
          Can you please take a look at this?

          Show
          vinayrpet Vinayakumar B added a comment - Hi Zhe Zhang , Can you please take a look at this?
          Hide
          vinayrpet Vinayakumar B added a comment -

          Hi Chris Nauroth/Andrew Wang/Jing Zhao
          Can anyone review changes.. as you have worked on this part of code before.
          Thanks.

          Show
          vinayrpet Vinayakumar B added a comment - Hi Chris Nauroth / Andrew Wang / Jing Zhao Can anyone review changes.. as you have worked on this part of code before. Thanks.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Updated the patch after HDFS-11708.
          Please review.

          Show
          vinayrpet Vinayakumar B added a comment - Updated the patch after HDFS-11708 . Please review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 6s Maven dependency ordering for branch
          +1 mvninstall 12m 45s trunk passed
          +1 compile 1m 18s trunk passed
          +1 checkstyle 0m 35s trunk passed
          +1 mvnsite 1m 20s trunk passed
          -1 findbugs 1m 19s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 32s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 0m 54s trunk passed
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 14s the patch passed
          +1 compile 1m 18s the patch passed
          +1 javac 1m 18s the patch passed
          -0 checkstyle 0m 34s hadoop-hdfs-project: The patch generated 1 new + 56 unchanged - 4 fixed = 57 total (was 60)
          +1 mvnsite 1m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 13s the patch passed
          +1 javadoc 0m 57s the patch passed
          +1 unit 1m 15s hadoop-hdfs-client in the patch passed.
          -1 unit 67m 48s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          99m 18s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070
            hadoop.hdfs.web.TestWebHdfsTimeouts
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11738
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875235/HDFS-11738-02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 80bb45ebb55e 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3be2659
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20120/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20120/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20120/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20120/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20120/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20120/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 6s Maven dependency ordering for branch +1 mvninstall 12m 45s trunk passed +1 compile 1m 18s trunk passed +1 checkstyle 0m 35s trunk passed +1 mvnsite 1m 20s trunk passed -1 findbugs 1m 19s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 32s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 0m 54s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 14s the patch passed +1 compile 1m 18s the patch passed +1 javac 1m 18s the patch passed -0 checkstyle 0m 34s hadoop-hdfs-project: The patch generated 1 new + 56 unchanged - 4 fixed = 57 total (was 60) +1 mvnsite 1m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 13s the patch passed +1 javadoc 0m 57s the patch passed +1 unit 1m 15s hadoop-hdfs-client in the patch passed. -1 unit 67m 48s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 99m 18s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070   hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11738 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875235/HDFS-11738-02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 80bb45ebb55e 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3be2659 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20120/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20120/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20120/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20120/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20120/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20120/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Vinayakumar B for the patch! I haven't reviewed the patch fully, but looking at the patch, this jira is the superset of HDFS-11303.
          Perhaps we should give up HDFS-11303 and focus on this one.

          John Zhuge how do you think?

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Vinayakumar B for the patch! I haven't reviewed the patch fully, but looking at the patch, this jira is the superset of HDFS-11303 . Perhaps we should give up HDFS-11303 and focus on this one. John Zhuge how do you think?
          Hide
          vinayrpet Vinayakumar B added a comment -

          I see that, Following changes in DFSInputStream#hedgedFetchBlockByteRange(..) present in both HDFS-11303 and this jira,

                   futures.add(firstRequest);
          +        Future<ByteBuffer> future = null;
                   try {
          -          Future<ByteBuffer> future = hedgedService.poll(
          +          future = hedgedService.poll(
                         conf.getHedgedReadThresholdMillis(), TimeUnit.MILLISECONDS);
                     if (future != null) {
                       ByteBuffer result = future.get();
          @@ -1142,16 +1143,18 @@ private void hedgedFetchBlockByteRange(LocatedBlock block, long start,
                     }
                     DFSClient.LOG.debug("Waited {}ms to read from {}; spawning hedged "
                         + "read", conf.getHedgedReadThresholdMillis(), chosenNode.info);
          -          // Ignore this node on next go around.
          -          ignored.add(chosenNode.info);
                     dfsClient.getHedgedReadMetrics().incHedgedReadOps();
                     // continue; no need to refresh block locations
                   } catch (ExecutionException e) {
          -          // Ignore
          +          futures.remove(future);
                   } catch (InterruptedException e) {
                     throw new InterruptedIOException(
                         "Interrupted while waiting for reading task");
                   }
          +        // Ignore this node on next go around.
          +        // If poll timeout and the request still ongoing, don't consider it
          +        // again. If read data failed, don't consider it either.
          +        ignored.add(chosenNode.info);
                 } else {
                   // We are starting up a 'hedged' read. We have a read already
                   // ongoing. Call getBestNodeDNAddrPair instead of chooseDataNode.
          

          I think its fair to commit HDFS-11303 first and give credit for John Zhuge's efforts, as it has associated test written along with the change.

          I can update the patch again once HDFS-11303 committed. Anyway test in my patch will fail even after HDFS-11303 is committed. i.e. HDFS-11303 is not exactly the fix for this issue.
          So lets get HDFS-11303 committed first.

          Show
          vinayrpet Vinayakumar B added a comment - I see that, Following changes in DFSInputStream#hedgedFetchBlockByteRange(..) present in both HDFS-11303 and this jira, futures.add(firstRequest); + Future<ByteBuffer> future = null ; try { - Future<ByteBuffer> future = hedgedService.poll( + future = hedgedService.poll( conf.getHedgedReadThresholdMillis(), TimeUnit.MILLISECONDS); if ( future != null ) { ByteBuffer result = future .get(); @@ -1142,16 +1143,18 @@ private void hedgedFetchBlockByteRange(LocatedBlock block, long start, } DFSClient.LOG.debug( "Waited {}ms to read from {}; spawning hedged " + "read" , conf.getHedgedReadThresholdMillis(), chosenNode.info); - // Ignore this node on next go around. - ignored.add(chosenNode.info); dfsClient.getHedgedReadMetrics().incHedgedReadOps(); // continue ; no need to refresh block locations } catch (ExecutionException e) { - // Ignore + futures.remove( future ); } catch (InterruptedException e) { throw new InterruptedIOException( "Interrupted while waiting for reading task" ); } + // Ignore this node on next go around. + // If poll timeout and the request still ongoing, don't consider it + // again. If read data failed, don't consider it either. + ignored.add(chosenNode.info); } else { // We are starting up a 'hedged' read. We have a read already // ongoing. Call getBestNodeDNAddrPair instead of chooseDataNode. I think its fair to commit HDFS-11303 first and give credit for John Zhuge 's efforts, as it has associated test written along with the change. I can update the patch again once HDFS-11303 committed. Anyway test in my patch will fail even after HDFS-11303 is committed. i.e. HDFS-11303 is not exactly the fix for this issue. So lets get HDFS-11303 committed first.
          Hide
          jzhuge John Zhuge added a comment -

          Chen Zhang is the original author. Wei-Chiu Chuang and I just tried to help move it forward.

          I am ok with Vinayakumar B's plan since Chen Zhang's work in DFSInputStream and the new unit test deserves the credit.

          Show
          jzhuge John Zhuge added a comment - Chen Zhang is the original author. Wei-Chiu Chuang and I just tried to help move it forward. I am ok with Vinayakumar B 's plan since Chen Zhang 's work in DFSInputStream and the new unit test deserves the credit.
          Hide
          jzhuge John Zhuge added a comment - - edited

          Vinayakumar B HDFS-11303 has been committed.

          Show
          jzhuge John Zhuge added a comment - - edited Vinayakumar B HDFS-11303 has been committed.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Updated the patch after HDFS-11303.
          Thanks for John Zhuge for headsup.

          Show
          vinayrpet Vinayakumar B added a comment - Updated the patch after HDFS-11303 . Thanks for John Zhuge for headsup.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 37s Maven dependency ordering for branch
          +1 mvninstall 14m 24s trunk passed
          +1 compile 1m 27s trunk passed
          +1 checkstyle 0m 41s trunk passed
          +1 mvnsite 1m 28s trunk passed
          -1 findbugs 1m 24s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
          -1 findbugs 1m 40s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
          +1 javadoc 1m 2s trunk passed
                Patch Compile Tests
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 21s the patch passed
          +1 compile 1m 23s the patch passed
          +1 javac 1m 23s the patch passed
          -0 checkstyle 0m 39s hadoop-hdfs-project: The patch generated 1 new + 56 unchanged - 4 fixed = 57 total (was 60)
          +1 mvnsite 1m 23s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 15s the patch passed
          +1 javadoc 0m 57s the patch passed
                Other Tests
          +1 unit 1m 11s hadoop-hdfs-client in the patch passed.
          -1 unit 90m 5s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          125m 3s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestReadStripedFileWithMissingBlocks
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
            hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.TestReconstructStripedFile
          Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
            org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11738
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881780/HDFS-11738-03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b10d6081b78e 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d8f74c3
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20686/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20686/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20686/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20686/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20686/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20686/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 37s Maven dependency ordering for branch +1 mvninstall 14m 24s trunk passed +1 compile 1m 27s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 28s trunk passed -1 findbugs 1m 24s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 40s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 1m 2s trunk passed       Patch Compile Tests 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 21s the patch passed +1 compile 1m 23s the patch passed +1 javac 1m 23s the patch passed -0 checkstyle 0m 39s hadoop-hdfs-project: The patch generated 1 new + 56 unchanged - 4 fixed = 57 total (was 60) +1 mvnsite 1m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 15s the patch passed +1 javadoc 0m 57s the patch passed       Other Tests +1 unit 1m 11s hadoop-hdfs-client in the patch passed. -1 unit 90m 5s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 125m 3s Reason Tests Failed junit tests hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestReconstructStripedFile Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2   org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11738 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881780/HDFS-11738-03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b10d6081b78e 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d8f74c3 Default Java 1.8.0_144 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20686/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20686/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20686/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20686/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20686/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20686/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Hello Vinayakumar B thanks for the patch!
          I reviewed the patch and I think I grasp the gist of the patch. IIUC, the client would stuck in chooseDataNode() in such a scenario?

          The method chooseDataNode should add a @Nullable to indicate a null return value is valid.

          It seems the following code

          DFSInputStream#hedgedFetchBlockByteRange
                    chosenNode = getBestNodeDNAddrPair(block, ignored);
                    if (chosenNode == null) {
                      chosenNode = chooseDataNode(block, ignored, false);
                    }
          

          can be simplified as

          chosenNode = chooseDataNode(block, ignored, false);
          

          I ran the patch with the simplified code and it passed as well.

          The timeout of 30 seconds seems a little short. On my laptop this test takes approximately 20 seconds, so on a busy host the unit test might potentially run slightly over time. Or would it be reasonable to reduce some wait time?
          E.g. reduce dfs.client.retry.window.base from 3000 to 1000?

          conf.setInt(HdfsClientConfigKeys.Retry.WINDOW_BASE_KEY, 1000);
          
          Show
          jojochuang Wei-Chiu Chuang added a comment - Hello Vinayakumar B thanks for the patch! I reviewed the patch and I think I grasp the gist of the patch. IIUC, the client would stuck in chooseDataNode() in such a scenario? The method chooseDataNode should add a @Nullable to indicate a null return value is valid. It seems the following code DFSInputStream#hedgedFetchBlockByteRange chosenNode = getBestNodeDNAddrPair(block, ignored); if (chosenNode == null ) { chosenNode = chooseDataNode(block, ignored, false ); } can be simplified as chosenNode = chooseDataNode(block, ignored, false ); I ran the patch with the simplified code and it passed as well. The timeout of 30 seconds seems a little short. On my laptop this test takes approximately 20 seconds, so on a busy host the unit test might potentially run slightly over time. Or would it be reasonable to reduce some wait time? E.g. reduce dfs.client.retry.window.base from 3000 to 1000? conf.setInt(HdfsClientConfigKeys.Retry.WINDOW_BASE_KEY, 1000);
          Hide
          vinayrpet Vinayakumar B added a comment -

          Updated the patch addressing above comments.

          Show
          vinayrpet Vinayakumar B added a comment - Updated the patch addressing above comments.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Thanks Wei-Chiu Chuang for reviewing changes.

          IIUC, the client would stuck in chooseDataNode() in such a scenario?

          Yeah, reader thread goes on retry until max retries, and gets BlockMissedException. But since this is a hedged read, already read would have completed with actual host. So read will completes successfully, but call will return to user only after all retries exhausted. Non-hedge case, read would fail. It was fixed in HDFS-11708.

          The method chooseDataNode should add a @Nullable to indicate a null return value is valid.

          I tried to add @Nullable, but my IDE started showing some javadoc error. So added the whole javadoc mentioning about possible null return value. Hope that satisfies you.

          can be simplified as chosenNode = chooseDataNode(block, ignored, false);

          Thats a good catch. changed.

          The timeout of 30 seconds seems a little short. On my laptop this test takes approximately 20 seconds, so on a busy host the unit test might potentially run slightly over time. Or would it be reasonable to reduce some wait time?
          E.g. reduce dfs.client.retry.window.base from 3000 to 1000?

          Yeah, increased the timeout to 60000 and reduced the window time to 1000 as well. Thank you for the hint.

          please check updated patch

          Show
          vinayrpet Vinayakumar B added a comment - Thanks Wei-Chiu Chuang for reviewing changes. IIUC, the client would stuck in chooseDataNode() in such a scenario? Yeah, reader thread goes on retry until max retries, and gets BlockMissedException . But since this is a hedged read, already read would have completed with actual host. So read will completes successfully, but call will return to user only after all retries exhausted. Non-hedge case, read would fail. It was fixed in HDFS-11708 . The method chooseDataNode should add a @Nullable to indicate a null return value is valid. I tried to add @Nullable, but my IDE started showing some javadoc error. So added the whole javadoc mentioning about possible null return value. Hope that satisfies you. can be simplified as chosenNode = chooseDataNode(block, ignored, false); Thats a good catch. changed. The timeout of 30 seconds seems a little short. On my laptop this test takes approximately 20 seconds, so on a busy host the unit test might potentially run slightly over time. Or would it be reasonable to reduce some wait time? E.g. reduce dfs.client.retry.window.base from 3000 to 1000? Yeah, increased the timeout to 60000 and reduced the window time to 1000 as well. Thank you for the hint. please check updated patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 14m 21s trunk passed
          +1 compile 1m 32s trunk passed
          +1 checkstyle 0m 43s trunk passed
          +1 mvnsite 1m 32s trunk passed
          +1 findbugs 3m 44s trunk passed
          +1 javadoc 1m 7s trunk passed
                Patch Compile Tests
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 27s the patch passed
          +1 compile 1m 33s the patch passed
          +1 javac 1m 33s the patch passed
          -0 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 1 new + 56 unchanged - 4 fixed = 57 total (was 60)
          +1 mvnsite 1m 31s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 58s the patch passed
          +1 javadoc 1m 2s the patch passed
                Other Tests
          +1 unit 1m 19s hadoop-hdfs-client in the patch passed.
          -1 unit 64m 38s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          101m 32s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11738
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881979/HDFS-11738-04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 721132749b0a 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dadb0c2
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20704/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20704/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20704/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20704/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 14m 21s trunk passed +1 compile 1m 32s trunk passed +1 checkstyle 0m 43s trunk passed +1 mvnsite 1m 32s trunk passed +1 findbugs 3m 44s trunk passed +1 javadoc 1m 7s trunk passed       Patch Compile Tests 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 1m 33s the patch passed +1 javac 1m 33s the patch passed -0 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 1 new + 56 unchanged - 4 fixed = 57 total (was 60) +1 mvnsite 1m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 58s the patch passed +1 javadoc 1m 2s the patch passed       Other Tests +1 unit 1m 19s hadoop-hdfs-client in the patch passed. -1 unit 64m 38s hadoop-hdfs in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 101m 32s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11738 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881979/HDFS-11738-04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 721132749b0a 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dadb0c2 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20704/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20704/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20704/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20704/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Test failure is unrelated.
          checkstyle is about line length, could be corrected during commit.

          Show
          vinayrpet Vinayakumar B added a comment - Test failure is unrelated. checkstyle is about line length, could be corrected during commit.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks, the latest patch looks really good to me.

          On a separate note,
          I really don't like the lengthy DFSInputStream#hedgedFetchBlockByteRange() method though. the if .. else blocks contain the code that looks similar. I feel it can use some refactory, or split the method into two. But that's really secondary to this patch.

          Would any one else like to chime in? Thanks

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks, the latest patch looks really good to me. On a separate note, I really don't like the lengthy DFSInputStream#hedgedFetchBlockByteRange() method though. the if .. else blocks contain the code that looks similar. I feel it can use some refactory, or split the method into two. But that's really secondary to this patch. Would any one else like to chime in? Thanks
          Hide
          vinayrpet Vinayakumar B added a comment -

          Thanks Wei-Chiu Chuang.
          John Zhuge, do you want to take a look at patch?

          I really don't like the lengthy DFSInputStream#hedgedFetchBlockByteRange() method though. the if .. else blocks contain the code that looks similar. I feel it can use some refactory, or split the method into two. But that's really secondary to this patch.

          I prefer to do it in separate jira.

          Show
          vinayrpet Vinayakumar B added a comment - Thanks Wei-Chiu Chuang . John Zhuge , do you want to take a look at patch? I really don't like the lengthy DFSInputStream#hedgedFetchBlockByteRange() method though. the if .. else blocks contain the code that looks similar. I feel it can use some refactory, or split the method into two. But that's really secondary to this patch. I prefer to do it in separate jira.
          Hide
          jzhuge John Zhuge added a comment -

          Ok, will do before tomorrow noon.

          Show
          jzhuge John Zhuge added a comment - Ok, will do before tomorrow noon.
          Hide
          jzhuge John Zhuge added a comment -

          The patch looks great! Only a few minor comments:

          • Keep the old chooseDataNode with 2 parameters. A few changes can be avoided.
          • DFSInputStream.java:836: typo, replace "Whether to refetch if no nodes to chose currently." with "Whether to refetch if no node to choose from."
          • TestPread:766: replace "maximum two failures" with "maximum " + maxFailures + " failures".
          Show
          jzhuge John Zhuge added a comment - The patch looks great! Only a few minor comments: Keep the old chooseDataNode with 2 parameters. A few changes can be avoided. DFSInputStream.java:836: typo, replace "Whether to refetch if no nodes to chose currently." with "Whether to refetch if no node to choose from." TestPread:766: replace "maximum two failures" with "maximum " + maxFailures + " failures".
          Hide
          vinayrpet Vinayakumar B added a comment -

          Updated the patch addressing John Zhuge's comments.
          Please review.

          Show
          vinayrpet Vinayakumar B added a comment - Updated the patch addressing John Zhuge 's comments. Please review.
          Hide
          jzhuge John Zhuge added a comment -

          +1 LGTM pending pre-commit tests.

          Still typo: "no nodes to chose\nfrom"; should be "no node to choose from", but we can take care of during commit.

          Show
          jzhuge John Zhuge added a comment - +1 LGTM pending pre-commit tests. Still typo: "no nodes to chose\nfrom"; should be "no node to choose from", but we can take care of during commit.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 15m 32s trunk passed
          +1 compile 1m 37s trunk passed
          +1 checkstyle 0m 42s trunk passed
          +1 mvnsite 1m 35s trunk passed
          +1 findbugs 3m 6s trunk passed
          +1 javadoc 1m 6s trunk passed
                Patch Compile Tests
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 26s the patch passed
          +1 compile 1m 31s the patch passed
          +1 javac 1m 31s the patch passed
          -0 checkstyle 0m 40s hadoop-hdfs-project: The patch generated 1 new + 57 unchanged - 4 fixed = 58 total (was 61)
          +1 mvnsite 1m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 24s the patch passed
          +1 javadoc 1m 0s the patch passed
                Other Tests
          +1 unit 1m 14s hadoop-hdfs-client in the patch passed.
          -1 unit 68m 19s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          105m 0s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
            hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.hdfs.TestCrcCorruption



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11738
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882622/HDFS-11738-05.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a9a8a06932e9 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2d105a2
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20757/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20757/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20757/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20757/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 15m 32s trunk passed +1 compile 1m 37s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 1m 35s trunk passed +1 findbugs 3m 6s trunk passed +1 javadoc 1m 6s trunk passed       Patch Compile Tests 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 26s the patch passed +1 compile 1m 31s the patch passed +1 javac 1m 31s the patch passed -0 checkstyle 0m 40s hadoop-hdfs-project: The patch generated 1 new + 57 unchanged - 4 fixed = 58 total (was 61) +1 mvnsite 1m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 24s the patch passed +1 javadoc 1m 0s the patch passed       Other Tests +1 unit 1m 14s hadoop-hdfs-client in the patch passed. -1 unit 68m 19s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 105m 0s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.TestCrcCorruption Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11738 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882622/HDFS-11738-05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a9a8a06932e9 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2d105a2 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20757/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20757/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20757/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20757/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          Plan to commit tomorrow if no objection. Will take care of the typo and 1 checkstyle issue during commit.

          Show
          jzhuge John Zhuge added a comment - Plan to commit tomorrow if no objection. Will take care of the typo and 1 checkstyle issue during commit.
          Hide
          jzhuge John Zhuge added a comment -

          Committed to trunk.

          Thanks Vinayakumar B for the contribution! Thanks Wei-Chiu Chuang for the review!

          Show
          jzhuge John Zhuge added a comment - Committed to trunk. Thanks Vinayakumar B for the contribution! Thanks Wei-Chiu Chuang for the review!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12220 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12220/)
          HDFS-11738. Hedged pread takes more time when block moved from initial (jzhuge: rev b6bfb2fcb2391d51b8de97c01c1290880779132e)

          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClientFaultInjector.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestPread.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12220 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12220/ ) HDFS-11738 . Hedged pread takes more time when block moved from initial (jzhuge: rev b6bfb2fcb2391d51b8de97c01c1290880779132e) (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClientFaultInjector.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestPread.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          Hide
          vinayrpet Vinayakumar B added a comment -

          pushed to branch-2 and branch-2.8 as well after resolving minor conflcts

          Show
          vinayrpet Vinayakumar B added a comment - pushed to branch-2 and branch-2.8 as well after resolving minor conflcts
          Hide
          vinayrpet Vinayakumar B added a comment -

          attaching committed patches for reference

          Show
          vinayrpet Vinayakumar B added a comment - attaching committed patches for reference

            People

            • Assignee:
              vinayrpet Vinayakumar B
              Reporter:
              vinayrpet Vinayakumar B
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development