Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11646

Add -E option in 'ls' to list erasure coding policy of each file and directory if applicable

    Details

      Description

      Add -E option in "ls" to show erasure coding policy of file and directory, leverage the "number_of_replicas " column.

      1. HDFS-11646-001.patch
        14 kB
        luhuichun
      2. HDFS-11646-002.patch
        15 kB
        luhuichun
      3. HDFS-11646-003.patch
        17 kB
        luhuichun
      4. HDFS-11646-004.patch
        17 kB
        luhuichun
      5. HDFS-11646-005.patch
        11 kB
        luhuichun

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 8s HDFS-11646 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HDFS-11646
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870936/HADOOP-11646.patch
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19786/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 8s HDFS-11646 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-11646 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870936/HADOOP-11646.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19786/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Hi luhuichun do you mind providing some examples of the new output? We probably also need a corresponding doc update in the FS Shell guide and maybe also the EC docs.

        Show
        andrew.wang Andrew Wang added a comment - Hi luhuichun do you mind providing some examples of the new output? We probably also need a corresponding doc update in the FS Shell guide and maybe also the EC docs.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Hi,luhuichun Thanks a lot for working on this.

        Some minor nits:

        • Could you limit the patch to the lines that are actually changed? A few diffs are due to re-format of the code.
        • In processPath, does lineFormat change due to the value of displayPolicy ? Could you also add tests for both cases?

        Thanks!

        Show
        eddyxu Lei (Eddy) Xu added a comment - Hi, luhuichun Thanks a lot for working on this. Some minor nits: Could you limit the patch to the lines that are actually changed? A few diffs are due to re-format of the code. In processPath , does lineFormat change due to the value of displayPolicy ? Could you also add tests for both cases? Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 8s HDFS-11646 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HDFS-11646
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872216/HDFS-11646-001.patch
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19846/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 8s HDFS-11646 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-11646 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872216/HDFS-11646-001.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19846/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 1m 25s Maven dependency ordering for branch
        +1 mvninstall 12m 36s trunk passed
        +1 compile 13m 35s trunk passed
        +1 checkstyle 1m 49s trunk passed
        +1 mvnsite 2m 37s trunk passed
        -1 findbugs 1m 19s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 2m 8s trunk passed
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 53s the patch passed
        +1 compile 10m 15s the patch passed
        +1 cc 10m 15s the patch passed
        +1 javac 10m 15s the patch passed
        -0 checkstyle 1m 53s root: The patch generated 9 new + 160 unchanged - 0 fixed = 169 total (was 160)
        +1 mvnsite 2m 38s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        -1 findbugs 1m 48s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 javadoc 2m 11s the patch passed
        -1 unit 19m 11s hadoop-common in the patch failed.
        +1 unit 1m 18s hadoop-hdfs-client in the patch passed.
        -1 unit 64m 7s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 27s The patch does not generate ASF License warnings.
        149m 20s



        Reason Tests
        FindBugs module:hadoop-hdfs-project/hadoop-hdfs
          Dead store to bsp in org.apache.hadoop.hdfs.server.namenode.INodeFile.computeContentSummary(int, ContentSummaryComputationContext) At INodeFile.java:org.apache.hadoop.hdfs.server.namenode.INodeFile.computeContentSummary(int, ContentSummaryComputationContext) At INodeFile.java:[line 862]
        Failed junit tests hadoop.fs.TestFsShellReturnCode
          hadoop.security.TestRaceWhenRelogin
          hadoop.cli.TestCLI
          hadoop.fs.shell.TestAclCommands
          hadoop.hdfs.TestDFSShell
          hadoop.cli.TestAclCLI
          hadoop.cli.TestCryptoAdminCLI
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.cli.TestAclCLIWithPosixAclInheritance
          hadoop.hdfs.web.TestWebHdfsTimeouts
          hadoop.cli.TestHDFSCLI
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160
          hadoop.hdfs.TestSnapshotCommands
        Timed out junit tests org.apache.hadoop.fs.shell.TestLs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11646
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872225/HDFS-11646-002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml
        uname Linux f4f0b3cbbda9 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 99634d1
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19848/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19848/artifact/patchprocess/diff-checkstyle-root.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19848/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19848/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19848/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19848/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19848/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 25s Maven dependency ordering for branch +1 mvninstall 12m 36s trunk passed +1 compile 13m 35s trunk passed +1 checkstyle 1m 49s trunk passed +1 mvnsite 2m 37s trunk passed -1 findbugs 1m 19s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 2m 8s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 53s the patch passed +1 compile 10m 15s the patch passed +1 cc 10m 15s the patch passed +1 javac 10m 15s the patch passed -0 checkstyle 1m 53s root: The patch generated 9 new + 160 unchanged - 0 fixed = 169 total (was 160) +1 mvnsite 2m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 findbugs 1m 48s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 2m 11s the patch passed -1 unit 19m 11s hadoop-common in the patch failed. +1 unit 1m 18s hadoop-hdfs-client in the patch passed. -1 unit 64m 7s hadoop-hdfs in the patch failed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 149m 20s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Dead store to bsp in org.apache.hadoop.hdfs.server.namenode.INodeFile.computeContentSummary(int, ContentSummaryComputationContext) At INodeFile.java:org.apache.hadoop.hdfs.server.namenode.INodeFile.computeContentSummary(int, ContentSummaryComputationContext) At INodeFile.java: [line 862] Failed junit tests hadoop.fs.TestFsShellReturnCode   hadoop.security.TestRaceWhenRelogin   hadoop.cli.TestCLI   hadoop.fs.shell.TestAclCommands   hadoop.hdfs.TestDFSShell   hadoop.cli.TestAclCLI   hadoop.cli.TestCryptoAdminCLI   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.cli.TestAclCLIWithPosixAclInheritance   hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.cli.TestHDFSCLI   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160   hadoop.hdfs.TestSnapshotCommands Timed out junit tests org.apache.hadoop.fs.shell.TestLs Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11646 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872225/HDFS-11646-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc xml uname Linux f4f0b3cbbda9 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99634d1 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19848/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19848/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19848/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19848/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19848/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19848/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19848/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Hey, luhuichun

        I saw a few CLI related test failures, could you help to verify whether they are related ? Also please also kindly take a look of checkstyle and findbugs reports.

        Thanks!

        Show
        eddyxu Lei (Eddy) Xu added a comment - Hey, luhuichun I saw a few CLI related test failures, could you help to verify whether they are related ? Also please also kindly take a look of checkstyle and findbugs reports. Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 5s HDFS-11646 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HDFS-11646
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872836/HADOOP-11646.patch
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19894/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HDFS-11646 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-11646 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872836/HADOOP-11646.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19894/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 1m 21s Maven dependency ordering for branch
        +1 mvninstall 13m 2s trunk passed
        +1 compile 13m 29s trunk passed
        +1 checkstyle 1m 55s trunk passed
        +1 mvnsite 2m 45s trunk passed
        -1 findbugs 1m 23s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 2m 3s trunk passed
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 1m 59s the patch passed
        +1 compile 10m 8s the patch passed
        +1 cc 10m 8s the patch passed
        +1 javac 10m 8s the patch passed
        -0 checkstyle 1m 55s root: The patch generated 8 new + 138 unchanged - 0 fixed = 146 total (was 138)
        +1 mvnsite 2m 42s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 5m 4s the patch passed
        +1 javadoc 2m 5s the patch passed
        +1 unit 8m 27s hadoop-common in the patch passed.
        +1 unit 1m 20s hadoop-hdfs-client in the patch passed.
        -1 unit 62m 39s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 35s The patch does not generate ASF License warnings.
        137m 59s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy
          hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11646
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872851/HDFS-11646-003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc
        uname Linux 35a0f0e312bf 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8633ef8
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19896/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19896/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19896/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19896/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19896/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 21s Maven dependency ordering for branch +1 mvninstall 13m 2s trunk passed +1 compile 13m 29s trunk passed +1 checkstyle 1m 55s trunk passed +1 mvnsite 2m 45s trunk passed -1 findbugs 1m 23s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 2m 3s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 59s the patch passed +1 compile 10m 8s the patch passed +1 cc 10m 8s the patch passed +1 javac 10m 8s the patch passed -0 checkstyle 1m 55s root: The patch generated 8 new + 138 unchanged - 0 fixed = 146 total (was 138) +1 mvnsite 2m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 5m 4s the patch passed +1 javadoc 2m 5s the patch passed +1 unit 8m 27s hadoop-common in the patch passed. +1 unit 1m 20s hadoop-hdfs-client in the patch passed. -1 unit 62m 39s hadoop-hdfs in the patch failed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 137m 59s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy   hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11646 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872851/HDFS-11646-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc uname Linux 35a0f0e312bf 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8633ef8 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19896/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19896/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19896/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19896/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19896/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 1m 31s Maven dependency ordering for branch
        +1 mvninstall 14m 34s trunk passed
        +1 compile 17m 0s trunk passed
        +1 checkstyle 2m 7s trunk passed
        +1 mvnsite 2m 52s trunk passed
        -1 findbugs 1m 25s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 2m 13s trunk passed
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 2m 4s the patch passed
        +1 compile 12m 39s the patch passed
        +1 cc 12m 39s the patch passed
        +1 javac 12m 39s the patch passed
        +1 checkstyle 2m 15s the patch passed
        +1 mvnsite 3m 32s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 5m 21s the patch passed
        +1 javadoc 2m 11s the patch passed
        +1 unit 7m 48s hadoop-common in the patch passed.
        +1 unit 1m 21s hadoop-hdfs-client in the patch passed.
        -1 unit 96m 10s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 42s The patch does not generate ASF License warnings.
        181m 7s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11646
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872917/HDFS-11646-004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc
        uname Linux cb72613f8e0b 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6ed54f3
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19902/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19902/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19902/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19902/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 31s Maven dependency ordering for branch +1 mvninstall 14m 34s trunk passed +1 compile 17m 0s trunk passed +1 checkstyle 2m 7s trunk passed +1 mvnsite 2m 52s trunk passed -1 findbugs 1m 25s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 2m 13s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 4s the patch passed +1 compile 12m 39s the patch passed +1 cc 12m 39s the patch passed +1 javac 12m 39s the patch passed +1 checkstyle 2m 15s the patch passed +1 mvnsite 3m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 5m 21s the patch passed +1 javadoc 2m 11s the patch passed +1 unit 7m 48s hadoop-common in the patch passed. +1 unit 1m 21s hadoop-hdfs-client in the patch passed. -1 unit 96m 10s hadoop-hdfs in the patch failed. +1 asflicense 0m 42s The patch does not generate ASF License warnings. 181m 7s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11646 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872917/HDFS-11646-004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml cc uname Linux cb72613f8e0b 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6ed54f3 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19902/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/19902/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19902/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19902/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        luhuichun luhuichun added a comment -

        Lei (Eddy) XuAndrew Wang thx for comments, updated the patch

        Show
        luhuichun luhuichun added a comment - Lei (Eddy) Xu Andrew Wang thx for comments, updated the patch
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Hi, luhuichun

        Sorry, I should make my comments more clear. In Ls#processPath, it prints EC policy using String.format(lineFormat, ....), while the placeholder of ec policy name is not set from adjustColumnWidths(). So It does not to print path if displayPolicy is enabled. The test testErasureCodingConf.xml seemed not to catch this bug. Could you fix it?

        Thanks!

        Show
        eddyxu Lei (Eddy) Xu added a comment - Hi, luhuichun Sorry, I should make my comments more clear. In Ls#processPath , it prints EC policy using String.format(lineFormat, ....) , while the placeholder of ec policy name is not set from adjustColumnWidths() . So It does not to print path if displayPolicy is enabled. The test testErasureCodingConf.xml seemed not to catch this bug. Could you fix it? Thanks!
        Hide
        luhuichun luhuichun added a comment -

        Lei (Eddy) Xu ok, will update today

        Show
        luhuichun luhuichun added a comment - Lei (Eddy) Xu ok, will update today
        Hide
        luhuichun luhuichun added a comment -

        update patch

        Show
        luhuichun luhuichun added a comment - update patch
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 1m 31s Maven dependency ordering for branch
        +1 mvninstall 12m 25s trunk passed
        +1 compile 13m 27s trunk passed
        +1 checkstyle 1m 45s trunk passed
        +1 mvnsite 2m 2s trunk passed
        -1 findbugs 1m 19s hadoop-common-project/hadoop-common in trunk has 17 extant Findbugs warnings.
        +1 javadoc 1m 36s trunk passed
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 1m 15s the patch passed
        +1 compile 9m 49s the patch passed
        +1 javac 9m 49s the patch passed
        -0 checkstyle 1m 45s root: The patch generated 5 new + 18 unchanged - 1 fixed = 23 total (was 19)
        +1 mvnsite 1m 59s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 3m 15s the patch passed
        +1 javadoc 1m 42s the patch passed
        +1 unit 7m 46s hadoop-common in the patch passed.
        -1 unit 65m 12s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 39s The patch does not generate ASF License warnings.
        130m 51s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070
          hadoop.hdfs.web.TestWebHdfsTimeouts
          hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
          hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11646
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873999/HDFS-11646-005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux ab1bbea7402b 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c22cf00
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19990/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19990/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19990/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19990/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19990/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 31s Maven dependency ordering for branch +1 mvninstall 12m 25s trunk passed +1 compile 13m 27s trunk passed +1 checkstyle 1m 45s trunk passed +1 mvnsite 2m 2s trunk passed -1 findbugs 1m 19s hadoop-common-project/hadoop-common in trunk has 17 extant Findbugs warnings. +1 javadoc 1m 36s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 15s the patch passed +1 compile 9m 49s the patch passed +1 javac 9m 49s the patch passed -0 checkstyle 1m 45s root: The patch generated 5 new + 18 unchanged - 1 fixed = 23 total (was 19) +1 mvnsite 1m 59s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 3m 15s the patch passed +1 javadoc 1m 42s the patch passed +1 unit 7m 46s hadoop-common in the patch passed. -1 unit 65m 12s hadoop-hdfs in the patch failed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 130m 51s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070   hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.server.blockmanagement.TestReplicationPolicy   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11646 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873999/HDFS-11646-005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux ab1bbea7402b 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c22cf00 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19990/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19990/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19990/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19990/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19990/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks for the updates, luhuichun.

        +1. Committed to trunk.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks for the updates, luhuichun . +1. Committed to trunk .

          People

          • Assignee:
            luhuichun luhuichun
            Reporter:
            Sammi SammiChen
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development