Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11645

DataXceiver thread should log the actual error when getting InvalidMagicNumberException

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1, 2.8.1
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: datanode
    • Labels:
      None

      Description

      Currently, DataXceiver#run method only logs an error message when getting an InvalidMagicNumberException. It should also log the actual exception.

        Activity

        Hide
        vagarychen Chen Liang added a comment -

        Post v001 patch with the exception logged.

        Show
        vagarychen Chen Liang added a comment - Post v001 patch with the exception logged.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 14m 5s trunk passed
        +1 compile 1m 6s trunk passed
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 1m 4s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 58s trunk passed
        +1 javadoc 0m 43s trunk passed
        +1 mvninstall 0m 59s the patch passed
        +1 compile 0m 57s the patch passed
        +1 javac 0m 57s the patch passed
        +1 checkstyle 0m 37s the patch passed
        +1 mvnsite 0m 54s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 1s the patch passed
        +1 javadoc 0m 38s the patch passed
        +1 unit 67m 1s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        95m 11s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:612578f
        JIRA Issue HDFS-11645
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862938/HDFS-11645.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e835d3068b10 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3a91376
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19055/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19055/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 5s trunk passed +1 compile 1m 6s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 58s trunk passed +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 59s the patch passed +1 compile 0m 57s the patch passed +1 javac 0m 57s the patch passed +1 checkstyle 0m 37s the patch passed +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 1s the patch passed +1 javadoc 0m 38s the patch passed +1 unit 67m 1s hadoop-hdfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 95m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:612578f JIRA Issue HDFS-11645 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862938/HDFS-11645.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e835d3068b10 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3a91376 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19055/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19055/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hanishakoneru Hanisha Koneru added a comment -

        Thank you Chen Liang. The patch LGTM.

        Show
        hanishakoneru Hanisha Koneru added a comment - Thank you Chen Liang . The patch LGTM.
        Hide
        anu Anu Engineer added a comment -

        Hanisha Koneru Thanks for the review. +1 from me too. I will commit this shortly.

        Show
        anu Anu Engineer added a comment - Hanisha Koneru Thanks for the review. +1 from me too. I will commit this shortly.
        Hide
        anu Anu Engineer added a comment -

        Chen Liang Thanks for the contribution. I have committed this to trunk.

        Show
        anu Anu Engineer added a comment - Chen Liang Thanks for the contribution. I have committed this to trunk.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11579 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11579/)
        HDFS-11645. DataXceiver thread should log the actual error when getting (aengineer: rev abce61335678da753cd0f7965a236370274abee8)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11579 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11579/ ) HDFS-11645 . DataXceiver thread should log the actual error when getting (aengineer: rev abce61335678da753cd0f7965a236370274abee8) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/)
        HDFS-11645. DataXceiver thread should log the actual error when getting (aengineer: rev abce61335678da753cd0f7965a236370274abee8)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/ ) HDFS-11645 . DataXceiver thread should log the actual error when getting (aengineer: rev abce61335678da753cd0f7965a236370274abee8) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java

          People

          • Assignee:
            vagarychen Chen Liang
            Reporter:
            vagarychen Chen Liang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development