Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1160

Improve some FSDataset warnings and comments

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0, 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: datanode
    • Labels:
      None

      Description

      The warning in FSDataset that prints "removing block" is more clear as "Removing replica info for block" since the DN is not actually removing the block. The attached patch also cleans up and fixes typos in some related comments and code.

      1. hdfs-1160.txt
        9 kB
        Todd Lipcon
      2. hdfs-1160-3.patch
        9 kB
        Eli Collins
      3. hdfs-1160-2.patch
        7 kB
        Eli Collins
      4. hdfs-1160-1.patch
        7 kB
        Eli Collins

        Issue Links

          Activity

          Eli Collins created issue -
          Eli Collins made changes -
          Field Original Value New Value
          Attachment hdfs-1160-1.patch [ 12444761 ]
          Hide
          Eli Collins added a comment -

          Let me know if I should squash this diff in with HDFS-1161 or HDFS-811 to make life easier for reviewers. I filed separately since I've heard people prefer cleanup occurs in separate jiras.

          Show
          Eli Collins added a comment - Let me know if I should squash this diff in with HDFS-1161 or HDFS-811 to make life easier for reviewers. I filed separately since I've heard people prefer cleanup occurs in separate jiras.
          Eli Collins made changes -
          Fix Version/s 0.21.0 [ 12314046 ]
          Affects Version/s 0.21.0 [ 12314046 ]
          Hide
          Eli Collins added a comment -

          Updated patch, minor bug fix.

          Show
          Eli Collins added a comment - Updated patch, minor bug fix.
          Eli Collins made changes -
          Attachment hdfs-1160-2.patch [ 12444831 ]
          Hide
          Eli Collins added a comment -

          Patch attached, consolidates cleanup from HDFS-1161 with the current patch:

          • Fixed some typos in logs eg "chek"
          • Renamed variables like dp_error to dpError, ones like "fsvs" to more readable ones
          • Adds warning in the case there's an exception reporting a disk error, currently ignored.
          • Adds some missing javadocs
          • Rewrote some loops that used indices to use the new for syntax, easier to follow
          Show
          Eli Collins added a comment - Patch attached, consolidates cleanup from HDFS-1161 with the current patch: Fixed some typos in logs eg "chek" Renamed variables like dp_error to dpError, ones like "fsvs" to more readable ones Adds warning in the case there's an exception reporting a disk error, currently ignored. Adds some missing javadocs Rewrote some loops that used indices to use the new for syntax, easier to follow
          Eli Collins made changes -
          Attachment hdfs-1160-3.patch [ 12445607 ]
          Eli Collins made changes -
          Link This issue is blocked by HDFS-1161 [ HDFS-1161 ]
          Tom White made changes -
          Fix Version/s 0.21.0 [ 12314046 ]
          Hide
          Todd Lipcon added a comment -

          +1, looks good to me. Updated to trunk while reviewing.

          Show
          Todd Lipcon added a comment - +1, looks good to me. Updated to trunk while reviewing.
          Todd Lipcon made changes -
          Attachment hdfs-1160.txt [ 12459472 ]
          Hide
          Eli Collins added a comment -

          Thanks for taking a look Todd.

          I've committed this. I didn't run test-patch since the change just updates some warnings and comments.

          Show
          Eli Collins added a comment - Thanks for taking a look Todd. I've committed this. I didn't run test-patch since the change just updates some warnings and comments.
          Eli Collins made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development