Details

      Description

      In the httpfs index.md, there is a sentence

      curl http://httpfs-host:14000/webhdfs/v1/user/foo?op=list` returns the contents of ...

      which is wrong, the right operation is LISTSTATUS, not LIST.

      1. HDFS-11561.001.patch
        1 kB
        Yuanbo Liu
      2. HDFS-11561.002.patch
        6 kB
        Yuanbo Liu
      3. HDFS-11561.003.patch
        3 kB
        Yuanbo Liu

        Activity

        Hide
        jzhuge John Zhuge added a comment -

        Yuanbo Liu Thanks for the finding and the patch.

        Could you please verify all 4 curl commands in the doc?

        Show
        jzhuge John Zhuge added a comment - Yuanbo Liu Thanks for the finding and the patch. Could you please verify all 4 curl commands in the doc?
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvninstall 12m 54s trunk passed
        +1 mvnsite 0m 46s trunk passed
        +1 mvnsite 0m 43s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        15m 12s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11561
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12859851/HDFS-11561.001.patch
        Optional Tests asflicense mvnsite
        uname Linux 5aac3cfbd82b 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f462e1f
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18796/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvninstall 12m 54s trunk passed +1 mvnsite 0m 46s trunk passed +1 mvnsite 0m 43s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 15m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11561 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12859851/HDFS-11561.001.patch Optional Tests asflicense mvnsite uname Linux 5aac3cfbd82b 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f462e1f modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18796/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yuanbo Yuanbo Liu added a comment -

        John Zhuge Thanks for your review. Sure, I will test them.

        Show
        yuanbo Yuanbo Liu added a comment - John Zhuge Thanks for your review. Sure, I will test them.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Upload v2 patch with some test cases to cover the commands in the index.md. Also test the commands in my local env, they're all passed.

        Show
        yuanbo Yuanbo Liu added a comment - Upload v2 patch with some test cases to cover the commands in the index.md. Also test the commands in my local env, they're all passed.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 12m 43s trunk passed
        +1 compile 0m 16s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 47s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 24s trunk passed
        +1 javadoc 0m 14s trunk passed
        +1 mvninstall 0m 26s the patch passed
        +1 compile 0m 14s the patch passed
        +1 javac 0m 14s the patch passed
        +1 checkstyle 0m 11s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 0 new + 52 unchanged - 2 fixed = 52 total (was 54)
        +1 mvnsite 0m 44s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 29s the patch passed
        +1 javadoc 0m 11s the patch passed
        +1 unit 3m 5s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        22m 3s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11561
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12859902/HDFS-11561.002.patch
        Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle
        uname Linux f18ee0225c58 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f462e1f
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18797/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18797/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 43s trunk passed +1 compile 0m 16s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 47s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 24s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 26s the patch passed +1 compile 0m 14s the patch passed +1 javac 0m 14s the patch passed +1 checkstyle 0m 11s hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 0 new + 52 unchanged - 2 fixed = 52 total (was 54) +1 mvnsite 0m 44s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 29s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 3m 5s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 22m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11561 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12859902/HDFS-11561.002.patch Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle uname Linux f18ee0225c58 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f462e1f Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18797/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18797/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        Great work in patch 002. Just a few nitpicks.

        index.md

        • /user/foo.bar should be /user/foo/usr in the last curl command
        • Wrap HTTP URL with single quotes in a all curl commands, e.g., curl http://... => curl 'http://...'. Otherwise, bash will interpret the & character.

        TestHttpFSServer.java

        • 218: Please revert if it is just coding style change
        • 222: Please revert if it is just coding style change
        • testHdfsRead: Has testOpenOffsetLength covered this case already?
        Show
        jzhuge John Zhuge added a comment - Great work in patch 002. Just a few nitpicks. index.md /user/foo.bar should be /user/foo/usr in the last curl command Wrap HTTP URL with single quotes in a all curl commands, e.g., curl http:// ... => curl 'http://...' . Otherwise, bash will interpret the & character. TestHttpFSServer.java 218: Please revert if it is just coding style change 222: Please revert if it is just coding style change testHdfsRead: Has testOpenOffsetLength covered this case already?
        Hide
        yuanbo Yuanbo Liu added a comment -

        John Zhuge thanks for your review.
        Attach v3 patch to address your comments.

        Show
        yuanbo Yuanbo Liu added a comment - John Zhuge thanks for your review. Attach v3 patch to address your comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 12m 57s trunk passed
        +1 compile 0m 16s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 47s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 23s trunk passed
        +1 javadoc 0m 14s trunk passed
        +1 mvninstall 0m 26s the patch passed
        +1 compile 0m 14s the patch passed
        +1 javac 0m 14s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 43s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 28s the patch passed
        +1 javadoc 0m 11s the patch passed
        +1 unit 3m 4s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        22m 14s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11561
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860070/HDFS-11561.003.patch
        Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle
        uname Linux 0a5bc8acbe0a 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f462e1f
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18808/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18808/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 57s trunk passed +1 compile 0m 16s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 47s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 23s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 26s the patch passed +1 compile 0m 14s the patch passed +1 javac 0m 14s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 43s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 28s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 3m 4s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 22m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11561 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860070/HDFS-11561.003.patch Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle uname Linux 0a5bc8acbe0a 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f462e1f Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18808/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18808/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        +1 LGTM

        Show
        jzhuge John Zhuge added a comment - +1 LGTM
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11442 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11442/)
        HDFS-11561. HttpFS doc errors. Contributed by Yuanbo Liu. (jzhuge: rev ed2d03f2a5318a88d0eced8476127f303eb1d1d9)

        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServer.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/site/markdown/index.md
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11442 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11442/ ) HDFS-11561 . HttpFS doc errors. Contributed by Yuanbo Liu. (jzhuge: rev ed2d03f2a5318a88d0eced8476127f303eb1d1d9) (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServer.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/site/markdown/index.md
        Hide
        jzhuge John Zhuge added a comment -

        Committed to trunk, branch-2, and branch-2.8.

        Thanks Yuanbo Liu for the contribution!

        Show
        jzhuge John Zhuge added a comment - Committed to trunk, branch-2, and branch-2.8. Thanks Yuanbo Liu for the contribution!
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          People

          • Assignee:
            yuanbo Yuanbo Liu
            Reporter:
            yuanbo Yuanbo Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development