Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1153

dfsnodelist.jsp should handle invalid input parameters

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 2.0.2-alpha
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Navigation to dfsnodelist.jsp with invalid input parameters produces NPE and HTTP 500 error.

      1. HDFS-1153.patch
        1 kB
        Ravi Phulari
      2. hdfs-1153.txt
        1 kB
        Eli Collins

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12444458/HDFS-1153.patch
        against trunk revision 944015.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/177/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444458/HDFS-1153.patch against trunk revision 944015. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/177/console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        The change looks good to me. The patch doesn't apply to the head of branch-20 so you may need to merge.

        Show
        Eli Collins added a comment - The change looks good to me. The patch doesn't apply to the head of branch-20 so you may need to merge.
        Hide
        Ravi Phulari added a comment -

        Forgot to mention that this patch is for Y20s branch.

        Show
        Ravi Phulari added a comment - Forgot to mention that this patch is for Y20s branch.
        Hide
        Jakob Homan added a comment -

        +1

        Show
        Jakob Homan added a comment - +1
        Hide
        Jakob Homan added a comment -

        Canceling patch. Ravi, can you please provide a trunk version?

        Show
        Jakob Homan added a comment - Canceling patch. Ravi, can you please provide a trunk version?
        Hide
        Eli Collins added a comment -

        Trunk patch attached.

        Show
        Eli Collins added a comment - Trunk patch attached.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12527682/hdfs-1153.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2448//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2448//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527682/hdfs-1153.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2448//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2448//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        +1

        Show
        Todd Lipcon added a comment - +1
        Hide
        Eli Collins added a comment -

        I've committed this and merged to branch-2. Thanks Ravi!

        Show
        Eli Collins added a comment - I've committed this and merged to branch-2. Thanks Ravi!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2335 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2335/)
        HDFS-1153. dfsnodelist.jsp should handle invalid input parameters. Contributed by Ravi Phulari (Revision 1339706)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339706
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2335 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2335/ ) HDFS-1153 . dfsnodelist.jsp should handle invalid input parameters. Contributed by Ravi Phulari (Revision 1339706) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339706 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2261 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2261/)
        HDFS-1153. dfsnodelist.jsp should handle invalid input parameters. Contributed by Ravi Phulari (Revision 1339706)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339706
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2261 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2261/ ) HDFS-1153 . dfsnodelist.jsp should handle invalid input parameters. Contributed by Ravi Phulari (Revision 1339706) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339706 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2278 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2278/)
        HDFS-1153. dfsnodelist.jsp should handle invalid input parameters. Contributed by Ravi Phulari (Revision 1339706)

        Result = ABORTED
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339706
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2278 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2278/ ) HDFS-1153 . dfsnodelist.jsp should handle invalid input parameters. Contributed by Ravi Phulari (Revision 1339706) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339706 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1049 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1049/)
        HDFS-1153. dfsnodelist.jsp should handle invalid input parameters. Contributed by Ravi Phulari (Revision 1339706)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339706
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1049 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1049/ ) HDFS-1153 . dfsnodelist.jsp should handle invalid input parameters. Contributed by Ravi Phulari (Revision 1339706) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339706 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1083 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1083/)
        HDFS-1153. dfsnodelist.jsp should handle invalid input parameters. Contributed by Ravi Phulari (Revision 1339706)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339706
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1083 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1083/ ) HDFS-1153 . dfsnodelist.jsp should handle invalid input parameters. Contributed by Ravi Phulari (Revision 1339706) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339706 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java

          People

          • Assignee:
            Ravi Phulari
            Reporter:
            Ravi Phulari
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development