Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11502

Datanode UI should display hostname based on JMX bean instead of window.location.hostname

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.2, 2.7.3
    • Fix Version/s: 2.9.0, 3.0.0-beta1, 2.8.2
    • Component/s: hdfs
    • Labels:
      None
    • Environment:

      all

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Datanode UI calls "dn.js" which loads properties for datanode. "dn.js" sets "data.dn.HostName" datanode UI to "window.location.hostname", it should use a datanode property from jmx beans or an appropriate property. The issue is
      that if we use a proxy to access datanode UI we would show proxy hostanme instead of actual datanode hostname.
      I am proposing using Hadoop:service=DataNode,name=JvmMetrics" tag.Hostname field to do that.

      1. HDFS-11502.001.patch
        1 kB
        Jeffrey E Rodriguez
      2. HDFS-11502.002.patch
        1 kB
        Jeffrey E Rodriguez
      3. HDFS-11502.003.patch
        5 kB
        Jeffrey E Rodriguez
      4. HDFS-11502.004.patch
        3 kB
        Yuanbo Liu

        Activity

        Hide
        jeffreyr97 Jeffrey E Rodriguez added a comment -

        Can somebody assign this to me please?

        Show
        jeffreyr97 Jeffrey E Rodriguez added a comment - Can somebody assign this to me please?
        Hide
        yuanbo Yuanbo Liu added a comment -

        Jeffrey E Rodriguez If you want to work on it, please send a email to hadoop-dev and apply for "assign to myself" permission.
        Currently we don't have the privilege to assign JIRAs.

        Show
        yuanbo Yuanbo Liu added a comment - Jeffrey E Rodriguez If you want to work on it, please send a email to hadoop-dev and apply for "assign to myself" permission. Currently we don't have the privilege to assign JIRAs.
        Hide
        jeffreyr97 Jeffrey E Rodriguez added a comment -

        Thanks I would do so

        Show
        jeffreyr97 Jeffrey E Rodriguez added a comment - Thanks I would do so
        Hide
        jeffreyr97 Jeffrey E Rodriguez added a comment -

        Patch fixes Datanode html UI so we use datahostname tag.Hostname from JvmMetrics jmx instead of relying on window.location.hostname. window.location.hostname which in a case where we proxy datanode UI would return host of proxy instead.
        Since we want the real hostname of datanode it may be preferable to use actual datanode jmx data.

        Show
        jeffreyr97 Jeffrey E Rodriguez added a comment - Patch fixes Datanode html UI so we use datahostname tag.Hostname from JvmMetrics jmx instead of relying on window.location.hostname. window.location.hostname which in a case where we proxy datanode UI would return host of proxy instead. Since we want the real hostname of datanode it may be preferable to use actual datanode jmx data.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        0m 50s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11502
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856430/HDFS-11502.001.patch
        Optional Tests asflicense
        uname Linux d535ef6d5eb9 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1441398
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/18610/artifact/patchprocess/whitespace-eol.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18610/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 asflicense 0m 19s The patch does not generate ASF License warnings. 0m 50s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11502 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856430/HDFS-11502.001.patch Optional Tests asflicense uname Linux d535ef6d5eb9 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1441398 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/18610/artifact/patchprocess/whitespace-eol.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18610/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jeffreyr97 Jeffrey E Rodriguez added a comment -

        fixed new patch newline

        Show
        jeffreyr97 Jeffrey E Rodriguez added a comment - fixed new patch newline
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        0m 50s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11502
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856675/HDFS-11502.002.patch
        Optional Tests asflicense
        uname Linux a13d07f81d12 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e0c239c
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18622/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 0m 50s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11502 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856675/HDFS-11502.002.patch Optional Tests asflicense uname Linux a13d07f81d12 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e0c239c modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18622/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jeffreyr97 Jeffrey E Rodriguez added a comment -

        Only concern we may have :
        Hostname in JVMMetrics uses InetAddress.getLocalHost().getHostName() which may resolve in some cases to localhost or 127.0.0.0.
        At this point I don't know of a better datanode jmx beab property or method that would reflect the real datanode hostname (FQDN) so we can differentiate datanodes if there are going through a proxy. (the previous way would showed the proxy hostname instead because window.location.hostname). In addition JS window.location may not be a portable way to provide that information either.

        So to community, would like to ask if there is a reliable way available to datanode JMX beans to show FQDN or hostname of datanode.

        Show
        jeffreyr97 Jeffrey E Rodriguez added a comment - Only concern we may have : Hostname in JVMMetrics uses InetAddress.getLocalHost().getHostName() which may resolve in some cases to localhost or 127.0.0.0. At this point I don't know of a better datanode jmx beab property or method that would reflect the real datanode hostname (FQDN) so we can differentiate datanodes if there are going through a proxy. (the previous way would showed the proxy hostname instead because window.location.hostname). In addition JS window.location may not be a portable way to provide that information either. So to community, would like to ask if there is a reliable way available to datanode JMX beans to show FQDN or hostname of datanode.
        Hide
        jeffreyr97 Jeffrey E Rodriguez added a comment -

        The following is a rework of the fix.

        Added getDataNodeHostname to the datanode bean.
        Added to the datanode bean.
        changed dn.js to use DataNodeHostname.

        Show
        jeffreyr97 Jeffrey E Rodriguez added a comment - The following is a rework of the fix. Added getDataNodeHostname to the datanode bean. Added to the datanode bean. changed dn.js to use DataNodeHostname.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        -1 mvninstall 13m 46s root in trunk failed.
        +1 compile 0m 48s trunk passed
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 55s trunk passed
        +1 javadoc 0m 42s trunk passed
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 46s the patch passed
        +1 javac 0m 46s the patch passed
        -0 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 175 unchanged - 0 fixed = 184 total (was 175)
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 54s the patch passed
        +1 javadoc 0m 38s the patch passed
        -1 unit 69m 3s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        95m 38s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.ha.TestHASafeMode
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11502
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12859133/HDFS-11502.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a70707a89f63 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ba62b50
        Default Java 1.8.0_121
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/18740/artifact/patchprocess/branch-mvninstall-root.txt
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18740/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18740/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18740/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18740/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. -1 mvninstall 13m 46s root in trunk failed. +1 compile 0m 48s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 55s trunk passed +1 javadoc 0m 42s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 0m 46s the patch passed +1 javac 0m 46s the patch passed -0 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 175 unchanged - 0 fixed = 184 total (was 175) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 38s the patch passed -1 unit 69m 3s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 95m 38s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11502 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12859133/HDFS-11502.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a70707a89f63 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ba62b50 Default Java 1.8.0_121 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/18740/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18740/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/18740/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18740/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18740/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jeffreyr97 Jeffrey E Rodriguez added a comment -

        checking the TestHASafeMode failure

        Show
        jeffreyr97 Jeffrey E Rodriguez added a comment - checking the TestHASafeMode failure
        Hide
        yuanbo Yuanbo Liu added a comment -

        Vinayakumar B Sorry to interrupt. Would you mind taking a look at this JIRA and seeing if it makes sense to you. Thanks in advance.

        Show
        yuanbo Yuanbo Liu added a comment - Vinayakumar B Sorry to interrupt. Would you mind taking a look at this JIRA and seeing if it makes sense to you. Thanks in advance.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Attach v4 patch for this JIRA. Fixed some minor issues.

        Show
        yuanbo Yuanbo Liu added a comment - Attach v4 patch for this JIRA. Fixed some minor issues.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 13m 29s trunk passed
        +1 compile 0m 52s trunk passed
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 0m 52s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 44s trunk passed
        +1 javadoc 0m 39s trunk passed
        +1 mvninstall 0m 47s the patch passed
        +1 compile 0m 44s the patch passed
        +1 javac 0m 44s the patch passed
        -0 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 175 unchanged - 0 fixed = 177 total (was 175)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 49s the patch passed
        +1 javadoc 0m 39s the patch passed
        -1 unit 67m 3s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        92m 54s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11502
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862427/HDFS-11502.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d538286b1f7b 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e7167e4
        Default Java 1.8.0_121
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19006/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19006/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19006/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19006/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 29s trunk passed +1 compile 0m 52s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 0m 39s trunk passed +1 mvninstall 0m 47s the patch passed +1 compile 0m 44s the patch passed +1 javac 0m 44s the patch passed -0 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 175 unchanged - 0 fixed = 177 total (was 175) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 67m 3s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 92m 54s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11502 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862427/HDFS-11502.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d538286b1f7b 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e7167e4 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19006/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19006/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19006/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19006/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 16m 38s trunk passed
        +1 compile 1m 7s trunk passed
        +1 checkstyle 0m 43s trunk passed
        +1 mvnsite 1m 8s trunk passed
        -1 findbugs 2m 15s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 0m 50s trunk passed
        +1 mvninstall 1m 9s the patch passed
        +1 compile 1m 5s the patch passed
        +1 javac 1m 5s the patch passed
        -0 checkstyle 0m 42s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 173 unchanged - 0 fixed = 175 total (was 173)
        +1 mvnsite 1m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 34s the patch passed
        +1 javadoc 0m 49s the patch passed
        -1 unit 94m 29s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 29s The patch does not generate ASF License warnings.
        127m 10s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.TestPread
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.web.TestWebHdfsTimeouts
          hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11502
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862427/HDFS-11502.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2f73a42a8eb9 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / af2773f
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20113/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20113/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20113/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20113/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20113/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 16m 38s trunk passed +1 compile 1m 7s trunk passed +1 checkstyle 0m 43s trunk passed +1 mvnsite 1m 8s trunk passed -1 findbugs 2m 15s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 0m 50s trunk passed +1 mvninstall 1m 9s the patch passed +1 compile 1m 5s the patch passed +1 javac 1m 5s the patch passed -0 checkstyle 0m 42s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 173 unchanged - 0 fixed = 175 total (was 173) +1 mvnsite 1m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 34s the patch passed +1 javadoc 0m 49s the patch passed -1 unit 94m 29s hadoop-hdfs in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 127m 10s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.TestPread   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11502 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862427/HDFS-11502.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2f73a42a8eb9 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / af2773f Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20113/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20113/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20113/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20113/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20113/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Jeffrey E Rodriguez and Yuanbo Liu for working on the. The patch looks good to me. +1

        Show
        xyao Xiaoyu Yao added a comment - Thanks Jeffrey E Rodriguez and Yuanbo Liu for working on the. The patch looks good to me. +1
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Jeffrey E Rodriguez and Yuanbo Liu for the contribution and all for the reviews. I've commit the latest patch to trunk, branch-2, branch-2.8, branch-2.8.2.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Jeffrey E Rodriguez and Yuanbo Liu for the contribution and all for the reviews. I've commit the latest patch to trunk, branch-2, branch-2.8, branch-2.8.2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11997 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11997/)
        HDFS-11502. Datanode UI should display hostname based on JMX bean (xyao: rev e15e2713e1e344b14d63726639d1c83451921515)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/dn.js
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11997 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11997/ ) HDFS-11502 . Datanode UI should display hostname based on JMX bean (xyao: rev e15e2713e1e344b14d63726639d1c83451921515) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/dn.js (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Hide
        yuanbo Yuanbo Liu added a comment -

        Xiaoyu Yao
        Thanks for taking care of this JIRA.

        Show
        yuanbo Yuanbo Liu added a comment - Xiaoyu Yao Thanks for taking care of this JIRA.

          People

          • Assignee:
            jeffreyr97 Jeffrey E Rodriguez
            Reporter:
            jeffreyr97 Jeffrey E Rodriguez
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development