Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11477

Simplify file IO profiling configuration

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      For Profiling FileIO events, there are 2 keys:

      • DFS_DATANODE_ENABLE_FILEIO_PROFILING_KEY for enabling the hooks
      • DFS_DATANODE_FILEIO_PROFILING_SAMPLING_FRACTION_KEY for setting the sampling fraction

      We can instead have only the sampling fraction key and set it to 0 if we want to disable profiling.

      1. HDFS-11477.000.patch
        7 kB
        Hanisha Koneru
      2. HDFS-11477.001.patch
        7 kB
        Hanisha Koneru
      3. HDFS-11477.002.patch
        8 kB
        Hanisha Koneru
      4. HDFS-11477.003.patch
        10 kB
        Hanisha Koneru
      5. HDFS-11477-branch-2.000.patch
        12 kB
        Hanisha Koneru

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 1m 56s Maven dependency ordering for branch
        +1 mvninstall 13m 12s trunk passed
        +1 compile 13m 48s trunk passed
        +1 checkstyle 1m 52s trunk passed
        +1 mvnsite 1m 59s trunk passed
        +1 mvneclipse 0m 37s trunk passed
        +1 findbugs 3m 18s trunk passed
        +1 javadoc 1m 32s trunk passed
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 1m 23s the patch passed
        +1 compile 11m 23s the patch passed
        +1 javac 11m 23s the patch passed
        +1 checkstyle 1m 53s the patch passed
        +1 mvnsite 2m 1s the patch passed
        +1 mvneclipse 0m 37s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 30s the patch passed
        +1 javadoc 1m 32s the patch passed
        +1 unit 8m 17s hadoop-common in the patch passed.
        -1 unit 63m 11s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 36s The patch does not generate ASF License warnings.
        134m 15s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestSafeMode



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11477
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855273/HDFS-11477.000.patch
        Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle
        uname Linux 57cf749b39a8 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 989bd56
        Default Java 1.8.0_121
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18480/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18480/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18480/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 56s Maven dependency ordering for branch +1 mvninstall 13m 12s trunk passed +1 compile 13m 48s trunk passed +1 checkstyle 1m 52s trunk passed +1 mvnsite 1m 59s trunk passed +1 mvneclipse 0m 37s trunk passed +1 findbugs 3m 18s trunk passed +1 javadoc 1m 32s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 23s the patch passed +1 compile 11m 23s the patch passed +1 javac 11m 23s the patch passed +1 checkstyle 1m 53s the patch passed +1 mvnsite 2m 1s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 30s the patch passed +1 javadoc 1m 32s the patch passed +1 unit 8m 17s hadoop-common in the patch passed. -1 unit 63m 11s hadoop-hdfs in the patch failed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 134m 15s Reason Tests Failed junit tests hadoop.hdfs.TestSafeMode Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11477 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855273/HDFS-11477.000.patch Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle uname Linux 57cf749b39a8 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 989bd56 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18480/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18480/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18480/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks for the improvement Hanisha Koneru. Couple of comments:

        1. The fileIOSamplingFraction == 0 check may not work. Instead you can check abs(fileIOSamplingFraction) < 0.000001. If so, set isEnabled to false.
        2. Also we can add a check for negative numbers. i.e. if fileIOSamplingFraction < -0.000001, log a warning and set isEnabled to false.
        3. The documentation in Metrics.md can state this should be a fraction between 0.0 and 1.0, with 0.0 meaning profiling is not enabled.
        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks for the improvement Hanisha Koneru . Couple of comments: The fileIOSamplingFraction == 0 check may not work. Instead you can check abs(fileIOSamplingFraction) < 0.000001 . If so, set isEnabled to false. Also we can add a check for negative numbers. i.e. if fileIOSamplingFraction < -0.000001 , log a warning and set isEnabled to false. The documentation in Metrics.md can state this should be a fraction between 0.0 and 1.0, with 0.0 meaning profiling is not enabled.
        Hide
        hanishakoneru Hanisha Koneru added a comment -

        Thank you Arpit Agarwal for reviewing the patch. I have addressed your comments in patch v01.

        Show
        hanishakoneru Hanisha Koneru added a comment - Thank you Arpit Agarwal for reviewing the patch. I have addressed your comments in patch v01.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 43s Maven dependency ordering for branch
        +1 mvninstall 13m 42s trunk passed
        +1 compile 13m 44s trunk passed
        +1 checkstyle 2m 6s trunk passed
        +1 mvnsite 2m 1s trunk passed
        +1 mvneclipse 0m 36s trunk passed
        +1 findbugs 3m 20s trunk passed
        +1 javadoc 1m 40s trunk passed
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 1m 46s the patch passed
        +1 compile 11m 49s the patch passed
        +1 javac 11m 49s the patch passed
        +1 checkstyle 2m 1s the patch passed
        +1 mvnsite 2m 14s the patch passed
        +1 mvneclipse 0m 38s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 52s the patch passed
        +1 javadoc 1m 45s the patch passed
        +1 unit 8m 33s hadoop-common in the patch passed.
        -1 unit 76m 3s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 35s The patch does not generate ASF License warnings.
        148m 55s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11477
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855510/HDFS-11477.001.patch
        Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle
        uname Linux 8666f92f4e1b 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6f6dfe0
        Default Java 1.8.0_121
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18505/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18505/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 43s Maven dependency ordering for branch +1 mvninstall 13m 42s trunk passed +1 compile 13m 44s trunk passed +1 checkstyle 2m 6s trunk passed +1 mvnsite 2m 1s trunk passed +1 mvneclipse 0m 36s trunk passed +1 findbugs 3m 20s trunk passed +1 javadoc 1m 40s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 46s the patch passed +1 compile 11m 49s the patch passed +1 javac 11m 49s the patch passed +1 checkstyle 2m 1s the patch passed +1 mvnsite 2m 14s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 52s the patch passed +1 javadoc 1m 45s the patch passed +1 unit 8m 33s hadoop-common in the patch passed. -1 unit 76m 3s hadoop-hdfs in the patch failed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 148m 55s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11477 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855510/HDFS-11477.001.patch Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle uname Linux 8666f92f4e1b 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6f6dfe0 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18505/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18505/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hanishakoneru Hanisha Koneru added a comment -

        Added Log statements in patch v02.

        Show
        hanishakoneru Hanisha Koneru added a comment - Added Log statements in patch v02.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 29s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 20s Maven dependency ordering for branch
        +1 mvninstall 16m 16s trunk passed
        -1 compile 12m 3s root in trunk failed.
        +1 checkstyle 1m 58s trunk passed
        +1 mvnsite 1m 58s trunk passed
        +1 mvneclipse 0m 37s trunk passed
        +1 findbugs 3m 14s trunk passed
        +1 javadoc 1m 34s trunk passed
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 1m 24s the patch passed
        -1 compile 7m 35s root in the patch failed.
        -1 javac 7m 35s root in the patch failed.
        +1 checkstyle 2m 0s the patch passed
        +1 mvnsite 2m 17s the patch passed
        +1 mvneclipse 0m 38s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 2s the patch passed
        +1 javadoc 1m 34s the patch passed
        +1 unit 9m 0s hadoop-common in the patch passed.
        -1 unit 105m 8s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 41s The patch does not generate ASF License warnings.
        174m 19s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11477
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855690/HDFS-11477.002.patch
        Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle
        uname Linux b04890b55716 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 747bafa
        Default Java 1.8.0_121
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/18520/artifact/patchprocess/branch-compile-root.txt
        findbugs v3.0.0
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/18520/artifact/patchprocess/patch-compile-root.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/18520/artifact/patchprocess/patch-compile-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18520/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18520/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18520/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 20s Maven dependency ordering for branch +1 mvninstall 16m 16s trunk passed -1 compile 12m 3s root in trunk failed. +1 checkstyle 1m 58s trunk passed +1 mvnsite 1m 58s trunk passed +1 mvneclipse 0m 37s trunk passed +1 findbugs 3m 14s trunk passed +1 javadoc 1m 34s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 24s the patch passed -1 compile 7m 35s root in the patch failed. -1 javac 7m 35s root in the patch failed. +1 checkstyle 2m 0s the patch passed +1 mvnsite 2m 17s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 2s the patch passed +1 javadoc 1m 34s the patch passed +1 unit 9m 0s hadoop-common in the patch passed. -1 unit 105m 8s hadoop-hdfs in the patch failed. +1 asflicense 0m 41s The patch does not generate ASF License warnings. 174m 19s Reason Tests Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11477 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855690/HDFS-11477.002.patch Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle uname Linux b04890b55716 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 747bafa Default Java 1.8.0_121 compile https://builds.apache.org/job/PreCommit-HDFS-Build/18520/artifact/patchprocess/branch-compile-root.txt findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-HDFS-Build/18520/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/18520/artifact/patchprocess/patch-compile-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/18520/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18520/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18520/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment - - edited

        Thanks Hanisha Koneru. +1.

        Show
        arpitagarwal Arpit Agarwal added a comment - - edited Thanks Hanisha Koneru . +1.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Committed to trunk and branch-2. Thanks Hanisha Koneru.

        Show
        arpitagarwal Arpit Agarwal added a comment - Committed to trunk and branch-2. Thanks Hanisha Koneru .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11334 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11334/)
        HDFS-11477. Simplify file IO profiling configuration. Contributed by (arp: rev e61491d4769536ce8b77b416005ce531278ce729)

        • (edit) hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeMetrics.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ProfilingFileIoEvents.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FileIoProvider.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11334 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11334/ ) HDFS-11477 . Simplify file IO profiling configuration. Contributed by (arp: rev e61491d4769536ce8b77b416005ce531278ce729) (edit) hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeMetrics.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ProfilingFileIoEvents.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FileIoProvider.java
        Hide
        andrew.wang Andrew Wang added a comment -

        Reopening, I think this broke the build. I saw a DNConf error referring to a FILEIO config key, reverted this and it passed afterwards.

        Precommit seems pretty messed up right now unfortunately

        Show
        andrew.wang Andrew Wang added a comment - Reopening, I think this broke the build. I saw a DNConf error referring to a FILEIO config key, reverted this and it passed afterwards. Precommit seems pretty messed up right now unfortunately
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Yeah thanks for reverting this Andrew Wang.

        Show
        arpitagarwal Arpit Agarwal added a comment - Yeah thanks for reverting this Andrew Wang .
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Jenkins rightly flagged the v2 patch compile error but I looked at the wrong Jenkins output I think.

        Still doesn't explain why the v1 patch compilation succeeded.

        Show
        arpitagarwal Arpit Agarwal added a comment - Jenkins rightly flagged the v2 patch compile error but I looked at the wrong Jenkins output I think. Still doesn't explain why the v1 patch compilation succeeded.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11335 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11335/)
        Revert "HDFS-11477. Simplify file IO profiling configuration. (wang: rev 8f4817f2c5524c1891a3b3b50e396dd4ca294a2d)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeMetrics.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        • (edit) hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ProfilingFileIoEvents.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FileIoProvider.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11335 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11335/ ) Revert " HDFS-11477 . Simplify file IO profiling configuration. (wang: rev 8f4817f2c5524c1891a3b3b50e396dd4ca294a2d) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeMetrics.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java (edit) hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ProfilingFileIoEvents.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FileIoProvider.java
        Hide
        hanishakoneru Hanisha Koneru added a comment -

        Thank you Arpit Agarwal and Andrew Wang.
        I have updated the patch to take care of the issue (v03).
        Between the jenkins runs for patch v1 and v2, there was a commit in trunk which used the Config Key removed in this patch.

        Show
        hanishakoneru Hanisha Koneru added a comment - Thank you Arpit Agarwal and Andrew Wang . I have updated the patch to take care of the issue (v03). Between the jenkins runs for patch v1 and v2, there was a commit in trunk which used the Config Key removed in this patch.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks Hanisha Koneru. +1 for the v03 patch, pending Jenkins.

        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks Hanisha Koneru . +1 for the v03 patch, pending Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 13s Maven dependency ordering for branch
        +1 mvninstall 12m 38s trunk passed
        +1 compile 10m 28s trunk passed
        +1 checkstyle 2m 5s trunk passed
        +1 mvnsite 2m 12s trunk passed
        +1 mvneclipse 0m 48s trunk passed
        +1 findbugs 3m 21s trunk passed
        +1 javadoc 1m 45s trunk passed
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 1m 22s the patch passed
        +1 compile 10m 38s the patch passed
        +1 javac 10m 38s the patch passed
        +1 checkstyle 2m 5s the patch passed
        +1 mvnsite 2m 5s the patch passed
        +1 mvneclipse 0m 48s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 44s the patch passed
        +1 javadoc 1m 48s the patch passed
        -1 unit 9m 11s hadoop-common in the patch failed.
        -1 unit 72m 40s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 43s The patch does not generate ASF License warnings.
        140m 32s



        Reason Tests
        Failed junit tests hadoop.security.TestKDiag
          hadoop.hdfs.tools.TestDFSZKFailoverController
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11477
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855960/HDFS-11477.003.patch
        Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle
        uname Linux 4b91f7864c20 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d9dc444
        Default Java 1.8.0_121
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18597/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18597/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18597/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18597/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 12m 38s trunk passed +1 compile 10m 28s trunk passed +1 checkstyle 2m 5s trunk passed +1 mvnsite 2m 12s trunk passed +1 mvneclipse 0m 48s trunk passed +1 findbugs 3m 21s trunk passed +1 javadoc 1m 45s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 10m 38s the patch passed +1 javac 10m 38s the patch passed +1 checkstyle 2m 5s the patch passed +1 mvnsite 2m 5s the patch passed +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 44s the patch passed +1 javadoc 1m 48s the patch passed -1 unit 9m 11s hadoop-common in the patch failed. -1 unit 72m 40s hadoop-hdfs in the patch failed. +1 asflicense 0m 43s The patch does not generate ASF License warnings. 140m 32s Reason Tests Failed junit tests hadoop.security.TestKDiag   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11477 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855960/HDFS-11477.003.patch Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit findbugs checkstyle uname Linux 4b91f7864c20 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d9dc444 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18597/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/18597/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18597/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18597/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        The test failures were unrelated. I've pushed this to trunk. Thanks Hanisha Koneru.

        Show
        arpitagarwal Arpit Agarwal added a comment - The test failures were unrelated. I've pushed this to trunk. Thanks Hanisha Koneru .
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11364 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11364/)
        HDFS-11477. Simplify file IO profiling configuration. Contributed by (arp: rev 959940b0ab563b4e42bace44f1dc9a8babcaa889)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ProfilingFileIoEvents.java
        • (edit) hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeMetrics.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Util.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DNConf.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FileIoProvider.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11364 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11364/ ) HDFS-11477 . Simplify file IO profiling configuration. Contributed by (arp: rev 959940b0ab563b4e42bace44f1dc9a8babcaa889) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ProfilingFileIoEvents.java (edit) hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeMetrics.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Util.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DNConf.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FileIoProvider.java
        Hide
        hanishakoneru Hanisha Koneru added a comment -

        Thank you Arpit Agarwal.

        Show
        hanishakoneru Hanisha Koneru added a comment - Thank you Arpit Agarwal .
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 for the branch-2 patch. I committed it. Thanks Hanisha Koneru.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 for the branch-2 patch. I committed it. Thanks Hanisha Koneru .

          People

          • Assignee:
            hanishakoneru Hanisha Koneru
            Reporter:
            hanishakoneru Hanisha Koneru
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development