Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1145

When NameNode is shutdown it tries to exit safemode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Suppose the NameNode is in safemode. Then we try to shuut it down by invoking NameNode.stop(). The stop() method interrupts all waiting threads, which in turn, causes the SafeMode monitor to exit and thus triggering replicating/deleting of blocks.

      1. NNsafemodeMonitor.txt
        1 kB
        dhruba borthakur
      2. NNsafemodeMonitor.txt
        0.6 kB
        dhruba borthakur

        Activity

        Konstantin Shvachko made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #327 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/327/)
        HDFS-1145. When NameNode is shutdown it does not try to exit
        safemode anymore. (dhruba)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #327 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/327/ ) HDFS-1145 . When NameNode is shutdown it does not try to exit safemode anymore. (dhruba)
        dhruba borthakur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.22.0 [ 12314241 ]
        Resolution Fixed [ 1 ]
        Hide
        dhruba borthakur added a comment -

        I just committed this.

        Show
        dhruba borthakur added a comment - I just committed this.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12444239/NNsafemodeMonitor.txt
        against trunk revision 947204.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/180/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/180/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/180/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/180/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444239/NNsafemodeMonitor.txt against trunk revision 947204. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/180/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/180/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/180/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/180/console This message is automatically generated.
        dhruba borthakur made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        dhruba borthakur added a comment -

        Thanks for the review Konstantin, I will commit this patch.

        Show
        dhruba borthakur added a comment - Thanks for the review Konstantin, I will commit this patch.
        Hide
        Konstantin Shvachko added a comment -

        +1. Looks good.
        Don't see errors in the log message.

        Show
        Konstantin Shvachko added a comment - +1. Looks good. Don't see errors in the log message.
        Hide
        dhruba borthakur added a comment -

        Can somebody pl review this minor patch?

        Show
        dhruba borthakur added a comment - Can somebody pl review this minor patch?
        Hide
        dhruba borthakur added a comment -

        Thanks Ravi, can you pl review the new patch file?

        Show
        dhruba borthakur added a comment - Thanks Ravi, can you pl review the new patch file?
        dhruba borthakur made changes -
        Attachment NNsafemodeMonitor.txt [ 12444239 ]
        Hide
        dhruba borthakur added a comment -

        I had attached an older version of this patch. here is the most updated version.

        Show
        dhruba borthakur added a comment - I had attached an older version of this patch. here is the most updated version.
        Hide
        Ravi Phulari added a comment -

        Good catch Dhruba,

        One minor correction, Could you please correct errors in Log message.

        NameNode isbeing shutdow, quitting SafeModeMonitor thread.

        Show
        Ravi Phulari added a comment - Good catch Dhruba, One minor correction, Could you please correct errors in Log message. NameNode isbeing shutdow, quitting SafeModeMonitor thread.
        dhruba borthakur made changes -
        Assignee dhruba borthakur [ dhruba ]
        dhruba borthakur made changes -
        Field Original Value New Value
        Attachment NNsafemodeMonitor.txt [ 12444236 ]
        Hide
        dhruba borthakur added a comment -

        When the SafeModeMonitor thread exists, it rechecks to see if fsRunning is false. if fsRunning is false, then do not leave safemode, just exit.

        Show
        dhruba borthakur added a comment - When the SafeModeMonitor thread exists, it rechecks to see if fsRunning is false. if fsRunning is false, then do not leave safemode, just exit.
        dhruba borthakur created issue -

          People

          • Assignee:
            dhruba borthakur
            Reporter:
            dhruba borthakur
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development