Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11438

Fix typo in error message of StoragePolicyAdmin tool

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      change "unsetd" to "unset"

      @Override
      public int run(Configuration conf, List<String> args) throws IOException {
      final String path = StringUtils.popOptionWithArgument("-path", args);
      if (path == null)

      { System.err.println("Please specify the path from which " + "the storage policy will be unsetd.\nUsage: " + getLongUsage()); return 1; }

        Activity

        Hide
        alisonyu Alison Yu added a comment -

        Patch attached, please review. Thanks Andrew Wang@

        Show
        alisonyu Alison Yu added a comment - Patch attached, please review. Thanks Andrew Wang @
        Hide
        liuml07 Mingliang Liu added a comment -

        Submitting patch.

        Changed the subject to be more descriptive. Patch is simple and clear; looks good to me. As you ping Andrew, I'll let him commit. Thanks,

        Show
        liuml07 Mingliang Liu added a comment - Submitting patch. Changed the subject to be more descriptive. Patch is simple and clear; looks good to me. As you ping Andrew, I'll let him commit. Thanks,
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for filing and fixing this Alison, LGTM too, +1 pending Jenkins, and thanks Mingliang for cleaning up the summary!

        Show
        andrew.wang Andrew Wang added a comment - Thanks for filing and fixing this Alison, LGTM too, +1 pending Jenkins, and thanks Mingliang for cleaning up the summary!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 49s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 13m 54s trunk passed
        +1 compile 0m 50s trunk passed
        +1 checkstyle 0m 35s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 47s trunk passed
        +1 javadoc 0m 41s trunk passed
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 47s the patch passed
        +1 javac 0m 47s the patch passed
        +1 checkstyle 0m 55s the patch passed
        +1 mvnsite 2m 4s the patch passed
        +1 mvneclipse 0m 35s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 53s the patch passed
        +1 javadoc 1m 23s the patch passed
        -1 unit 71m 20s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        105m 24s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11438
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12853846/HDFS-11438.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 39e77f62381a 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 003ae00
        Default Java 1.8.0_121
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18414/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18414/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18414/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 49s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 54s trunk passed +1 compile 0m 50s trunk passed +1 checkstyle 0m 35s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 47s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 0m 47s the patch passed +1 javac 0m 47s the patch passed +1 checkstyle 0m 55s the patch passed +1 mvnsite 2m 4s the patch passed +1 mvneclipse 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 53s the patch passed +1 javadoc 1m 23s the patch passed -1 unit 71m 20s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 105m 24s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11438 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12853846/HDFS-11438.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 39e77f62381a 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 003ae00 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18414/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18414/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18414/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Committed to trunk and branch-2, thanks Alison for the contribution and Mingliang for also reviewing!

        Show
        andrew.wang Andrew Wang added a comment - Committed to trunk and branch-2, thanks Alison for the contribution and Mingliang for also reviewing!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11290 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11290/)
        HDFS-11438. Fix typo in error message of StoragePolicyAdmin tool. (wang: rev d150f061f4ebde923fda28ea898a9606b8789758)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/StoragePolicyAdmin.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11290 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11290/ ) HDFS-11438 . Fix typo in error message of StoragePolicyAdmin tool. (wang: rev d150f061f4ebde923fda28ea898a9606b8789758) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/StoragePolicyAdmin.java

          People

          • Assignee:
            alisonyu Alison Yu
            Reporter:
            alisonyu Alison Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development