[HDFS-11410] Use the cached instance when edit logging SetAclOp, SetXAttrOp and RemoveXAttrOp

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.9.0, 3.0.0-alpha4
• Component/s: namenode
• Target Version/s: 2.9.0
• Hadoop Flags: Reviewed
• Assignee: Xiao Chen
• Reporter: Xiao Chen
• Created: 14/Feb/17 01:16
• Updated: 17/Feb/17 02:36
• Resolved: 17/Feb/17 02:09

Description

andrew.wang recently had a comment on HDFS-10899:

Looks like we aren't using the op cache in FSEditLog SetXAttrOp / RemoveXAttrOp. I think this is accidental, could you do some research? Particularly since we'll be doing a lot of SetXAttrOps, avoiding all that object allocation would be nice. This could be a separate JIRA.

i.e.

    static SetXAttrOp getInstance() {
      return new SetXAttrOp();
    }

v.s.

    static AddOp getInstance(OpInstanceCache cache) {
      return (AddOp) cache.get(OP_ADD);
    }

Seems we should fix these non-caching usages.

Issue Links

• relates to: HDFS-6301 NameNode: persist XAttrs in fsimage and record XAttrs modifications to edit log.