Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11387

Socket reuse address option is not honored in PrivilegedNfsGatewayStarter

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: nfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Socket resuse address option is not honored in PrivilegedNfsGatewayStarter

      This happens because the registrationSocket is first bind and then the options is set.

      According to from https://docs.oracle.com/javase/7/docs/api/java/net/StandardSocketOptions.html#SO_REUSEADDR
      Changing the value of this socket option after the socket is bound has no effect. The default value of this socket option is system dependent.

      Need to change this to first set the option on the socket and then bind it.

      1. HDFS-11387.001.patch
        1 kB
        Mukul Kumar Singh

        Activity

        Hide
        msingh Mukul Kumar Singh added a comment -

        This change involves binding the socket after setting the re-use address option on the socket.

        Show
        msingh Mukul Kumar Singh added a comment - This change involves binding the socket after setting the re-use address option on the socket.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 13m 38s trunk passed
        +1 compile 0m 22s trunk passed
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 24s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 0m 35s trunk passed
        +1 javadoc 0m 17s trunk passed
        +1 mvninstall 0m 21s the patch passed
        +1 compile 0m 19s the patch passed
        +1 javac 0m 19s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 20s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 39s the patch passed
        +1 javadoc 0m 12s the patch passed
        +1 unit 1m 58s hadoop-hdfs-nfs in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        22m 15s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11387
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12850808/HDFS-11387.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cc8847eaf9e7 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0914fcc
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18324/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project/hadoop-hdfs-nfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18324/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 38s trunk passed +1 compile 0m 22s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 35s trunk passed +1 javadoc 0m 17s trunk passed +1 mvninstall 0m 21s the patch passed +1 compile 0m 19s the patch passed +1 javac 0m 19s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 39s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 1m 58s hadoop-hdfs-nfs in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 22m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11387 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12850808/HDFS-11387.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cc8847eaf9e7 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0914fcc Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18324/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project/hadoop-hdfs-nfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18324/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1

        I've committed this. Thank you for the contribution Mukul Kumar Singh!

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 I've committed this. Thank you for the contribution Mukul Kumar Singh !
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11208 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11208/)
        HDFS-11387. Socket reuse address option is not honored in (arp: rev e0235842a74f1a1a62051ebb8c9dbd47324fcc25)

        • (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/PrivilegedNfsGatewayStarter.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11208 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11208/ ) HDFS-11387 . Socket reuse address option is not honored in (arp: rev e0235842a74f1a1a62051ebb8c9dbd47324fcc25) (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/PrivilegedNfsGatewayStarter.java

          People

          • Assignee:
            msingh Mukul Kumar Singh
            Reporter:
            msingh Mukul Kumar Singh
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development