Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-1138

Modification times are being overwritten when FSImage loads

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.22.0
    • None
    • None
    • Reviewed

    Description

      A very easy way to spot the bug is to do a second restart in TestRestartDFS and check that the modification time on root is the same as it was before the second restart.

      The problem is modifying time of the parent if the modification time of the child is greater than parent's in addToParent.

      So if you have /DIR/File then on creation of a file modification time of the DIR will be set, but on cluster restart, or when secondary is checkpointing and reading the image it will add DIR to "/" and write the new modification time for "/" which is the modification time of DIR.

      This is clearly a bug. I will attach a patch with one more parameter being passed from the loadFSImage that says to not propagate the time.

      Attachments

        1. HDFS-1138.2.patch
          7 kB
          Dmytro Molkov
        2. HDFS-1138
          6 kB
          Dmytro Molkov

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            dms Dmytro Molkov
            dms Dmytro Molkov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment