Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1138

Modification times are being overwritten when FSImage loads

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      A very easy way to spot the bug is to do a second restart in TestRestartDFS and check that the modification time on root is the same as it was before the second restart.

      The problem is modifying time of the parent if the modification time of the child is greater than parent's in addToParent.

      So if you have /DIR/File then on creation of a file modification time of the DIR will be set, but on cluster restart, or when secondary is checkpointing and reading the image it will add DIR to "/" and write the new modification time for "/" which is the modification time of DIR.

      This is clearly a bug. I will attach a patch with one more parameter being passed from the loadFSImage that says to not propagate the time.

      1. HDFS-1138
        6 kB
        Dmytro Molkov
      2. HDFS-1138.2.patch
        7 kB
        Dmytro Molkov

        Activity

        Konstantin Shvachko made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        dhruba borthakur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.22.0 [ 12314241 ]
        Resolution Fixed [ 1 ]
        Dmytro Molkov made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Dmytro Molkov made changes -
        Attachment HDFS-1138.2.patch [ 12444237 ]
        Dmytro Molkov made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Dmytro Molkov made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Dmytro Molkov made changes -
        Attachment HDFS-1138 [ 12444137 ]
        Dmytro Molkov made changes -
        Field Original Value New Value
        Assignee Dmytro Molkov [ dms ]
        Dmytro Molkov created issue -

          People

          • Assignee:
            Dmytro Molkov
            Reporter:
            Dmytro Molkov
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development