Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11375

Display the volume storage type in datanode UI

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: datanode, ui
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Volume storage info is useful for debugging the issue related to policy...

      1. HDFS-11375.02.patch
        2 kB
        Surendra Singh Lilhore
      2. DN_UI_Aftrerfix.png
        25 kB
        Surendra Singh Lilhore
      3. HDFS-11375.01.patch
        2 kB
        Surendra Singh Lilhore

        Issue Links

          Activity

          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached patch..
          Please review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached patch.. Please review..
          Hide
          hanishakoneru Hanisha Koneru added a comment -

          Reviewed and tested the patch.. Looks good to me.

          Show
          hanishakoneru Hanisha Koneru added a comment - Reviewed and tested the patch.. Looks good to me.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Hanisha Koneru for review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Hanisha Koneru for review..
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Surendra Singh Lilhore thanks for reporting.. Patch LGTM.. can you please re-upload the patch..? Jenkins is picking up .png file and failing..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Surendra Singh Lilhore thanks for reporting.. Patch LGTM.. can you please re-upload the patch..? Jenkins is picking up .png file and failing..
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thansk Brahma Reddy Battula for review...

          Reattached patch....

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thansk Brahma Reddy Battula for review... Reattached patch....
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 14m 25s trunk passed
          +1 compile 0m 54s trunk passed
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 0m 53s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 52s trunk passed
          +1 javadoc 0m 41s trunk passed
          +1 mvninstall 0m 47s the patch passed
          +1 compile 0m 48s the patch passed
          +1 javac 0m 48s the patch passed
          -0 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 79 unchanged - 0 fixed = 80 total (was 79)
          +1 mvnsite 0m 59s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 0s the patch passed
          +1 javadoc 0m 37s the patch passed
          -1 unit 68m 11s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          96m 57s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDecommission
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11375
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12850640/HDFS-11375.02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6689e58ff5de 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3433f57
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18316/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18316/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18316/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18316/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 25s trunk passed +1 compile 0m 54s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 52s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 47s the patch passed +1 compile 0m 48s the patch passed +1 javac 0m 48s the patch passed -0 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 79 unchanged - 0 fixed = 80 total (was 79) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 0s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 68m 11s hadoop-hdfs in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 96m 57s Reason Tests Failed junit tests hadoop.hdfs.TestDecommission   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11375 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12850640/HDFS-11375.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6689e58ff5de 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3433f57 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18316/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/18316/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18316/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18316/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Failed tests are unrelated..

          FsDatasetImpl.java:2609: final StorageType storageType;:23: Variable 'storageType' must be private and have accessor methods.

          Brahma Reddy Battula

          Do I need to fix this checkstyle warning ?

          In VolumeInfo class other fields are also not private and no getter method.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Failed tests are unrelated.. FsDatasetImpl.java:2609: final StorageType storageType;:23: Variable 'storageType' must be private and have accessor methods. Brahma Reddy Battula Do I need to fix this checkstyle warning ? In VolumeInfo class other fields are also not private and no getter method.
          Hide
          liuml07 Mingliang Liu added a comment -

          +1

          The failing tests are not related; let's fix checkstyle warnings with existing ones.

          Show
          liuml07 Mingliang Liu added a comment - +1 The failing tests are not related; let's fix checkstyle warnings with existing ones.
          Hide
          liuml07 Mingliang Liu added a comment -

          Committed to trunk and branch-2 branches. Thanks for your contribution Surendra Singh Lilhore. Thanks for your review Brahma Reddy Battula and Hanisha Koneru.

          Show
          liuml07 Mingliang Liu added a comment - Committed to trunk and branch-2 branches. Thanks for your contribution Surendra Singh Lilhore . Thanks for your review Brahma Reddy Battula and Hanisha Koneru .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11259 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11259/)
          HDFS-11375. Display the volume storage type in datanode UI. Contributed (liuml07: rev 0741dd3b9abdeb65bb783c1a8b01f078c4bdba17)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/datanode.html
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11259 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11259/ ) HDFS-11375 . Display the volume storage type in datanode UI. Contributed (liuml07: rev 0741dd3b9abdeb65bb783c1a8b01f078c4bdba17) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/datanode.html
          Hide
          surendrasingh Surendra Singh Lilhore added a comment - - edited

          Thanks Mingliang Liu for review and commit..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - - edited Thanks Mingliang Liu for review and commit..

            People

            • Assignee:
              surendrasingh Surendra Singh Lilhore
              Reporter:
              surendrasingh Surendra Singh Lilhore
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development