[HDFS-11362] StorageDirectory should initialize a non-null default StorageDirType

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.9.0, 3.0.0-alpha4
• Component/s: hdfs
• Hadoop Flags: Reviewed
• Assignee: Hanisha Koneru
• Reporter: Hanisha Koneru
• Created: 23/Jan/17 21:05
• Updated: 17/Apr/17 15:41
• Resolved: 06/Apr/17 21:35

Description

Storage#shouldReturnNextDir method checks if the next Storage directory is of the same type us dirType.

    private boolean shouldReturnNextDir() {
      StorageDirectory sd = getStorageDir(nextIndex);
      return (dirType == null || sd.getStorageDirType().isOfType(dirType)) &&
          (includeShared || !sd.isShared());
    }

There is a possibility that sd.getStorageDirType() returns null (default dirType is null). Hence, before checking for type match, we should make sure that the value returned by sd.getStorageDirType() is not null.