[HDFS-11342] Fix FileInputStream leak in loadLastPartialChunkChecksum

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha2
• Fix Version/s: 3.0.0-alpha2
• Component/s: datanode
• Hadoop Flags: Reviewed
• Assignee: Chen Liang
• Reporter: Arpit Agarwal
• Created: 14/Jan/17 00:45
• Updated: 16/Jan/17 22:12
• Resolved: 16/Jan/17 21:46

Description

FsVolumeImpl#loadLastPartialChunkChecksum leaks a FileInputStream here:

  @Override
  public byte[] loadLastPartialChunkChecksum(
      File blockFile, File metaFile) throws IOException {
    // readHeader closes the temporary FileInputStream.
    DataChecksum dcs = BlockMetadataHeader
        .readHeader(fileIoProvider.getFileInputStream(this, metaFile))
        .getChecksum();

Issue Links

• is broken by: HDFS-10958 Add instrumentation hooks around Datanode disk IO