Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11335

Remove HdfsClientConfigKeys.DFS_CLIENT_SLOW_IO_WARNING_THRESHOLD_KEY usage from DNConf

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: None
    • Labels:
      None

      Description

      DataNode configuration DNConf reading in HdfsClientConfigKeys.DFS_CLIENT_SLOW_IO_WARNING_THRESHOLD_KEY (dfs.client.slow.io.warning.threshold.ms) is redundant as this threshold limit is needed only for DfsClientConf. Better to remove the unwanted usage in DNConf.

      1. HDFS-11335.01.patch
        2 kB
        Manoj Govindassamy
      2. HDFS-11335.02.patch
        3 kB
        Manoj Govindassamy
      3. HDFS-11335.03.patch
        5 kB
        Manoj Govindassamy

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11193 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11193/)
        HDFS-11335. Remove (lei: rev bec9b7aa1dd3ed95b8783597135f8d90b3cc8dcd)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DNConf.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11193 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11193/ ) HDFS-11335 . Remove (lei: rev bec9b7aa1dd3ed95b8783597135f8d90b3cc8dcd) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DNConf.java
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        LGTM as well. +1. Committed to trunk and branch-2

        Thanks Manoj Govindassamy for working on this patch and Yiqun Lin for the reviews!

        Show
        eddyxu Lei (Eddy) Xu added a comment - LGTM as well. +1. Committed to trunk and branch-2 Thanks Manoj Govindassamy for working on this patch and Yiqun Lin for the reviews!
        Hide
        linyiqun Yiqun Lin added a comment -

        LGTM, +1. Thanks Manoj Govindassamy. Will hold off the commit to let Lei (Eddy) Xu take a look also.

        Show
        linyiqun Yiqun Lin added a comment - LGTM, +1. Thanks Manoj Govindassamy . Will hold off the commit to let Lei (Eddy) Xu take a look also.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 25s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 19m 27s trunk passed
        +1 compile 0m 49s trunk passed
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 48s trunk passed
        +1 javadoc 0m 39s trunk passed
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 47s the patch passed
        +1 javac 0m 47s the patch passed
        +1 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 473 unchanged - 3 fixed = 473 total (was 476)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 50s the patch passed
        +1 javadoc 0m 37s the patch passed
        -1 unit 93m 31s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        125m 33s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.server.datanode.TestDataNodeMXBean



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11335
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848989/HDFS-11335.03.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2101da692d77 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ce83205
        Default Java 1.8.0_121
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18243/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18243/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18243/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 19m 27s trunk passed +1 compile 0m 49s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 48s trunk passed +1 javadoc 0m 39s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 0m 47s the patch passed +1 javac 0m 47s the patch passed +1 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 473 unchanged - 3 fixed = 473 total (was 476) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 93m 31s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 125m 33s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.datanode.TestDataNodeMXBean Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11335 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848989/HDFS-11335.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2101da692d77 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ce83205 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18243/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18243/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18243/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        manojg Manoj Govindassamy added a comment -

        Thanks for the review Lei (Eddy) Xu, Yiqun Lin.
        Attached v03 patch addressing the following

        • Removed DFS_CLIENT_SLOW_IO_WARNING_THRESHOLD_* from DFSConfigKeys
        • Removed writePacketSize from DNConf and its corresponding DFS_CLIENT_WRITE_PACKET_SIZE_* from DFSConfigKeys

        Kindly take a look the latest patch.

        PS: DFSConfigKeys has several other references to HdfsClientConfigKeys constants and they are all Deprecated. This jira is not cleaning up the deprecated items in DFSConfigKeys.

        Show
        manojg Manoj Govindassamy added a comment - Thanks for the review Lei (Eddy) Xu , Yiqun Lin . Attached v03 patch addressing the following Removed DFS_CLIENT_SLOW_IO_WARNING_THRESHOLD_* from DFSConfigKeys Removed writePacketSize from DNConf and its corresponding DFS_CLIENT_WRITE_PACKET_SIZE_* from DFSConfigKeys Kindly take a look the latest patch. PS: DFSConfigKeys has several other references to HdfsClientConfigKeys constants and they are all Deprecated. This jira is not cleaning up the deprecated items in DFSConfigKeys.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Hi, Manoj Govindassamy

        Do you need to also delete DFSConfigKeys#DFS_CLIENT_SLOW_IO_WARNING_THRESHOLD_DEFAULT?

        Show
        eddyxu Lei (Eddy) Xu added a comment - Hi, Manoj Govindassamy Do you need to also delete DFSConfigKeys#DFS_CLIENT_SLOW_IO_WARNING_THRESHOLD_DEFAULT ?
        Hide
        manojg Manoj Govindassamy added a comment -

        TestDataNodeVolumeFailureReporting timeout failure is not related to the patch.

        Show
        manojg Manoj Govindassamy added a comment - TestDataNodeVolumeFailureReporting timeout failure is not related to the patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 14m 14s trunk passed
        +1 compile 0m 46s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 48s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 57s the patch passed
        +1 compile 0m 53s the patch passed
        +1 javac 0m 53s the patch passed
        +1 checkstyle 0m 32s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 475 unchanged - 2 fixed = 475 total (was 477)
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 55s the patch passed
        +1 javadoc 0m 37s the patch passed
        -1 unit 100m 23s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 36s The patch does not generate ASF License warnings.
        127m 53s



        Reason Tests
        Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11335
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847945/HDFS-11335.02.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 648ee6db4639 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 47dfda7
        Default Java 1.8.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18192/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18192/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18192/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 14s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 48s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 57s the patch passed +1 compile 0m 53s the patch passed +1 javac 0m 53s the patch passed +1 checkstyle 0m 32s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 475 unchanged - 2 fixed = 475 total (was 477) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 55s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 100m 23s hadoop-hdfs in the patch failed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 127m 53s Reason Tests Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11335 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847945/HDFS-11335.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 648ee6db4639 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 47dfda7 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18192/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18192/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18192/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        manojg Manoj Govindassamy added a comment -

        Thanks for the review Lei (Eddy) Xu. Sure, DFSConfigKeys#DFS_CLIENT_SLOW_IO_WARNING_THRESHOLD_DEFAULT was already deprecated on 2.8.0 release and I believe its safe to remove this config key.

        Attached v02 patch removing the deprecated DFS_CLIENT_SLOW_IO_WARNING_THRESHOLD_DEFAULT in DFSConfigKeys. Kindly take a look.

        Show
        manojg Manoj Govindassamy added a comment - Thanks for the review Lei (Eddy) Xu . Sure, DFSConfigKeys#DFS_CLIENT_SLOW_IO_WARNING_THRESHOLD_DEFAULT was already deprecated on 2.8.0 release and I believe its safe to remove this config key. Attached v02 patch removing the deprecated DFS_CLIENT_SLOW_IO_WARNING_THRESHOLD_DEFAULT in DFSConfigKeys. Kindly take a look.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Manoj Govindassamy

        Should we also remove DFS_CLIENT_SLOW_IO_WARNING_THRESHOLD_KEY from DFSConfigKeys?

        Show
        eddyxu Lei (Eddy) Xu added a comment - Manoj Govindassamy Should we also remove DFS_CLIENT_SLOW_IO_WARNING_THRESHOLD_KEY from DFSConfigKeys ?
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Manoj Govindassamy for catching this. I am thinking if we can remove another unused variable writePacketSize in DNConf.java. This variable has been defined in DfsClientConf and it mainly used by hdfs-client.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Manoj Govindassamy for catching this. I am thinking if we can remove another unused variable writePacketSize in DNConf.java . This variable has been defined in DfsClientConf and it mainly used by hdfs-client.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 13m 45s trunk passed
        +1 compile 0m 46s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 42s trunk passed
        +1 javadoc 0m 40s trunk passed
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        +1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 75 unchanged - 2 fixed = 75 total (was 77)
        +1 mvnsite 0m 47s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 47s the patch passed
        +1 javadoc 0m 37s the patch passed
        +1 unit 96m 39s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        122m 10s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11335
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847122/HDFS-11335.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 93fbb4d9963c 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e6f13fe
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18155/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18155/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 45s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed +1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 75 unchanged - 2 fixed = 75 total (was 77) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 37s the patch passed +1 unit 96m 39s hadoop-hdfs in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 122m 10s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11335 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847122/HDFS-11335.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 93fbb4d9963c 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e6f13fe Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18155/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18155/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        manojg Manoj Govindassamy added a comment -

        Attached v01 patch to remove redundant client threshold config read and usage in DNConf.

        Show
        manojg Manoj Govindassamy added a comment - Attached v01 patch to remove redundant client threshold config read and usage in DNConf.

          People

          • Assignee:
            manojg Manoj Govindassamy
            Reporter:
            manojg Manoj Govindassamy
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development