Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When writing HADOOP-6585 I noticed TestFileStatus is an old test with just one monolithic test function. We should rewrite it as a junit4 style test and break up the functions into setup, teardown, and five individual test cases. Same tests being run, just easier to follow, modify and add news tests. Patch coming.

      1. hdfs-1132-3.patch
        20 kB
        Eli Collins
      2. hdfs-1132-2.patch
        20 kB
        Eli Collins
      3. hdfs-1132-1.patch
        20 kB
        Eli Collins

        Activity

        Hide
        Eli Collins added a comment -

        Patch attached.

        Show
        Eli Collins added a comment - Patch attached.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12443760/hdfs-1132-1.patch
        against trunk revision 939918.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/344/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443760/hdfs-1132-1.patch against trunk revision 939918. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/344/console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Patch attached. Removed the dependency on HDFS-995. Apologies for the noise.

        Show
        Eli Collins added a comment - Patch attached. Removed the dependency on HDFS-995 . Apologies for the noise.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12443762/hdfs-1132-2.patch
        against trunk revision 939918.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/345/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/345/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/345/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/345/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443762/hdfs-1132-2.patch against trunk revision 939918. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/345/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/345/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/345/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/345/console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Test failures are for other tests and seem unrelated:

        org.apache.hadoop.hdfs.server.datanode.TestDiskError:

        2010-05-05 22:23:00,877 FATAL conf.Configuration (Configuration.java:loadResource(1508)) 
        - error parsing conf file: java.util.zip.ZipException: error reading zip file
        

        org.apache.hadoop.hdfs.server.namenode.TestNodeCount:

        java.lang.NullPointerException
        	at org.apache.hadoop.hdfs.server.namenode.BlockManager.countNodes(BlockManager.java:1372)
        	at org.apache.hadoop.hdfs.server.namenode.TestNodeCount.testNodeCount(TestNodeCount.java:119)
        
        Show
        Eli Collins added a comment - Test failures are for other tests and seem unrelated: org.apache.hadoop.hdfs.server.datanode.TestDiskError: 2010-05-05 22:23:00,877 FATAL conf.Configuration (Configuration.java:loadResource(1508)) - error parsing conf file: java.util.zip.ZipException: error reading zip file org.apache.hadoop.hdfs.server.namenode.TestNodeCount: java.lang.NullPointerException at org.apache.hadoop.hdfs.server.namenode.BlockManager.countNodes(BlockManager.java:1372) at org.apache.hadoop.hdfs.server.namenode.TestNodeCount.testNodeCount(TestNodeCount.java:119)
        Hide
        Konstantin Boudnik added a comment -

        Looks good.

        Some comments:

        • replace string literal io.file.buffer.size with FSConstants.BUFFER_SIZE
        • replace System.out.println's with Log
        • add diagnostic messages to the assert statements where they are missed
        Show
        Konstantin Boudnik added a comment - Looks good. Some comments: replace string literal io.file.buffer.size with FSConstants.BUFFER_SIZE replace System.out.println 's with Log add diagnostic messages to the assert statements where they are missed
        Hide
        Eli Collins added a comment -

        Thanks for the review Kos. Attached patch addresses your feedback (just removed the couple printlns as they weren't logging useful info).

        Show
        Eli Collins added a comment - Thanks for the review Kos. Attached patch addresses your feedback (just removed the couple printlns as they weren't logging useful info).
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12443813/hdfs-1132-3.patch
        against trunk revision 939918.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/171/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/171/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/171/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/171/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443813/hdfs-1132-3.patch against trunk revision 939918. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/171/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/171/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/171/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/171/console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Weird, the test results page claims 0 failures.

        Show
        Eli Collins added a comment - Weird, the test results page claims 0 failures.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12443813/hdfs-1132-3.patch
        against trunk revision 942003.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/347/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/347/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/347/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/347/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443813/hdfs-1132-3.patch against trunk revision 942003. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/347/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/347/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/347/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/347/console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        The contrib test failure (TestHdfsProxy) should be unrelated. Noticed the following in the logs, looks like a Hudson configuration error?

        Warning: bad ps syntax, perhaps a bogus '-'? See http://procps.sf.net/faq.html
             [exec] /usr/bin/kill -9 19994 
             [exec] /usr/bin/xargs: /usr/bin/kill: No such file or directory
             [exec] /homes/hudson/tools/ant/latest/bin/ant -Dversion=942003_HDFS-1132_PATCH-12443813 -Declipse.home=/homes/gkesavan/tools/eclipse/latest -Dpython.home=/homes/gkesavan/tools/python/latest -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib
        
        Show
        Eli Collins added a comment - The contrib test failure (TestHdfsProxy) should be unrelated. Noticed the following in the logs, looks like a Hudson configuration error? Warning: bad ps syntax, perhaps a bogus '-'? See http: //procps.sf.net/faq.html [exec] /usr/bin/kill -9 19994 [exec] /usr/bin/xargs: /usr/bin/kill: No such file or directory [exec] /homes/hudson/tools/ant/latest/bin/ant -Dversion=942003_HDFS-1132_PATCH-12443813 -Declipse.home=/homes/gkesavan/tools/eclipse/latest -Dpython.home=/homes/gkesavan/tools/python/latest -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12443813/hdfs-1132-3.patch
        against trunk revision 942003.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/348/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/348/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/348/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/348/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443813/hdfs-1132-3.patch against trunk revision 942003. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/348/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/348/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/348/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/348/console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        No core tests failed. Hudson is wacky.

        Show
        Eli Collins added a comment - No core tests failed. Hudson is wacky.
        Hide
        Scott Chen added a comment -

        Hi Eli,
        I am working on HDFS-1143. I am also seeing failures on TestHdfsProxy.
        I think it's irrelevant to my change. Have you figured out why it's failing?

        Show
        Scott Chen added a comment - Hi Eli, I am working on HDFS-1143 . I am also seeing failures on TestHdfsProxy. I think it's irrelevant to my change. Have you figured out why it's failing?
        Hide
        Eli Collins added a comment -

        No, unfortunately the contrib test results don't appear to be broken out on the hudson test results page, hard to tell from looking at the raw console log too. What we need is the test result output. I'll file a jira.

        Show
        Eli Collins added a comment - No, unfortunately the contrib test results don't appear to be broken out on the hudson test results page, hard to tell from looking at the raw console log too. What we need is the test result output. I'll file a jira.
        Hide
        Konstantin Boudnik added a comment -

        I have ran the test once again and it's ok.
        I have committed this. Thanks Eli.

        Show
        Konstantin Boudnik added a comment - I have ran the test once again and it's ok. I have committed this. Thanks Eli.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #282 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/282/)
        HDFS-1132. Refactor TestFileStatus. Contributed by Eli Collins.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #282 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/282/ ) HDFS-1132 . Refactor TestFileStatus. Contributed by Eli Collins.

          People

          • Assignee:
            Eli Collins
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development