Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11303

Hedged read might hang infinitely if read data from all DN failed

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: hdfs-client
    • Labels:
      None

      Description

      Hedged read will read from a DN first, if timeout, then read other DNs simultaneously.
      If read all DN failed, this bug will cause the future-list not empty(the first timeout request left in list), and hang in the loop infinitely

      1. HDFS-11303.003.patch
        6 kB
        Wei-Chiu Chuang
      2. HDFS-11303.004.patch
        6 kB
        John Zhuge
      3. HDFS-11303.005.patch
        6 kB
        John Zhuge
      4. HDFS-11303-001.patch
        5 kB
        stack
      5. HDFS-11303-001.patch
        5 kB
        Chen Zhang
      6. HDFS-11303-002.patch
        5 kB
        Chen Zhang
      7. HDFS-11303-002.patch
        5 kB
        Chen Zhang

        Activity

        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks for initiating the work, and look forward to more contribution from you!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks for initiating the work, and look forward to more contribution from you!
        Hide
        zhangchen Chen Zhang added a comment -

        Thanks John Zhuge a lot for pushing this issue forward.
        I'm sorry for leaving this issue aside, really busy on the work these days

        Show
        zhangchen Chen Zhang added a comment - Thanks John Zhuge a lot for pushing this issue forward. I'm sorry for leaving this issue aside, really busy on the work these days
        Hide
        jzhuge John Zhuge added a comment -

        Committed to branch-2.

        Show
        jzhuge John Zhuge added a comment - Committed to branch-2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12174 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12174/)
        HDFS-11303. Hedged read might hang infinitely if read data from all DN (jzhuge: rev 8b242f09a61a7536d2422546bfa6c2aaf1d57ed6)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestPread.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12174 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12174/ ) HDFS-11303 . Hedged read might hang infinitely if read data from all DN (jzhuge: rev 8b242f09a61a7536d2422546bfa6c2aaf1d57ed6) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestPread.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        Hide
        jzhuge John Zhuge added a comment - - edited

        Committed to trunk. Committing to branch-2 once YARN-7002 is fixed.

        Thanks Chen Zhang for discovering the issue and contributing a fix, Wei-Chiu Chuang for the review and the contribution.

        Show
        jzhuge John Zhuge added a comment - - edited Committed to trunk. Committing to branch-2 once YARN-7002 is fixed. Thanks Chen Zhang for discovering the issue and contributing a fix, Wei-Chiu Chuang for the review and the contribution.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        +1. Thanks Chen Zhang for reporting the issue and thanks John for carrying it to the finish line.

        Show
        jojochuang Wei-Chiu Chuang added a comment - +1. Thanks Chen Zhang for reporting the issue and thanks John for carrying it to the finish line.
        Hide
        jzhuge John Zhuge added a comment -

        TestDirectoryScanner was known to be flaky:

        Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 164.607 sec <<< FAILURE! - in org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner
        testThrottling(org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner)  Time elapsed: 151.664 sec  <<< FAILURE!
        java.lang.AssertionError: Throttle is too permissive
        	at org.junit.Assert.fail(Assert.java:88)
        	at org.junit.Assert.assertTrue(Assert.java:41)
        	at org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner.testThrottling(TestDirectoryScanner.java:718)
        

        So unless there is an objection, I will commit pretty soon.

        Show
        jzhuge John Zhuge added a comment - TestDirectoryScanner was known to be flaky: Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 164.607 sec <<< FAILURE! - in org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner testThrottling(org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner) Time elapsed: 151.664 sec <<< FAILURE! java.lang.AssertionError: Throttle is too permissive at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner.testThrottling(TestDirectoryScanner.java:718) So unless there is an objection, I will commit pretty soon.
        Hide
        jzhuge John Zhuge added a comment -

        Saw TestDataNodeVolumeFailureReporting failure in Aug 10 qbt:

        For more details, see https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/488/
        
        [Aug 9, 2017 6:58:53 AM] (weichiu) HDFS-12117. HttpFS does not seem to support SNAPSHOT related methods for
        [Aug 9, 2017 12:56:43 PM] (aajisaka) YARN-6515. Fix warnings from Spotbugs in hadoop-yarn-server-nodemanager.
        [Aug 9, 2017 2:03:51 PM] (kihwal) HDFS-12157. Do fsyncDirectory(..) outside of FSDataset lock. Contributed
        [Aug 9, 2017 2:58:22 PM] (aajisaka) YARN-6958. Moving logging APIs over to slf4j in
        [Aug 9, 2017 5:51:29 PM] (wangda) YARN-6033. Add support for sections in container-executor configuration
        [Aug 9, 2017 9:46:05 PM] (kihwal) HDFS-12278. LeaseManager operations are inefficient in 2.8. Contributed
        [Aug 9, 2017 10:39:52 PM] (raviprak) MAPREDUCE-6923. Optimize MapReduce Shuffle I/O for small partitions.
        [Aug 10, 2017 6:23:26 AM] (sunilg) YARN-6631. Refactor loader.js in new Yarn UI. Contributed by Akhil P B.
        
           Failed junit tests :
        
               hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
        
        Show
        jzhuge John Zhuge added a comment - Saw TestDataNodeVolumeFailureReporting failure in Aug 10 qbt: For more details, see https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/488/ [Aug 9, 2017 6:58:53 AM] (weichiu) HDFS-12117. HttpFS does not seem to support SNAPSHOT related methods for [Aug 9, 2017 12:56:43 PM] (aajisaka) YARN-6515. Fix warnings from Spotbugs in hadoop-yarn-server-nodemanager. [Aug 9, 2017 2:03:51 PM] (kihwal) HDFS-12157. Do fsyncDirectory(..) outside of FSDataset lock. Contributed [Aug 9, 2017 2:58:22 PM] (aajisaka) YARN-6958. Moving logging APIs over to slf4j in [Aug 9, 2017 5:51:29 PM] (wangda) YARN-6033. Add support for sections in container-executor configuration [Aug 9, 2017 9:46:05 PM] (kihwal) HDFS-12278. LeaseManager operations are inefficient in 2.8. Contributed [Aug 9, 2017 10:39:52 PM] (raviprak) MAPREDUCE-6923. Optimize MapReduce Shuffle I/O for small partitions. [Aug 10, 2017 6:23:26 AM] (sunilg) YARN-6631. Refactor loader.js in new Yarn UI. Contributed by Akhil P B. Failed junit tests : hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
        Hide
        jzhuge John Zhuge added a comment -

        Saw TestDecommissioningStatus failure in Jul 28 qbt:

        For more details, see https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/477/
        
        [Jul 27, 2017 5:44:50 PM] (varunsaxena) YARN-5548. Use MockRMMemoryStateStore to reduce test failures (Bibin A
        [Jul 27, 2017 6:40:45 PM] (varunsaxena) Addendum for YARN-5548. Use MockRMMemoryStateStore to reduce test
        [Jul 27, 2017 7:02:57 PM] (shv) HDFS-11896. Non-dfsUsed will be doubled on dead node re-registration.
        [Jul 27, 2017 8:04:50 PM] (aw) HADOOP-14692. Upgrade Apache Rat
        [Jul 27, 2017 8:23:15 PM] (jitendra) HDFS-2319. Add test cases for FSshell -stat. Contributed by XieXianshan
        [Jul 27, 2017 11:48:24 PM] (yzhang) HDFS-12190. Enable 'hdfs dfs -stat' to display access time. Contributed
        [Jul 28, 2017 12:10:52 AM] (aajisaka) HADOOP-11875. [JDK9] Adding a second copy of Hamlet without _ as a
        [Jul 28, 2017 6:19:39 AM] (yufei) YARN-6864. FSPreemptionThread cleanup for readability. (Daniel Templeton
        
        
        
        
        -1 overall
        
        
        The following subsystems voted -1:
               hadoop.hdfs.TestRollingUpgrade
               hadoop.hdfs.server.namenode.TestDecommissioningStatus
        
        Show
        jzhuge John Zhuge added a comment - Saw TestDecommissioningStatus failure in Jul 28 qbt: For more details, see https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/477/ [Jul 27, 2017 5:44:50 PM] (varunsaxena) YARN-5548. Use MockRMMemoryStateStore to reduce test failures (Bibin A [Jul 27, 2017 6:40:45 PM] (varunsaxena) Addendum for YARN-5548. Use MockRMMemoryStateStore to reduce test [Jul 27, 2017 7:02:57 PM] (shv) HDFS-11896. Non-dfsUsed will be doubled on dead node re-registration. [Jul 27, 2017 8:04:50 PM] (aw) HADOOP-14692. Upgrade Apache Rat [Jul 27, 2017 8:23:15 PM] (jitendra) HDFS-2319. Add test cases for FSshell -stat. Contributed by XieXianshan [Jul 27, 2017 11:48:24 PM] (yzhang) HDFS-12190. Enable 'hdfs dfs -stat' to display access time. Contributed [Jul 28, 2017 12:10:52 AM] (aajisaka) HADOOP-11875. [JDK9] Adding a second copy of Hamlet without _ as a [Jul 28, 2017 6:19:39 AM] (yufei) YARN-6864. FSPreemptionThread cleanup for readability. (Daniel Templeton -1 overall The following subsystems voted -1: hadoop.hdfs.TestRollingUpgrade hadoop.hdfs.server.namenode.TestDecommissioningStatus
        Hide
        jzhuge John Zhuge added a comment -

        Saw it in Aug 6 qbt:

        For more details, see https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/484/
        
        [Aug 4, 2017 4:40:45 PM] (jzhuge) HADOOP-14471. Upgrade Jetty to latest 9.3 version. Contributed by John
        [Aug 4, 2017 5:40:52 PM] (arp) HADOOP-13963. /bin/bash is hard coded in some of the scripts.
        [Aug 4, 2017 6:21:58 PM] (lei) HDFS-12251. Add document for StreamCapabilities. (Lei (Eddy) Xu)
        [Aug 4, 2017 7:51:33 PM] (arp) HDFS-12224. Add tests to TestJournalNodeSync for sync after JN downtime.
        [Aug 4, 2017 11:03:56 PM] (junping_du) YARN-6811. [ATS1.5] All history logs should be kept under its own User
        [Aug 4, 2017 11:46:59 PM] (arp) HADOOP-14685. Exclude some test jars from hadoop-client-minicluster jar.
               hadoop.security.TestRaceWhenRelogin
               hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
               hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
               hadoop.hdfs.TestRollingUpgrade
        
        Show
        jzhuge John Zhuge added a comment - Saw it in Aug 6 qbt: For more details, see https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/484/ [Aug 4, 2017 4:40:45 PM] (jzhuge) HADOOP-14471. Upgrade Jetty to latest 9.3 version. Contributed by John [Aug 4, 2017 5:40:52 PM] (arp) HADOOP-13963. /bin/bash is hard coded in some of the scripts. [Aug 4, 2017 6:21:58 PM] (lei) HDFS-12251. Add document for StreamCapabilities. (Lei (Eddy) Xu) [Aug 4, 2017 7:51:33 PM] (arp) HDFS-12224. Add tests to TestJournalNodeSync for sync after JN downtime. [Aug 4, 2017 11:03:56 PM] (junping_du) YARN-6811. [ATS1.5] All history logs should be kept under its own User [Aug 4, 2017 11:46:59 PM] (arp) HADOOP-14685. Exclude some test jars from hadoop-client-minicluster jar. hadoop.security.TestRaceWhenRelogin hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy hadoop.hdfs.TestRollingUpgrade
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks John!
        TestDFSStripedOutputStreamWithFailure080.test5 is failing for me a few times locally even without applying the patch.

        Still looking to see which recent commit broke the test.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks John! TestDFSStripedOutputStreamWithFailure080.test5 is failing for me a few times locally even without applying the patch. Still looking to see which recent commit broke the test.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 26s Maven dependency ordering for branch
        +1 mvninstall 13m 51s trunk passed
        +1 compile 1m 30s trunk passed
        +1 checkstyle 0m 43s trunk passed
        +1 mvnsite 1m 37s trunk passed
        -1 findbugs 1m 28s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
        -1 findbugs 1m 56s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
        +1 javadoc 1m 5s trunk passed
              Patch Compile Tests
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 1m 21s the patch passed
        +1 compile 1m 24s the patch passed
        +1 javac 1m 24s the patch passed
        +1 checkstyle 0m 38s the patch passed
        +1 mvnsite 1m 23s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 14s the patch passed
        +1 javadoc 0m 56s the patch passed
              Other Tests
        +1 unit 1m 11s hadoop-hdfs-client in the patch passed.
        -1 unit 72m 23s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        107m 11s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11303
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881417/HDFS-11303.005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 798a5a973b72 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f13ca94
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20659/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20659/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20659/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20659/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20659/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 26s Maven dependency ordering for branch +1 mvninstall 13m 51s trunk passed +1 compile 1m 30s trunk passed +1 checkstyle 0m 43s trunk passed +1 mvnsite 1m 37s trunk passed -1 findbugs 1m 28s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 56s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 1m 5s trunk passed       Patch Compile Tests 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 21s the patch passed +1 compile 1m 24s the patch passed +1 javac 1m 24s the patch passed +1 checkstyle 0m 38s the patch passed +1 mvnsite 1m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 14s the patch passed +1 javadoc 0m 56s the patch passed       Other Tests +1 unit 1m 11s hadoop-hdfs-client in the patch passed. -1 unit 72m 23s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 107m 11s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11303 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881417/HDFS-11303.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 798a5a973b72 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f13ca94 Default Java 1.8.0_144 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20659/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20659/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20659/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20659/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20659/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment - - edited

        Assigned to myself to submit the patch.

        Show
        jzhuge John Zhuge added a comment - - edited Assigned to myself to submit the patch.
        Hide
        jzhuge John Zhuge added a comment -

        Patch 005

        • Reset the metrics before the test since it is static. It could have been incremented by another test.
        Show
        jzhuge John Zhuge added a comment - Patch 005 Reset the metrics before the test since it is static. It could have been incremented by another test.
        Hide
        jzhuge John Zhuge added a comment -

        TestDFSStripedInputStreamWithRandomECPolicy passed for me locally.

        Show
        jzhuge John Zhuge added a comment - TestDFSStripedInputStreamWithRandomECPolicy passed for me locally.
        Hide
        jzhuge John Zhuge added a comment -

        Looking into TestPread and TestDFSStripedInputStreamWithRandomECPolicy failure.

        Show
        jzhuge John Zhuge added a comment - Looking into TestPread and TestDFSStripedInputStreamWithRandomECPolicy failure.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 30s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 29s Maven dependency ordering for branch
        +1 mvninstall 15m 43s trunk passed
        +1 compile 1m 47s trunk passed
        +1 checkstyle 0m 47s trunk passed
        +1 mvnsite 1m 42s trunk passed
        -1 findbugs 1m 32s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
        -1 findbugs 1m 47s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
        +1 javadoc 1m 6s trunk passed
              Patch Compile Tests
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 31s the patch passed
        +1 compile 1m 39s the patch passed
        +1 javac 1m 39s the patch passed
        +1 checkstyle 0m 43s the patch passed
        +1 mvnsite 1m 39s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 28s the patch passed
        +1 javadoc 1m 4s the patch passed
              Other Tests
        +1 unit 1m 18s hadoop-hdfs-client in the patch passed.
        -1 unit 97m 29s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        136m 20s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics
          hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.TestPread



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11303
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881344/HDFS-11303.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6a57954c0fac 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a32e013
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20647/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20647/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20647/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20647/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20647/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 30s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 29s Maven dependency ordering for branch +1 mvninstall 15m 43s trunk passed +1 compile 1m 47s trunk passed +1 checkstyle 0m 47s trunk passed +1 mvnsite 1m 42s trunk passed -1 findbugs 1m 32s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 47s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 1m 6s trunk passed       Patch Compile Tests 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 31s the patch passed +1 compile 1m 39s the patch passed +1 javac 1m 39s the patch passed +1 checkstyle 0m 43s the patch passed +1 mvnsite 1m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 28s the patch passed +1 javadoc 1m 4s the patch passed       Other Tests +1 unit 1m 18s hadoop-hdfs-client in the patch passed. -1 unit 97m 29s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 136m 20s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestPread Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11303 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881344/HDFS-11303.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6a57954c0fac 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a32e013 Default Java 1.8.0_144 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20647/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20647/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20647/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20647/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20647/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        Patch 004

        • Fix checkstyle
        • Rename futureComplete back to future to avoid gratuitous changes
        • A few wordings in comments
        Show
        jzhuge John Zhuge added a comment - Patch 004 Fix checkstyle Rename futureComplete back to future to avoid gratuitous changes A few wordings in comments
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 34s Maven dependency ordering for branch
        +1 mvninstall 19m 56s trunk passed
        +1 compile 2m 25s trunk passed
        +1 checkstyle 0m 58s trunk passed
        +1 mvnsite 2m 17s trunk passed
        -1 findbugs 2m 4s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
        -1 findbugs 2m 18s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
        +1 javadoc 1m 19s trunk passed
              Patch Compile Tests
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 50s the patch passed
        +1 compile 1m 56s the patch passed
        +1 javac 1m 56s the patch passed
        -0 checkstyle 0m 47s hadoop-hdfs-project: The patch generated 1 new + 58 unchanged - 0 fixed = 59 total (was 58)
        +1 mvnsite 1m 49s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 12s the patch passed
        +1 javadoc 1m 7s the patch passed
              Other Tests
        +1 unit 1m 29s hadoop-hdfs-client in the patch passed.
        -1 unit 90m 42s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        138m 26s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
          hadoop.hdfs.TestPread
          hadoop.hdfs.server.namenode.TestNameNodeMXBean
        Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11303
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881307/HDFS-11303.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9924b9e97719 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 312e57b
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20643/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20643/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20643/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20643/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20643/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20643/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 34s Maven dependency ordering for branch +1 mvninstall 19m 56s trunk passed +1 compile 2m 25s trunk passed +1 checkstyle 0m 58s trunk passed +1 mvnsite 2m 17s trunk passed -1 findbugs 2m 4s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 2m 18s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 1m 19s trunk passed       Patch Compile Tests 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 50s the patch passed +1 compile 1m 56s the patch passed +1 javac 1m 56s the patch passed -0 checkstyle 0m 47s hadoop-hdfs-project: The patch generated 1 new + 58 unchanged - 0 fixed = 59 total (was 58) +1 mvnsite 1m 49s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 12s the patch passed +1 javadoc 1m 7s the patch passed       Other Tests +1 unit 1m 29s hadoop-hdfs-client in the patch passed. -1 unit 90m 42s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 138m 26s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs   hadoop.hdfs.TestPread   hadoop.hdfs.server.namenode.TestNameNodeMXBean Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11303 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881307/HDFS-11303.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9924b9e97719 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 312e57b Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20643/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20643/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20643/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20643/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20643/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20643/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hi Chen Zhang. Your 002 patch is mostly good. I updated your latest patch to address some comments I had. Hope you don't mind.

        In addition,

        • Added a fail() to ensure DFSInputStream#read() fails as expected.
        • Because DFSInputStream#read() throws exception, the asserts are not reachable. Moved them to catch block.
        • Replaced the deprecated method IOUtils.cleanup with IOUtils.cleanupWithLogger.

        Regarding my first comment, I verified the test fails without the fix, and passes with the fix.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Hi Chen Zhang. Your 002 patch is mostly good. I updated your latest patch to address some comments I had. Hope you don't mind. In addition, Added a fail() to ensure DFSInputStream#read() fails as expected. Because DFSInputStream#read() throws exception, the asserts are not reachable. Moved them to catch block. Replaced the deprecated method IOUtils.cleanup with IOUtils.cleanupWithLogger . Regarding my first comment, I verified the test fails without the fix, and passes with the fix.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Chen Zhang ping. Would you still like to work on this patch?
        Thanks

        Show
        jojochuang Wei-Chiu Chuang added a comment - Chen Zhang ping. Would you still like to work on this patch? Thanks
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hi Chen Zhang, thanks for filing the jira and posting the patch.
        I'd like to help reviewing the patch. The fix itself looks good. Here's my quick comments, mostly cosmetic:

        1. I am not so sure about the test: you mentioned the client had timeouts connecting to DNs, but the test throws ChecksumException – it is not clear to me if client exhibit the same symptom in both scenarios. Perhaps you can use DFSClientFaultInjector.readFromDatanodeDelay to insert a delay instead?

        2. Could you add test timeout limit? For example a 10 second timeout: @Test(timeout=100000)

        3. It appears to me that the test expects to throw BlockMissingException. Instead of the following:

        	    } catch (BlockMissingException e) {
        	      assertTrue(true);
        	    }
        

        Would you mind update the test and use ExpectedException to assert that the exception is expected?

        4.

        	        if (true) {
        	          System.out.println("-------------- throw Checksum Exception");
        	          throw new ChecksumException("ChecksumException test", 100);
        	        }
        

        Please remove if(true) and please use DFSClient.LOG instead of System.out.println for log printing

        5. There's a slight code conflict due to HDFS-11708. Please rebase the patch.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Hi Chen Zhang , thanks for filing the jira and posting the patch. I'd like to help reviewing the patch. The fix itself looks good. Here's my quick comments, mostly cosmetic: 1. I am not so sure about the test: you mentioned the client had timeouts connecting to DNs, but the test throws ChecksumException – it is not clear to me if client exhibit the same symptom in both scenarios. Perhaps you can use DFSClientFaultInjector.readFromDatanodeDelay to insert a delay instead? 2. Could you add test timeout limit? For example a 10 second timeout: @Test(timeout=100000) 3. It appears to me that the test expects to throw BlockMissingException. Instead of the following: } catch (BlockMissingException e) { assertTrue( true ); } Would you mind update the test and use ExpectedException to assert that the exception is expected? 4. if ( true ) { System .out.println( "-------------- throw Checksum Exception" ); throw new ChecksumException( "ChecksumException test" , 100); } Please remove if(true) and please use DFSClient.LOG instead of System.out.println for log printing 5. There's a slight code conflict due to HDFS-11708 . Please rebase the patch.
        Hide
        jzhuge John Zhuge added a comment -

        Thanks Chen Zhang. Unfortunately I will be out of town for a couple of weeks. I will try to find someone to help review.

        Show
        jzhuge John Zhuge added a comment - Thanks Chen Zhang . Unfortunately I will be out of town for a couple of weeks. I will try to find someone to help review.
        Hide
        zhangchen Chen Zhang added a comment -

        John Zhuge thanks for your help, I've fixed the checkstyle error.
        The failed unit tests are not related with this patch

        Show
        zhangchen Chen Zhang added a comment - John Zhuge thanks for your help, I've fixed the checkstyle error. The failed unit tests are not related with this patch
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 24s Maven dependency ordering for branch
        +1 mvninstall 13m 24s trunk passed
        +1 compile 1m 24s trunk passed
        +1 checkstyle 0m 40s trunk passed
        +1 mvnsite 1m 26s trunk passed
        +1 findbugs 2m 58s trunk passed
        +1 javadoc 1m 0s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 1m 19s the patch passed
        +1 compile 1m 21s the patch passed
        +1 javac 1m 21s the patch passed
        +1 checkstyle 0m 37s the patch passed
        +1 mvnsite 1m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 11s the patch passed
        +1 javadoc 0m 55s the patch passed
        +1 unit 1m 10s hadoop-hdfs-client in the patch passed.
        -1 unit 63m 17s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        96m 31s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.balancer.TestBalancer
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11303
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872678/HDFS-11303-002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2eda761d8ab7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e86eef9
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19876/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19876/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19876/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 24s Maven dependency ordering for branch +1 mvninstall 13m 24s trunk passed +1 compile 1m 24s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 26s trunk passed +1 findbugs 2m 58s trunk passed +1 javadoc 1m 0s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 19s the patch passed +1 compile 1m 21s the patch passed +1 javac 1m 21s the patch passed +1 checkstyle 0m 37s the patch passed +1 mvnsite 1m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 11s the patch passed +1 javadoc 0m 55s the patch passed +1 unit 1m 10s hadoop-hdfs-client in the patch passed. -1 unit 63m 17s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 96m 31s Reason Tests Failed junit tests hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11303 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872678/HDFS-11303-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2eda761d8ab7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e86eef9 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/19876/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19876/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19876/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        zhangchen Chen Zhang added a comment -

        fix checkstyle issues

        Show
        zhangchen Chen Zhang added a comment - fix checkstyle issues
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 36s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 32s Maven dependency ordering for branch
        +1 mvninstall 15m 38s trunk passed
        +1 compile 1m 34s trunk passed
        +1 checkstyle 0m 43s trunk passed
        +1 mvnsite 1m 34s trunk passed
        +1 findbugs 3m 35s trunk passed
        +1 javadoc 1m 1s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 1m 19s the patch passed
        +1 compile 1m 25s the patch passed
        +1 javac 1m 25s the patch passed
        -0 checkstyle 0m 39s hadoop-hdfs-project: The patch generated 1 new + 58 unchanged - 0 fixed = 59 total (was 58)
        +1 mvnsite 1m 22s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 51s the patch passed
        +1 javadoc 0m 59s the patch passed
        +1 unit 1m 15s hadoop-hdfs-client in the patch passed.
        -1 unit 95m 21s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        133m 28s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11303
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872468/HDFS-11303-002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ce395e8e5527 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e86eef9
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19864/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19864/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19864/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19864/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 36s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 32s Maven dependency ordering for branch +1 mvninstall 15m 38s trunk passed +1 compile 1m 34s trunk passed +1 checkstyle 0m 43s trunk passed +1 mvnsite 1m 34s trunk passed +1 findbugs 3m 35s trunk passed +1 javadoc 1m 1s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 19s the patch passed +1 compile 1m 25s the patch passed +1 javac 1m 25s the patch passed -0 checkstyle 0m 39s hadoop-hdfs-project: The patch generated 1 new + 58 unchanged - 0 fixed = 59 total (was 58) +1 mvnsite 1m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 51s the patch passed +1 javadoc 0m 59s the patch passed +1 unit 1m 15s hadoop-hdfs-client in the patch passed. -1 unit 95m 21s hadoop-hdfs in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 133m 28s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11303 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872468/HDFS-11303-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ce395e8e5527 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e86eef9 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19864/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19864/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19864/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19864/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        zhangchen Chen Zhang added a comment -

        Re-submit the patch to kick off test-patch again.

        Show
        zhangchen Chen Zhang added a comment - Re-submit the patch to kick off test-patch again.
        Hide
        zhangchen Chen Zhang added a comment -

        fix checkstyle error

        Show
        zhangchen Chen Zhang added a comment - fix checkstyle error
        Hide
        jzhuge John Zhuge added a comment -

        Chen Zhang Thanks for the contribution. Could you please fix the checkstyle error and investigate whether the unit tests are related?

        Show
        jzhuge John Zhuge added a comment - Chen Zhang Thanks for the contribution. Could you please fix the checkstyle error and investigate whether the unit tests are related?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 7s Maven dependency ordering for branch
        +1 mvninstall 12m 48s trunk passed
        +1 compile 1m 25s trunk passed
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 1m 23s trunk passed
        +1 findbugs 3m 1s trunk passed
        +1 javadoc 0m 58s trunk passed
        0 mvndep 0m 6s Maven dependency ordering for patch
        +1 mvninstall 1m 18s the patch passed
        +1 compile 1m 23s the patch passed
        +1 javac 1m 23s the patch passed
        -0 checkstyle 0m 37s hadoop-hdfs-project: The patch generated 1 new + 56 unchanged - 0 fixed = 57 total (was 56)
        +1 mvnsite 1m 20s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 3m 15s the patch passed
        +1 javadoc 0m 56s the patch passed
        +1 unit 1m 11s hadoop-hdfs-client in the patch passed.
        -1 unit 69m 38s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        101m 56s



        Reason Tests
        Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts
          hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.server.namenode.ha.TestHAAppend



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-11303
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849144/HDFS-11303-001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cda9dfbcff9b 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b65100c
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19811/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19811/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19811/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19811/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19811/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 12m 48s trunk passed +1 compile 1m 25s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 1m 23s trunk passed +1 findbugs 3m 1s trunk passed +1 javadoc 0m 58s trunk passed 0 mvndep 0m 6s Maven dependency ordering for patch +1 mvninstall 1m 18s the patch passed +1 compile 1m 23s the patch passed +1 javac 1m 23s the patch passed -0 checkstyle 0m 37s hadoop-hdfs-project: The patch generated 1 new + 56 unchanged - 0 fixed = 57 total (was 56) +1 mvnsite 1m 20s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 3m 15s the patch passed +1 javadoc 0m 56s the patch passed +1 unit 1m 11s hadoop-hdfs-client in the patch passed. -1 unit 69m 38s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 101m 56s Reason Tests Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.namenode.ha.TestHAAppend Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11303 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849144/HDFS-11303-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cda9dfbcff9b 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b65100c Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19811/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19811/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19811/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19811/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19811/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        Re-submit the patch to kick off test-patch again.

        Show
        jzhuge John Zhuge added a comment - Re-submit the patch to kick off test-patch again.
        Hide
        zhangchen Chen Zhang added a comment -

        Got it, thanks a lot for your explanation, Stack.

        Show
        zhangchen Chen Zhang added a comment - Got it, thanks a lot for your explanation, Stack.
        Hide
        stack stack added a comment -

        Retry

        Show
        stack stack added a comment - Retry
        Hide
        stack stack added a comment -

        Hey Chen Zhang You got an email when Andrew made state changes to this issue. He set its state to 'patch available' which triggered a run of the CI system. It looks like one test failed. Do you think it related (let me trigger a rerun... some tests are flakey and fail on occasion irregardless of what the attached patch does). Andrew also flagged this JIRA as affecting 3.0.0-alpha1 which probably make it fit for commit as fix for next hadoop3 release.

        Let me trigger another run and see how the patch does. I'll leave this issue open another few days in the hope that someone else will chime in with a review. Will commit whether-or-which in a day or two. Thanks for the patch.

        Show
        stack stack added a comment - Hey Chen Zhang You got an email when Andrew made state changes to this issue. He set its state to 'patch available' which triggered a run of the CI system. It looks like one test failed. Do you think it related (let me trigger a rerun... some tests are flakey and fail on occasion irregardless of what the attached patch does). Andrew also flagged this JIRA as affecting 3.0.0-alpha1 which probably make it fit for commit as fix for next hadoop3 release. Let me trigger another run and see how the patch does. I'll leave this issue open another few days in the hope that someone else will chime in with a review. Will commit whether-or-which in a day or two. Thanks for the patch.
        Hide
        zhangchen Chen Zhang added a comment -

        Hi Andrew,

        I’m a newbie to apache community, HDFS-11303 is the first issue I've submitted
        In last week, I received a mail said you updated this issue, thanks a lot for your attention on this issue!
        But the issue seems been frozen to me, I can’t do any operation on it now, could you help point out what’s the status of this issue now, and what should I do next?

        Thanks a lot

        Best
        Chen

        Show
        zhangchen Chen Zhang added a comment - Hi Andrew, I’m a newbie to apache community, HDFS-11303 is the first issue I've submitted In last week, I received a mail said you updated this issue, thanks a lot for your attention on this issue! But the issue seems been frozen to me, I can’t do any operation on it now, could you help point out what’s the status of this issue now, and what should I do next? Thanks a lot Best Chen
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 30s Maven dependency ordering for branch
        +1 mvninstall 15m 24s trunk passed
        +1 compile 1m 49s trunk passed
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 1m 50s trunk passed
        +1 mvneclipse 0m 31s trunk passed
        +1 findbugs 3m 55s trunk passed
        +1 javadoc 1m 9s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 36s the patch passed
        +1 compile 1m 42s the patch passed
        +1 javac 1m 42s the patch passed
        -0 checkstyle 0m 36s hadoop-hdfs-project: The patch generated 1 new + 57 unchanged - 0 fixed = 58 total (was 57)
        +1 mvnsite 1m 41s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 4m 12s the patch passed
        +1 javadoc 1m 8s the patch passed
        +1 unit 1m 9s hadoop-hdfs-client in the patch passed.
        -1 unit 79m 23s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        120m 6s



        Reason Tests
        Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11303
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846229/HDFS-11303-001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 46ed72ff709f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e692316
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18132/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/18132/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/18132/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18132/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18132/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 30s Maven dependency ordering for branch +1 mvninstall 15m 24s trunk passed +1 compile 1m 49s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 50s trunk passed +1 mvneclipse 0m 31s trunk passed +1 findbugs 3m 55s trunk passed +1 javadoc 1m 9s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 36s the patch passed +1 compile 1m 42s the patch passed +1 javac 1m 42s the patch passed -0 checkstyle 0m 36s hadoop-hdfs-project: The patch generated 1 new + 57 unchanged - 0 fixed = 58 total (was 57) +1 mvnsite 1m 41s the patch passed +1 mvneclipse 0m 24s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 4m 12s the patch passed +1 javadoc 1m 8s the patch passed +1 unit 1m 9s hadoop-hdfs-client in the patch passed. -1 unit 79m 23s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 120m 6s Reason Tests Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11303 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846229/HDFS-11303-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 46ed72ff709f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e692316 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18132/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/18132/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/18132/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18132/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18132/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        zhangchen Chen Zhang added a comment -

        Stack, thanks for your comments. Yes, the test is just to verify, it hangs without the fix.

        Show
        zhangchen Chen Zhang added a comment - Stack, thanks for your comments. Yes, the test is just to verify, it hangs without the fix.
        Hide
        stack stack added a comment -

        Patch LGTM. Your patch allows that the primary read might still complete before the new hedged reads whereas what was there previous would discard anything that came in after timeout. Good. The test is just to verify we time out? W/o your fix, the test hangs?

        Show
        stack stack added a comment - Patch LGTM. Your patch allows that the primary read might still complete before the new hedged reads whereas what was there previous would discard anything that came in after timeout. Good. The test is just to verify we time out? W/o your fix, the test hangs?

          People

          • Assignee:
            zhangchen Chen Zhang
            Reporter:
            zhangchen Chen Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            18 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development