Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1130

Pass Administrator acl to HTTPServer for common servlet access.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: security
    • Labels:
      None

      Description

      Once HADOOP-6748 is done, HDFS should pass administrator acl when HTTPServer is constructed.

      1. hdfs-1130.3.patch
        6 kB
        Devaraj Das
      2. hdfs-1130.patch
        6 kB
        Devaraj Das
      3. hdfs-1130-trunk.patch
        9 kB
        Devaraj Das
      4. hdfs-1130-trunk-1.patch
        6 kB
        Devaraj Das

        Issue Links

          Activity

          Hide
          Devaraj Das added a comment -

          Patch for Y20S. Not for commit here.

          Show
          Devaraj Das added a comment - Patch for Y20S. Not for commit here.
          Hide
          Amareshwari Sriramadasu added a comment -

          A couple of comments on the patch:

          • hdfs_permissions_guide.xml and hdfs_default.xml has documentation for "dfs.permissions.supergroup". It should be modified/removed.
          • TestMapredSystemDir sets a value for the configuration "dfs.permissions.supergroup". The same should be removed.

          Other code changes look good to me.

          Show
          Amareshwari Sriramadasu added a comment - A couple of comments on the patch: hdfs_permissions_guide.xml and hdfs_default.xml has documentation for "dfs.permissions.supergroup". It should be modified/removed. TestMapredSystemDir sets a value for the configuration "dfs.permissions.supergroup". The same should be removed. Other code changes look good to me.
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch. Documentation needs to be updated to describe new config param dfs.cluster.administrators in hdfs_permissions_guide.xml.

          Show
          Suresh Srinivas added a comment - +1 for the patch. Documentation needs to be updated to describe new config param dfs.cluster.administrators in hdfs_permissions_guide.xml.
          Hide
          Devaraj Das added a comment -

          Updated patch for Y20S

          Show
          Devaraj Das added a comment - Updated patch for Y20S
          Hide
          Devaraj Das added a comment -

          Patch for trunk.

          Show
          Devaraj Das added a comment - Patch for trunk.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12449311/hdfs-1130-trunk.patch
          against trunk revision 962908.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/215/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/215/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/215/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/215/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449311/hdfs-1130-trunk.patch against trunk revision 962908. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/215/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/215/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/215/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/215/console This message is automatically generated.
          Hide
          Amareshwari Sriramadasu added a comment -

          Code changes in the patch look good.
          But some tests in MapReduce project (e.g. TestMRCLI) would fail after this patch. We should raise a follow up jira in MapReduce parallelly to remove "dfs.permissions.supergroup" and fix the testcases.

          Show
          Amareshwari Sriramadasu added a comment - Code changes in the patch look good. But some tests in MapReduce project (e.g. TestMRCLI) would fail after this patch. We should raise a follow up jira in MapReduce parallelly to remove "dfs.permissions.supergroup" and fix the testcases.
          Hide
          Devaraj Das added a comment -

          This is an updated patch for trunk that mirrors the Y20 patch. For now, I think we should just do this, and have the changes to do with dfs.permissions.supergroup handled in a separate jira.

          Show
          Devaraj Das added a comment - This is an updated patch for trunk that mirrors the Y20 patch. For now, I think we should just do this, and have the changes to do with dfs.permissions.supergroup handled in a separate jira.
          Hide
          Amareshwari Sriramadasu added a comment -

          In Y20 patch, I see that the user who started the NameNode/DataNode is added to the admin ACL. But the trunk's version takes it only from the configuration "dfs.cluster.administrators". Shall we add the user who started the NameNode/DataNode to the admin ACL?

          Show
          Amareshwari Sriramadasu added a comment - In Y20 patch, I see that the user who started the NameNode/DataNode is added to the admin ACL. But the trunk's version takes it only from the configuration "dfs.cluster.administrators". Shall we add the user who started the NameNode/DataNode to the admin ACL?
          Hide
          Devaraj Das added a comment -

          Yeah in the Y20S patch, i had added the user who starts the NN/DN to the admin ACL. But now I don't think that's required. Typically, this user would already be part of the group configured in the dfs.cluster.administrators ACL.

          Show
          Devaraj Das added a comment - Yeah in the Y20S patch, i had added the user who starts the NN/DN to the admin ACL. But now I don't think that's required. Typically, this user would already be part of the group configured in the dfs.cluster.administrators ACL.
          Hide
          Devaraj Das added a comment -

          Trying hudson again

          Show
          Devaraj Das added a comment - Trying hudson again
          Hide
          Amareshwari Sriramadasu added a comment -

          +1Patch looks good.

          Show
          Amareshwari Sriramadasu added a comment - +1Patch looks good.
          Hide
          Devaraj Das added a comment -

          I just committed this. (all tests/test-patch passed with the patch).

          Show
          Devaraj Das added a comment - I just committed this. (all tests/test-patch passed with the patch).
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #370 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/370/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #370 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/370/ )

            People

            • Assignee:
              Devaraj Das
              Reporter:
              Amareshwari Sriramadasu
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development