Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11278

Add missing @Test annotation for TestSafeMode.testSafeModeUtils()

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Tags:
      test
    • Flags:
      Patch
    1. HDFS-11278.001.patch
      0.7 kB
      Lukas Majercak

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukmajercak closed the pull request at:

        https://github.com/apache/hadoop/pull/175

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukmajercak closed the pull request at: https://github.com/apache/hadoop/pull/175
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user aajisaka commented on the issue:

        https://github.com/apache/hadoop/pull/175

        The patch is committed. Hi @lukmajercak , would you close this pull request?

        Show
        githubbot ASF GitHub Bot added a comment - Github user aajisaka commented on the issue: https://github.com/apache/hadoop/pull/175 The patch is committed. Hi @lukmajercak , would you close this pull request?
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11052 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11052/)
        HDFS-11278. Add missing @Test annotation for (templedf: rev ce3613c9656e57efdc73edd1787bd9622d1b716e)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSafeMode.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11052 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11052/ ) HDFS-11278 . Add missing @Test annotation for (templedf: rev ce3613c9656e57efdc73edd1787bd9622d1b716e) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSafeMode.java
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Lukas Majercak. Committed to trunk, branch-2, and branch-2.8.

        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Lukas Majercak . Committed to trunk, branch-2, and branch-2.8.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 14m 25s trunk passed
        +1 compile 0m 52s trunk passed
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 59s trunk passed
        +1 javadoc 0m 46s trunk passed
        +1 mvninstall 0m 52s the patch passed
        +1 compile 0m 46s the patch passed
        +1 javac 0m 46s the patch passed
        +1 checkstyle 0m 27s the patch passed
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 2s the patch passed
        +1 javadoc 0m 39s the patch passed
        -1 unit 69m 4s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        96m 37s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11278
        GITHUB PR https://github.com/apache/hadoop/pull/175
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f31a4db17ce6 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9ca54f4
        Default Java 1.8.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17977/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17977/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17977/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 25s trunk passed +1 compile 0m 52s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 52s the patch passed +1 compile 0m 46s the patch passed +1 javac 0m 46s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 2s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 69m 4s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 96m 37s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11278 GITHUB PR https://github.com/apache/hadoop/pull/175 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f31a4db17ce6 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9ca54f4 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17977/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17977/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17977/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Lukas Majercak, thanks for the patch. LGTM. Can you please post it to this JIRA as a patch so that the pre-commit job runs? Pending the success there, I'm +1.

        Show
        templedf Daniel Templeton added a comment - Lukas Majercak , thanks for the patch. LGTM. Can you please post it to this JIRA as a patch so that the pre-commit job runs? Pending the success there, I'm +1.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user templedf commented on the issue:

        https://github.com/apache/hadoop/pull/175

        LGTM +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user templedf commented on the issue: https://github.com/apache/hadoop/pull/175 LGTM +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user lukmajercak opened a pull request:

        https://github.com/apache/hadoop/pull/175

        HDFS-11278 Add missing @Test annotation for TestSafeMode.testSafeModeUtils

        Add a missing @Test annotation for TestSafeMode.testSafeModeUtils()

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/lukmajercak/hadoop HDFS-11278

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/hadoop/pull/175.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #175



        Show
        githubbot ASF GitHub Bot added a comment - GitHub user lukmajercak opened a pull request: https://github.com/apache/hadoop/pull/175 HDFS-11278 Add missing @Test annotation for TestSafeMode.testSafeModeUtils Add a missing @Test annotation for TestSafeMode.testSafeModeUtils() You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukmajercak/hadoop HDFS-11278 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/175.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #175

          People

          • Assignee:
            lukmajercak Lukas Majercak
            Reporter:
            lukmajercak Lukas Majercak
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development