[HDFS-11275] Check groupEntryIndex and throw a helpful exception on failures when removing ACL.

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha2
• Component/s: namenode
• Target Version/s: 3.0.0-alpha2
• Hadoop Flags: Reviewed
• Assignee: Xiao Chen
• Reporter: Xiao Chen
• Created: 27/Dec/16 17:38
• Updated: 02/Oct/19 17:15
• Resolved: 29/Dec/16 18:38

Description

We only have the logs to the exception but not the metadata, so hard to reproduce. The log is:

ERROR org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader: Encountered exception on operation org.apache.hadoop.hdfs.server.namenode.FSEditLogOp$SetAclOp@7aad3f7d 
java.lang.IndexOutOfBoundsException: index (-4) must not be negative 
at com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:301) 
at com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:280) 
at com.google.common.collect.RegularImmutableList.get(RegularImmutableList.java:91) 
at org.apache.hadoop.hdfs.server.namenode.AclStorage.removeINodeAcl(AclStorage.java:267) 
at org.apache.hadoop.hdfs.server.namenode.FSDirectory.unprotectedRemoveAcl(FSDirectory.java:2720) 
at org.apache.hadoop.hdfs.server.namenode.FSDirectory.unprotectedSetAcl(FSDirectory.java:2737) 
at org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.applyEditLogOp(FSEditLogLoader.java:827) 
at org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.loadEditRecords(FSEditLogLoader.java:231) 
at org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.loadFSEdits(FSEditLogLoader.java:140) 
at org.apache.hadoop.hdfs.server.namenode.FSImage.loadEdits(FSImage.java:846) 

Let's use this jira to add more information to the exception, to hopefully help the next reoccurrence. (Have not failed again in the past week)