Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11274

Datanode should only check the failed volume upon IO errors

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is a performance improvement that is possible after HDFS-11182. The goal is to trigger async volume check with throttling only on suspected volume upon datanode file IO errors.

      1. HDFS-11274.01.patch
        36 kB
        Xiaoyu Yao
      2. HDFS-11274.02.patch
        36 kB
        Xiaoyu Yao
      3. HDFS-11274.03.patch
        57 kB
        Xiaoyu Yao
      4. HDFS-11274.04.patch
        59 kB
        Xiaoyu Yao
      5. HDFS-11274.05.patch
        63 kB
        Xiaoyu Yao
      6. HDFS-11274.06.patch
        66 kB
        Xiaoyu Yao
      7. HDFS-11274-branch-2.01.patch
        76 kB
        Arpit Agarwal

        Activity

        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Results from running test-patch on the branch-2 patch.

        | Vote |      Subsystem |  Runtime   | Comment
        ============================================================================
        |  +1  |       @author  |  0m 0s     | The patch does not contain any @author
        |      |                |            | tags.
        |  +1  |    test4tests  |  0m 0s     | The patch appears to include 17 new or
        |      |                |            | modified test files.
        |  +1  |    mvninstall  |  3m 30s    | branch-2 passed
        |  +1  |       compile  |  0m 27s    | branch-2 passed
        |  +1  |    checkstyle  |  0m 25s    | branch-2 passed
        |  +1  |       mvnsite  |  0m 33s    | branch-2 passed
        |  +1  |    mvneclipse  |  0m 11s    | branch-2 passed
        |  +1  |      findbugs  |  1m 0s     | branch-2 passed
        |  +1  |       javadoc  |  0m 40s    | branch-2 passed
        |  +1  |    mvninstall  |  0m 27s    | the patch passed
        |  +1  |       compile  |  0m 25s    | the patch passed
        |  -1  |         javac  |  0m 25s    | hadoop-hdfs-project_hadoop-hdfs
        |      |                |            | generated 1 new + 43 unchanged - 1 fixed
        |      |                |            | = 44 total (was 44)
        |  -1  |    checkstyle  |  0m 23s    | hadoop-hdfs-project/hadoop-hdfs: The
        |      |                |            | patch generated 18 new + 670 unchanged -
        |      |                |            | 36 fixed = 688 total (was 706)
        |  +1  |       mvnsite  |  0m 29s    | the patch passed
        |  +1  |    mvneclipse  |  0m 9s     | the patch passed
        |  +1  |    whitespace  |  0m 0s     | The patch has no whitespace issues.
        |  +1  |      findbugs  |  1m 3s     | the patch passed
        |  +1  |       javadoc  |  0m 38s    | the patch passed
        |  -1  |          unit  |  99m 51s   | hadoop-hdfs in the patch failed.
        |  +1  |    asflicense  |  0m 13s    | The patch does not generate ASF License
        |      |                |            | warnings.
        |      |                |  111m 23s  |
        
                      Reason | Tests
         Failed junit tests  |  hadoop.hdfs.server.datanode.TestBatchIbr
                             |  hadoop.hdfs.server.datanode.TestDataNodeReconfiguration
                             |  hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication
                             |  hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
                             |  hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy
                             |  hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant
                             |  hadoop.hdfs.server.namenode.TestUpgradeDomainBlockPlacementPolicy
                             |  hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
                             |  hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd
                             |  hadoop.hdfs.server.blockmanagement.TestPendingReplication
                             |  hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
                             |  hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean
                             |  hadoop.hdfs.server.balancer.TestBalancer
                             |  hadoop.hdfs.server.mover.TestStorageMover
                             |  hadoop.hdfs.TestInjectionForSimulatedStorage
                             |  hadoop.hdfs.TestCrcCorruption
                             |  hadoop.hdfs.TestEncryptedTransfer
                             |  hadoop.hdfs.TestMaintenanceState
                             |  hadoop.hdfs.TestReplication
                             |  hadoop.hdfs.TestSetrepDecreasing
                             |  hadoop.hdfs.TestSetrepIncreasing
                             |  hadoop.hdfs.TestDatanodeDeath
                             |  hadoop.hdfs.TestFileAppend2
                             |  hadoop.hdfs.TestDecommission
                             |  hadoop.hdfs.TestLeaseRecovery2
        

        All test failures did not repro on rerunning (caused by failed to create a child event loop errors). The javac warning is in pre-existing one in a test case. Checkstyle issues were also in existing code except for some indentation warnings. I will commit it to branch-2 shortly.

        Show
        arpitagarwal Arpit Agarwal added a comment - Results from running test-patch on the branch-2 patch. | Vote | Subsystem | Runtime | Comment ============================================================================ | +1 | @author | 0m 0s | The patch does not contain any @author | | | | tags. | +1 | test4tests | 0m 0s | The patch appears to include 17 new or | | | | modified test files. | +1 | mvninstall | 3m 30s | branch-2 passed | +1 | compile | 0m 27s | branch-2 passed | +1 | checkstyle | 0m 25s | branch-2 passed | +1 | mvnsite | 0m 33s | branch-2 passed | +1 | mvneclipse | 0m 11s | branch-2 passed | +1 | findbugs | 1m 0s | branch-2 passed | +1 | javadoc | 0m 40s | branch-2 passed | +1 | mvninstall | 0m 27s | the patch passed | +1 | compile | 0m 25s | the patch passed | -1 | javac | 0m 25s | hadoop-hdfs-project_hadoop-hdfs | | | | generated 1 new + 43 unchanged - 1 fixed | | | | = 44 total (was 44) | -1 | checkstyle | 0m 23s | hadoop-hdfs-project/hadoop-hdfs: The | | | | patch generated 18 new + 670 unchanged - | | | | 36 fixed = 688 total (was 706) | +1 | mvnsite | 0m 29s | the patch passed | +1 | mvneclipse | 0m 9s | the patch passed | +1 | whitespace | 0m 0s | The patch has no whitespace issues. | +1 | findbugs | 1m 3s | the patch passed | +1 | javadoc | 0m 38s | the patch passed | -1 | unit | 99m 51s | hadoop-hdfs in the patch failed. | +1 | asflicense | 0m 13s | The patch does not generate ASF License | | | | warnings. | | | 111m 23s | Reason | Tests Failed junit tests | hadoop.hdfs.server.datanode.TestBatchIbr | hadoop.hdfs.server.datanode.TestDataNodeReconfiguration | hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication | hadoop.hdfs.server.namenode.TestNamenodeCapacityReport | hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy | hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant | hadoop.hdfs.server.namenode.TestUpgradeDomainBlockPlacementPolicy | hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality | hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd | hadoop.hdfs.server.blockmanagement.TestPendingReplication | hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks | hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean | hadoop.hdfs.server.balancer.TestBalancer | hadoop.hdfs.server.mover.TestStorageMover | hadoop.hdfs.TestInjectionForSimulatedStorage | hadoop.hdfs.TestCrcCorruption | hadoop.hdfs.TestEncryptedTransfer | hadoop.hdfs.TestMaintenanceState | hadoop.hdfs.TestReplication | hadoop.hdfs.TestSetrepDecreasing | hadoop.hdfs.TestSetrepIncreasing | hadoop.hdfs.TestDatanodeDeath | hadoop.hdfs.TestFileAppend2 | hadoop.hdfs.TestDecommission | hadoop.hdfs.TestLeaseRecovery2 All test failures did not repro on rerunning (caused by failed to create a child event loop errors). The javac warning is in pre-existing one in a test case. Checkstyle issues were also in existing code except for some indentation warnings. I will commit it to branch-2 shortly.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        The branch-2 patch has a dependency on a couple of other issues. Will run test-patch locally.

        Show
        arpitagarwal Arpit Agarwal added a comment - The branch-2 patch has a dependency on a couple of other issues. Will run test-patch locally.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 8s HDFS-11274 does not apply to branch-2. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HDFS-11274
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847702/HDFS-11274-branch-2.01.patch
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18186/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 8s HDFS-11274 does not apply to branch-2. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-11274 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847702/HDFS-11274-branch-2.01.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18186/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Attaching branch-2 backport patch. The conflicts were straightforward, mainly needed some fixes for Java 7.

        Show
        arpitagarwal Arpit Agarwal added a comment - Attaching branch-2 backport patch. The conflicts were straightforward, mainly needed some fixes for Java 7.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Reopening to run Jenkins against the branch-2 patch.

        Show
        arpitagarwal Arpit Agarwal added a comment - Reopening to run Jenkins against the branch-2 patch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11053 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11053/)
        HDFS-11274. Datanode should only check the failed volume upon IO errors. (arp: rev 603f3ef1386048111940b66f3a0750ab84d0588f)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DefaultFileIoEvents.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ProfilingFileIoEvents.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/CountingFileIoEvents.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureReporting.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/StorageLocationChecker.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/ThrottledAsyncChecker.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/checker/TestDatasetVolumeChecker.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/checker/TestThrottledAsyncChecker.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/DatasetVolumeChecker.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FileIoEvents.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ReplicaInfo.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/checker/TestDatasetVolumeCheckerFailures.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImplBuilder.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FileIoProvider.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/AsyncChecker.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeHotSwapVolumes.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11053 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11053/ ) HDFS-11274 . Datanode should only check the failed volume upon IO errors. (arp: rev 603f3ef1386048111940b66f3a0750ab84d0588f) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DefaultFileIoEvents.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ProfilingFileIoEvents.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/CountingFileIoEvents.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureReporting.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/StorageLocationChecker.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/ThrottledAsyncChecker.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/checker/TestDatasetVolumeChecker.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/checker/TestThrottledAsyncChecker.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/DatasetVolumeChecker.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FileIoEvents.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ReplicaInfo.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/checker/TestDatasetVolumeCheckerFailures.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImplBuilder.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FileIoProvider.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/AsyncChecker.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeHotSwapVolumes.java
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Pushed to trunk with the following trivial changes to address chekstyle:

                     numCallbackInvocations.incrementAndGet();
        -            if (expectedVolumeHealth != null && expectedVolumeHealth != FAILED) {
        +            if (expectedVolumeHealth != null &&
        +                expectedVolumeHealth != FAILED) {
                       assertThat(healthyVolumes.size(), is(1));
        
         import org.junit.Test;
        -import org.junit.rules.ExpectedException;
         import org.slf4j.Logger;
        
                     checker.schedule(target, true);
        -        return olf3.isPresent() == false;
        +        return !olf3.isPresent();
               }
        
        Show
        arpitagarwal Arpit Agarwal added a comment - Pushed to trunk with the following trivial changes to address chekstyle: numCallbackInvocations.incrementAndGet(); - if (expectedVolumeHealth != null && expectedVolumeHealth != FAILED) { + if (expectedVolumeHealth != null && + expectedVolumeHealth != FAILED) { assertThat(healthyVolumes.size(), is(1)); import org.junit.Test; - import org.junit.rules.ExpectedException; import org.slf4j.Logger; checker.schedule(target, true ); - return olf3.isPresent() == false ; + return !olf3.isPresent(); }
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        The test failure looks unrelated and didn't repro locally over ~10 attempts. It also failed in a few other pre-commit runs recently. I will commit the v6 patch shortly.

        Show
        arpitagarwal Arpit Agarwal added a comment - The test failure looks unrelated and didn't repro locally over ~10 attempts. It also failed in a few other pre-commit runs recently. I will commit the v6 patch shortly.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
        +1 mvninstall 12m 28s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 0m 50s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 42s trunk passed
        +1 javadoc 0m 38s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        -0 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 393 unchanged - 6 fixed = 402 total (was 399)
        +1 mvnsite 0m 47s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 47s the patch passed
        +1 javadoc 0m 38s the patch passed
        -1 unit 66m 40s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        90m 46s



        Reason Tests
        Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11274
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845000/HDFS-11274.06.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7062fef1976f 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f216276
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17978/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17978/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17978/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17978/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. +1 mvninstall 12m 28s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 38s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 393 unchanged - 6 fixed = 402 total (was 399) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 38s the patch passed -1 unit 66m 40s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 90m 46s Reason Tests Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11274 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845000/HDFS-11274.06.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7062fef1976f 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f216276 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17978/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17978/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17978/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17978/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 for the v6 patch. Thanks Xiaoyu Yao.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 for the v6 patch. Thanks Xiaoyu Yao .
        Hide
        xyao Xiaoyu Yao added a comment -

        Created HDFS-11279 to cleanup unused code DataNode#checkDiskErrorAsync().

        Show
        xyao Xiaoyu Yao added a comment - Created HDFS-11279 to cleanup unused code DataNode#checkDiskErrorAsync().
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Arpit Agarwal for the review and discussion. Update patch v06 .
        Summary of delta from v05
        1. Fix the volumeCounter for DatasetVolumeChecker as we are not adding callback for all the volume check request. This fixes all the federated related test failures.
        2. Clean up the volume reference for the case where the volume check request is skipped due to either the check interval is too short or there is an existing in progress check.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Arpit Agarwal for the review and discussion. Update patch v06 . Summary of delta from v05 1. Fix the volumeCounter for DatasetVolumeChecker as we are not adding callback for all the volume check request. This fixes all the federated related test failures. 2. Clean up the volume reference for the case where the volume check request is skipped due to either the check interval is too short or there is an existing in progress check.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
        +1 mvninstall 13m 4s trunk passed
        +1 compile 0m 44s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 43s trunk passed
        +1 javadoc 0m 39s trunk passed
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        -0 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 392 unchanged - 6 fixed = 401 total (was 398)
        +1 mvnsite 0m 47s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 48s the patch passed
        +1 javadoc 0m 37s the patch passed
        -1 unit 108m 13s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 40s The patch does not generate ASF License warnings.
        133m 27s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.TestDecommission
        Timed out junit tests org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeExit
          org.apache.hadoop.fs.viewfs.TestViewFileSystemWithTruncate
          org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean
          org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls
          org.apache.hadoop.fs.viewfs.TestViewFileSystemWithXAttrs
          org.apache.hadoop.fs.viewfs.TestViewFsWithXAttrs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11274
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844990/HDFS-11274.05.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f3d106560628 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9ca54f4
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17976/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17976/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17976/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17976/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 13m 4s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 39s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed -0 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 392 unchanged - 6 fixed = 401 total (was 398) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 108m 13s hadoop-hdfs in the patch failed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 133m 27s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestDecommission Timed out junit tests org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs   org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool   org.apache.hadoop.hdfs.server.datanode.TestDataNodeExit   org.apache.hadoop.fs.viewfs.TestViewFileSystemWithTruncate   org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean   org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls   org.apache.hadoop.fs.viewfs.TestViewFileSystemWithXAttrs   org.apache.hadoop.fs.viewfs.TestViewFsWithXAttrs Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11274 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844990/HDFS-11274.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f3d106560628 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9ca54f4 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17976/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17976/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17976/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17976/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
        +1 mvninstall 13m 32s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 50s trunk passed
        +1 javadoc 0m 42s trunk passed
        +1 mvninstall 0m 50s the patch passed
        +1 compile 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        -0 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 393 unchanged - 6 fixed = 402 total (was 399)
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 52s the patch passed
        +1 javadoc 0m 44s the patch passed
        -1 unit 92m 12s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 25s The patch does not generate ASF License warnings.
        118m 4s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
        Timed out junit tests org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs
          org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeExit
          org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls
          org.apache.hadoop.fs.viewfs.TestViewFsWithXAttrs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11274
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844990/HDFS-11274.05.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ca367cc429ca 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9ca54f4
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17975/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17975/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17975/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17975/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 13m 32s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 50s trunk passed +1 javadoc 0m 42s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 393 unchanged - 6 fixed = 402 total (was 399) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 52s the patch passed +1 javadoc 0m 44s the patch passed -1 unit 92m 12s hadoop-hdfs in the patch failed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 118m 4s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner Timed out junit tests org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs   org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool   org.apache.hadoop.hdfs.server.datanode.TestDataNodeExit   org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls   org.apache.hadoop.fs.viewfs.TestViewFsWithXAttrs Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11274 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844990/HDFS-11274.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ca367cc429ca 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9ca54f4 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17975/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17975/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17975/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17975/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Arpit Agarwal for the review. Upload patch v5 to address the comments.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Arpit Agarwal for the review. Upload patch v5 to address the comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
        +1 mvninstall 15m 53s trunk passed
        +1 compile 0m 52s trunk passed
        +1 checkstyle 0m 33s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 46s trunk passed
        +1 javadoc 0m 39s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        -0 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 18 new + 391 unchanged - 6 fixed = 409 total (was 397)
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 7s the patch passed
        -1 javadoc 0m 38s hadoop-hdfs-project_hadoop-hdfs generated 3 new + 7 unchanged - 0 fixed = 10 total (was 7)
        -1 unit 68m 53s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        97m 28s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache
          hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11274
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844873/HDFS-11274.04.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cd9c6940eba2 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 972da46
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17972/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/17972/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17972/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17972/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17972/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 15m 53s trunk passed +1 compile 0m 52s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 46s trunk passed +1 javadoc 0m 39s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed -0 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 18 new + 391 unchanged - 6 fixed = 409 total (was 397) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 7s the patch passed -1 javadoc 0m 38s hadoop-hdfs-project_hadoop-hdfs generated 3 new + 7 unchanged - 0 fixed = 10 total (was 7) -1 unit 68m 53s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 97m 28s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11274 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844873/HDFS-11274.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cd9c6940eba2 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 972da46 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17972/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/17972/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17972/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17972/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17972/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        The potential shutdown issue in saveDfsUsed is a nice find and fix!

        Regarding the new return value of AsyncChecker#schedule (also a nice find) - what do you think of just returning either a null or Optional<ListenableFuture<...>> if no disk check was scheduled? Otherwise, a couple of comments:

        1. The ThrottledAsyncChecker#ScheduleResult class can be static.
        2. There are a couple of unchecked assignments in ThrottledAsyncChecker#schedule (lines 110, 120 and 135).
        Show
        arpitagarwal Arpit Agarwal added a comment - The potential shutdown issue in saveDfsUsed is a nice find and fix! Regarding the new return value of AsyncChecker#schedule (also a nice find) - what do you think of just returning either a null or Optional<ListenableFuture<...>> if no disk check was scheduled? Otherwise, a couple of comments: The ThrottledAsyncChecker#ScheduleResult class can be static. There are a couple of unchecked assignments in ThrottledAsyncChecker#schedule (lines 110, 120 and 135).
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
        +1 mvninstall 13m 19s trunk passed
        +1 compile 0m 51s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 53s trunk passed
        +1 javadoc 0m 39s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        -0 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 391 unchanged - 6 fixed = 398 total (was 397)
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 53s the patch passed
        +1 javadoc 0m 37s the patch passed
        -1 unit 121m 15s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 34s The patch does not generate ASF License warnings.
        147m 7s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestModTime
          hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          hadoop.hdfs.server.datanode.checker.TestDatasetVolumeChecker
        Timed out junit tests org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeExit
          org.apache.hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls
          org.apache.hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes
          org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
          org.apache.hadoop.fs.viewfs.TestViewFileSystemWithXAttrs
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
          org.apache.hadoop.fs.viewfs.TestViewFsWithAcls
          org.apache.hadoop.fs.viewfs.TestViewFsWithXAttrs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11274
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844835/HDFS-11274.03.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux daf68da48981 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9262797
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17961/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17961/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17961/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17961/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 13m 19s trunk passed +1 compile 0m 51s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 0m 39s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed -0 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 391 unchanged - 6 fixed = 398 total (was 397) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 53s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 121m 15s hadoop-hdfs in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 147m 7s Reason Tests Failed junit tests hadoop.hdfs.TestModTime   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.datanode.checker.TestDatasetVolumeChecker Timed out junit tests org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs   org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool   org.apache.hadoop.hdfs.server.datanode.TestDataNodeExit   org.apache.hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls   org.apache.hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes   org.apache.hadoop.hdfs.server.namenode.TestCheckpoint   org.apache.hadoop.fs.viewfs.TestViewFileSystemWithXAttrs   org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration   org.apache.hadoop.fs.viewfs.TestViewFsWithAcls   org.apache.hadoop.fs.viewfs.TestViewFsWithXAttrs Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11274 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844835/HDFS-11274.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux daf68da48981 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9262797 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17961/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17961/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17961/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17961/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xyao Xiaoyu Yao added a comment - - edited

        Delta from patch 02:

        1. Add a ScheduleResult interface to get the ListenableFuture and whether a new target check is added to ThrottledAsyncChecker. This way, the async callback will be called once per scheduled check.

        2. Avoid cyclic volume check during volume check result handler, more specifically the BlockPoolSlice#saveDfsUsed() during volume shutdown.

        3. Fix the unit test as the volume failure counter can be larger due to the async volume check and the fact that min-check-gap is set as 0 during certain test.

        Show
        xyao Xiaoyu Yao added a comment - - edited Delta from patch 02: 1. Add a ScheduleResult interface to get the ListenableFuture and whether a new target check is added to ThrottledAsyncChecker. This way, the async callback will be called once per scheduled check. 2. Avoid cyclic volume check during volume check result handler, more specifically the BlockPoolSlice#saveDfsUsed() during volume shutdown. 3. Fix the unit test as the volume failure counter can be larger due to the async volume check and the fact that min-check-gap is set as 0 during certain test.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 14m 39s trunk passed
        +1 compile 0m 48s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 4s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 2m 4s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 55s the patch passed
        +1 compile 0m 51s the patch passed
        +1 javac 0m 51s the patch passed
        -0 checkstyle 0m 30s hadoop-hdfs-project/hadoop-hdfs: The patch generated 8 new + 376 unchanged - 1 fixed = 384 total (was 377)
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 2m 11s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 javadoc 0m 39s the patch passed
        -1 unit 76m 53s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        105m 15s



        Reason Tests
        FindBugs module:hadoop-hdfs-project/hadoop-hdfs
          Redundant nullcheck of cause, which is known to be non-null in org.apache.hadoop.hdfs.server.datanode.DataNode$DataTransfer.run() Redundant null check at DataNode.java:is known to be non-null in org.apache.hadoop.hdfs.server.datanode.DataNode$DataTransfer.run() Redundant null check at DataNode.java:[line 2466]
        Failed junit tests hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker
          hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
        Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11274
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844514/HDFS-11274.02.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 17db01be85b3 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 22befbd
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17943/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17943/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17943/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17943/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17943/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 14m 39s trunk passed +1 compile 0m 48s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 55s the patch passed +1 compile 0m 51s the patch passed +1 javac 0m 51s the patch passed -0 checkstyle 0m 30s hadoop-hdfs-project/hadoop-hdfs: The patch generated 8 new + 376 unchanged - 1 fixed = 384 total (was 377) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 2m 11s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 39s the patch passed -1 unit 76m 53s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 105m 15s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Redundant nullcheck of cause, which is known to be non-null in org.apache.hadoop.hdfs.server.datanode.DataNode$DataTransfer.run() Redundant null check at DataNode.java:is known to be non-null in org.apache.hadoop.hdfs.server.datanode.DataNode$DataTransfer.run() Redundant null check at DataNode.java: [line 2466] Failed junit tests hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11274 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844514/HDFS-11274.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 17db01be85b3 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 22befbd Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17943/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17943/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/17943/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17943/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17943/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 12m 43s trunk passed
        +1 compile 0m 46s trunk passed
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 0m 49s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 40s trunk passed
        +1 javadoc 0m 39s trunk passed
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        -0 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 8 new + 378 unchanged - 1 fixed = 386 total (was 379)
        +1 mvnsite 0m 47s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 1m 50s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 javadoc 0m 35s the patch passed
        -1 unit 62m 10s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        86m 37s



        Reason Tests
        FindBugs module:hadoop-hdfs-project/hadoop-hdfs
          Redundant nullcheck of cause, which is known to be non-null in org.apache.hadoop.hdfs.server.datanode.DataNode$DataTransfer.run() Redundant null check at DataNode.java:is known to be non-null in org.apache.hadoop.hdfs.server.datanode.DataNode$DataTransfer.run() Redundant null check at DataNode.java:[line 2466]
        Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11274
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844514/HDFS-11274.02.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4e8c2d77a261 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 22befbd
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17944/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17944/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17944/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17944/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17944/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 12m 43s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 0m 49s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 39s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 8 new + 378 unchanged - 1 fixed = 386 total (was 379) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 50s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 35s the patch passed -1 unit 62m 10s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 86m 37s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Redundant nullcheck of cause, which is known to be non-null in org.apache.hadoop.hdfs.server.datanode.DataNode$DataTransfer.run() Redundant null check at DataNode.java:is known to be non-null in org.apache.hadoop.hdfs.server.datanode.DataNode$DataTransfer.run() Redundant null check at DataNode.java: [line 2466] Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11274 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844514/HDFS-11274.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4e8c2d77a261 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 22befbd Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17944/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17944/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/17944/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17944/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17944/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 pending Jenkins.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 pending Jenkins.

          People

          • Assignee:
            xyao Xiaoyu Yao
            Reporter:
            xyao Xiaoyu Yao
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development