Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11204

Document the missing options of hdfs zkfc command

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the usage of the command hdfs zkfc -formatZK is not concrete. The introduction of parameters -force, -nonInteractive is missing in documentation and the help message. Actually, the function of these are very similar to namenode format. We should update these since it will let users know how to use this command easily.

        Activity

        Hide
        linyiqun Yiqun Lin added a comment - - edited

        Attach the patch. The new output infos:

        Usage: hdfs zkfc [ -formatZK [-force] [-nonInteractive] ]
        	-force: formats the znode if the znode exists.
        	-nonInteractive: formats the znode aborts if the znode exists,
        	unless -force option is specified.
        

        Thanks for the review.

        Show
        linyiqun Yiqun Lin added a comment - - edited Attach the patch. The new output infos: Usage: hdfs zkfc [ -formatZK [-force] [-nonInteractive] ] -force: formats the znode if the znode exists. -nonInteractive: formats the znode aborts if the znode exists, unless -force option is specified. Thanks for the review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 46s Maven dependency ordering for branch
        +1 mvninstall 8m 13s trunk passed
        +1 compile 11m 4s trunk passed
        +1 checkstyle 1m 43s trunk passed
        +1 mvnsite 2m 19s trunk passed
        +1 mvneclipse 0m 38s trunk passed
        -1 findbugs 2m 8s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings.
        +1 javadoc 1m 38s trunk passed
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 32s the patch passed
        +1 compile 11m 3s the patch passed
        +1 javac 11m 3s the patch passed
        +1 checkstyle 1m 42s the patch passed
        +1 mvnsite 2m 16s the patch passed
        +1 mvneclipse 0m 38s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 59s the patch passed
        +1 javadoc 1m 41s the patch passed
        +1 unit 8m 48s hadoop-common in the patch passed.
        -1 unit 71m 45s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 38s The patch does not generate ASF License warnings.
        135m 54s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.TestEncryptionZones
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11204
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841703/HDFS-11204.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5ad2197597fd 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f885160
        Default Java 1.8.0_111
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17755/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17755/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17755/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17755/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 46s Maven dependency ordering for branch +1 mvninstall 8m 13s trunk passed +1 compile 11m 4s trunk passed +1 checkstyle 1m 43s trunk passed +1 mvnsite 2m 19s trunk passed +1 mvneclipse 0m 38s trunk passed -1 findbugs 2m 8s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 38s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 32s the patch passed +1 compile 11m 3s the patch passed +1 javac 11m 3s the patch passed +1 checkstyle 1m 42s the patch passed +1 mvnsite 2m 16s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 59s the patch passed +1 javadoc 1m 41s the patch passed +1 unit 8m 48s hadoop-common in the patch passed. -1 unit 71m 45s hadoop-hdfs in the patch failed. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 135m 54s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestEncryptionZones   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11204 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841703/HDFS-11204.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5ad2197597fd 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f885160 Default Java 1.8.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17755/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/17755/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17755/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17755/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, checking this in.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, checking this in.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for the contribution!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for the contribution!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10996 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10996/)
        HDFS-11204. Document the missing options of hdfs zkfc command. (aajisaka: rev 72bff192cd37ff97442e0f8dd477fbc2e58fc12d)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ZKFailoverController.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10996 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10996/ ) HDFS-11204 . Document the missing options of hdfs zkfc command. (aajisaka: rev 72bff192cd37ff97442e0f8dd477fbc2e58fc12d) (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ZKFailoverController.java
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka for the review and commit.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for the review and commit.

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            linyiqun Yiqun Lin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development