Details

    • Bug
    • Status: Patch Available
    • Trivial
    • Resolution: Unresolved
    • 3.0.0-alpha1
    • None
    • None

    Description

      Found a set of spelling errors in the user-facing code.

      Examples are:

      odlest -> oldest
      Illagal -> Illegal
      bounday -> boundary

      Attachments

        1. HDFS-11201.1.patch
          12 kB
          Grant Sohn
        2. HDFS-11201.2.patch
          13 kB
          Grant Sohn
        3. HDFS-11201.3.patch
          13 kB
          Grant Sohn
        4. HDFS-11201.4.patch
          13 kB
          Grant Sohn

        Activity

          gsohn Grant Sohn added a comment -

          Fixes for the various spelling errors.

          gsohn Grant Sohn added a comment - Fixes for the various spelling errors.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 8m 36s trunk passed
          +1 compile 1m 43s trunk passed
          +1 checkstyle 0m 36s trunk passed
          +1 mvnsite 2m 30s trunk passed
          +1 mvneclipse 0m 51s trunk passed
          -1 findbugs 1m 48s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings.
          +1 javadoc 1m 35s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 2m 11s the patch passed
          +1 compile 1m 29s the patch passed
          +1 javac 1m 29s the patch passed
          -0 checkstyle 0m 39s hadoop-hdfs-project: The patch generated 1 new + 465 unchanged - 1 fixed = 466 total (was 466)
          +1 mvnsite 2m 11s the patch passed
          +1 mvneclipse 0m 45s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 27s the patch passed
          +1 javadoc 1m 18s the patch passed
          +1 unit 0m 53s hadoop-hdfs-client in the patch passed.
          -1 unit 95m 6s hadoop-hdfs in the patch failed.
          +1 unit 3m 20s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 1m 53s hadoop-hdfs-nfs in the patch passed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          136m 50s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
            hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.server.datanode.TestFsDatasetCache



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11201
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841662/HDFS-11201.1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f87b41f506b6 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / f885160
          Default Java 1.8.0_111
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17753/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17753/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17753/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17753/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17753/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 8m 36s trunk passed +1 compile 1m 43s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 2m 30s trunk passed +1 mvneclipse 0m 51s trunk passed -1 findbugs 1m 48s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 35s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 2m 11s the patch passed +1 compile 1m 29s the patch passed +1 javac 1m 29s the patch passed -0 checkstyle 0m 39s hadoop-hdfs-project: The patch generated 1 new + 465 unchanged - 1 fixed = 466 total (was 466) +1 mvnsite 2m 11s the patch passed +1 mvneclipse 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 27s the patch passed +1 javadoc 1m 18s the patch passed +1 unit 0m 53s hadoop-hdfs-client in the patch passed. -1 unit 95m 6s hadoop-hdfs in the patch failed. +1 unit 3m 20s hadoop-hdfs-httpfs in the patch passed. +1 unit 1m 53s hadoop-hdfs-nfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 136m 50s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.datanode.TestFsDatasetCache Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11201 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841662/HDFS-11201.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f87b41f506b6 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f885160 Default Java 1.8.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17753/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17753/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17753/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17753/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17753/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          gsohn Grant Sohn added a comment -

          The changes only fix spelling errors in strings. No new functionality was added.

          gsohn Grant Sohn added a comment - The changes only fix spelling errors in strings. No new functionality was added.

          +1. Thanks Grant Sohn for the patch!

          weichiu Wei-Chiu Chuang added a comment - +1. Thanks Grant Sohn for the patch!

          Reverting my patch at trunk. I should have verified the failed tests.
          Grant Sohn, one of the failed test is due to the changed exception message. Please also fix that as well.

          weichiu Wei-Chiu Chuang added a comment - Reverting my patch at trunk. I should have verified the failed tests. Grant Sohn , one of the failed test is due to the changed exception message. Please also fix that as well.
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10937 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10937/)
          HDFS-11201. Spelling errors in the logging, help, assertions and (weichiu: rev b9522e86a55564c2ccb5ca3f1ca871965cbe74de)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/OpenFileCtxCache.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/command/QueryCommand.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/LongBitFormat.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/server/ServerException.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10937 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10937/ ) HDFS-11201 . Spelling errors in the logging, help, assertions and (weichiu: rev b9522e86a55564c2ccb5ca3f1ca871965cbe74de) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/OpenFileCtxCache.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/command/QueryCommand.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/LongBitFormat.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/server/ServerException.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          gsohn Grant Sohn added a comment - - edited

          Thanks, Wei-Chiu Chuang. Did not consider this aspect when fixing the spelling errors. Will look at the tests and update the patch accordingly.

          gsohn Grant Sohn added a comment - - edited Thanks, Wei-Chiu Chuang . Did not consider this aspect when fixing the spelling errors. Will look at the tests and update the patch accordingly.
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10938 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10938/)
          Revert "HDFS-11201. Spelling errors in the logging, help, assertions and (weichiu: rev 1b5cceaffbdde50a87ede81552dc380832db8e79)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/LongBitFormat.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/OpenFileCtxCache.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/server/ServerException.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/command/QueryCommand.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10938 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10938/ ) Revert " HDFS-11201 . Spelling errors in the logging, help, assertions and (weichiu: rev 1b5cceaffbdde50a87ede81552dc380832db8e79) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/LongBitFormat.java (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/OpenFileCtxCache.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/server/ServerException.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/command/QueryCommand.java
          gsohn Grant Sohn added a comment -

          Addressed misspelling in test.

          gsohn Grant Sohn added a comment - Addressed misspelling in test.
          gsohn Grant Sohn added a comment -

          Test org.apache.hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality.testChooseDatanodeBeforeNamesystemInit was affected by my changes. The other test failures don't seem to be related to fixing the spelling errors.

          gsohn Grant Sohn added a comment - Test org.apache.hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality.testChooseDatanodeBeforeNamesystemInit was affected by my changes. The other test failures don't seem to be related to fixing the spelling errors.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 8m 22s trunk passed
          +1 compile 1m 40s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 2m 28s trunk passed
          +1 mvneclipse 0m 56s trunk passed
          -1 findbugs 1m 56s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings.
          +1 javadoc 1m 32s trunk passed
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 2m 38s the patch passed
          +1 compile 1m 48s the patch passed
          +1 javac 1m 48s the patch passed
          -0 checkstyle 0m 40s hadoop-hdfs-project: The patch generated 1 new + 476 unchanged - 1 fixed = 477 total (was 477)
          +1 mvnsite 2m 37s the patch passed
          +1 mvneclipse 0m 49s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 5m 27s the patch passed
          +1 javadoc 1m 33s the patch passed
          +1 unit 1m 7s hadoop-hdfs-client in the patch passed.
          -1 unit 79m 37s hadoop-hdfs in the patch failed.
          +1 unit 3m 55s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 1m 51s hadoop-hdfs-nfs in the patch passed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          125m 24s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11201
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841795/HDFS-11201.2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 68ed45b1f688 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 43ebff2
          Default Java 1.8.0_111
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17760/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17760/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17760/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17760/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17760/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 8m 22s trunk passed +1 compile 1m 40s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 2m 28s trunk passed +1 mvneclipse 0m 56s trunk passed -1 findbugs 1m 56s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 32s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 2m 38s the patch passed +1 compile 1m 48s the patch passed +1 javac 1m 48s the patch passed -0 checkstyle 0m 40s hadoop-hdfs-project: The patch generated 1 new + 476 unchanged - 1 fixed = 477 total (was 477) +1 mvnsite 2m 37s the patch passed +1 mvneclipse 0m 49s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 27s the patch passed +1 javadoc 1m 33s the patch passed +1 unit 1m 7s hadoop-hdfs-client in the patch passed. -1 unit 79m 37s hadoop-hdfs in the patch failed. +1 unit 3m 55s hadoop-hdfs-httpfs in the patch passed. +1 unit 1m 51s hadoop-hdfs-nfs in the patch passed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 125m 24s Reason Tests Failed junit tests hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11201 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841795/HDFS-11201.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 68ed45b1f688 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 43ebff2 Default Java 1.8.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17760/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17760/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17760/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17760/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17760/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          gsohn Grant Sohn added a comment -

          Had to rebase. Corrected diff.

          gsohn Grant Sohn added a comment - Had to rebase. Corrected diff.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 7s Maven dependency ordering for branch
          +1 mvninstall 8m 47s trunk passed
          +1 compile 1m 42s trunk passed
          +1 checkstyle 0m 39s trunk passed
          +1 mvnsite 2m 53s trunk passed
          +1 mvneclipse 0m 54s trunk passed
          +1 findbugs 4m 39s trunk passed
          +1 javadoc 1m 33s trunk passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 2m 33s the patch passed
          +1 compile 1m 28s the patch passed
          +1 javac 1m 28s the patch passed
          -0 checkstyle 0m 35s hadoop-hdfs-project: The patch generated 1 new + 476 unchanged - 1 fixed = 477 total (was 477)
          +1 mvnsite 2m 13s the patch passed
          +1 mvneclipse 0m 44s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 5m 17s the patch passed
          +1 javadoc 1m 31s the patch passed
          +1 unit 1m 5s hadoop-hdfs-client in the patch passed.
          -1 unit 76m 48s hadoop-hdfs in the patch failed.
          +1 unit 4m 10s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 2m 4s hadoop-hdfs-nfs in the patch passed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          122m 30s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.TestStartup



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11201
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841830/HDFS-11201.3.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0eb08c47584d 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dcedb72
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17765/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17765/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17765/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17765/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 8m 47s trunk passed +1 compile 1m 42s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 2m 53s trunk passed +1 mvneclipse 0m 54s trunk passed +1 findbugs 4m 39s trunk passed +1 javadoc 1m 33s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 2m 33s the patch passed +1 compile 1m 28s the patch passed +1 javac 1m 28s the patch passed -0 checkstyle 0m 35s hadoop-hdfs-project: The patch generated 1 new + 476 unchanged - 1 fixed = 477 total (was 477) +1 mvnsite 2m 13s the patch passed +1 mvneclipse 0m 44s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 17s the patch passed +1 javadoc 1m 31s the patch passed +1 unit 1m 5s hadoop-hdfs-client in the patch passed. -1 unit 76m 48s hadoop-hdfs in the patch failed. +1 unit 4m 10s hadoop-hdfs-httpfs in the patch passed. +1 unit 2m 4s hadoop-hdfs-nfs in the patch passed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 122m 30s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestStartup Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11201 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841830/HDFS-11201.3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0eb08c47584d 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dcedb72 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17765/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17765/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17765/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17765/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          gsohn Grant Sohn added a comment -

          Fixed style issues.

          gsohn Grant Sohn added a comment - Fixed style issues.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 7s Maven dependency ordering for branch
          +1 mvninstall 12m 33s trunk passed
          +1 compile 1m 20s trunk passed
          +1 checkstyle 0m 35s trunk passed
          +1 mvnsite 2m 2s trunk passed
          +1 mvneclipse 0m 49s trunk passed
          +1 findbugs 3m 53s trunk passed
          +1 javadoc 1m 25s trunk passed
          0 mvndep 0m 6s Maven dependency ordering for patch
          +1 mvninstall 1m 59s the patch passed
          +1 compile 1m 18s the patch passed
          +1 javac 1m 18s the patch passed
          +1 checkstyle 0m 32s hadoop-hdfs-project: The patch generated 0 new + 475 unchanged - 1 fixed = 475 total (was 476)
          +1 mvnsite 1m 52s the patch passed
          +1 mvneclipse 0m 40s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 17s the patch passed
          +1 javadoc 1m 14s the patch passed
          +1 unit 0m 54s hadoop-hdfs-client in the patch passed.
          -1 unit 64m 14s hadoop-hdfs in the patch failed.
          +1 unit 3m 5s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 1m 45s hadoop-hdfs-nfs in the patch passed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          106m 50s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestCrcCorruption



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11201
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843481/HDFS-11201.4.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 37f59070edc5 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 631f1da
          Default Java 1.8.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17871/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17871/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17871/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 12m 33s trunk passed +1 compile 1m 20s trunk passed +1 checkstyle 0m 35s trunk passed +1 mvnsite 2m 2s trunk passed +1 mvneclipse 0m 49s trunk passed +1 findbugs 3m 53s trunk passed +1 javadoc 1m 25s trunk passed 0 mvndep 0m 6s Maven dependency ordering for patch +1 mvninstall 1m 59s the patch passed +1 compile 1m 18s the patch passed +1 javac 1m 18s the patch passed +1 checkstyle 0m 32s hadoop-hdfs-project: The patch generated 0 new + 475 unchanged - 1 fixed = 475 total (was 476) +1 mvnsite 1m 52s the patch passed +1 mvneclipse 0m 40s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 17s the patch passed +1 javadoc 1m 14s the patch passed +1 unit 0m 54s hadoop-hdfs-client in the patch passed. -1 unit 64m 14s hadoop-hdfs in the patch failed. +1 unit 3m 5s hadoop-hdfs-httpfs in the patch passed. +1 unit 1m 45s hadoop-hdfs-nfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 106m 50s Reason Tests Failed junit tests hadoop.hdfs.TestCrcCorruption Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11201 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843481/HDFS-11201.4.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 37f59070edc5 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 631f1da Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17871/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17871/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17871/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          jzhuge John Zhuge added a comment -

          Hi Grant Sohn, Yongjun Zhang added you as a contributor to HDFS. Now we can assign this JIRA to you since you have been working on it.

          jzhuge John Zhuge added a comment - Hi Grant Sohn , Yongjun Zhang added you as a contributor to HDFS. Now we can assign this JIRA to you since you have been working on it.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 8s HDFS-11201 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 8s HDFS-11201 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-11201 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843481/HDFS-11201.4.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18815/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          hanishakoneru Hanisha Koneru added a comment -

          Grant Sohn, the patch LGTM.

          Also, there are a few more typo's that I have come across. Listing them here in case you want to include them also in this fix.

          • ZKDelegationTokenSecretManager#ZK_DTSM_ZNODE_WORKING_PATH_DEAFULT
          • TestINodeAttributeProvider#getExternalAccessControlEnforcer(AccessControlEnforcer deafultEnforcer)
          • hdfs-default.xml#dfs.namenode.decommission.max.concurrent.tracked.nodes description containes datnode
          hanishakoneru Hanisha Koneru added a comment - Grant Sohn , the patch LGTM. Also, there are a few more typo's that I have come across. Listing them here in case you want to include them also in this fix. ZKDelegationTokenSecretManager#ZK_DTSM_ZNODE_WORKING_PATH_ DEAFULT TestINodeAttributeProvider#getExternalAccessControlEnforcer(AccessControlEnforcer deafultEnforcer ) hdfs-default.xml#dfs.namenode.decommission.max.concurrent.tracked.nodes description containes datnode
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HDFS-11201 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HDFS-11201 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-11201 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843481/HDFS-11201.4.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20189/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 6s HDFS-11201 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s HDFS-11201 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-11201 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843481/HDFS-11201.4.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21511/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          genericqa genericqa added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 5s HDFS-11201 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          This message was automatically generated.

          genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HDFS-11201 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-11201 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843481/HDFS-11201.4.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/22388/console Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          elgoiri Íñigo Goiri added a comment - - edited

          It looks like this was committed at some point and then reverted here.
          Wei-Chiu Chuang what is the story here?

          elgoiri Íñigo Goiri added a comment - - edited It looks like this was committed at some point and then reverted here . Wei-Chiu Chuang what is the story here?
          genericqa genericqa added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 6s HDFS-11201 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          This message was automatically generated.

          genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s HDFS-11201 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-11201 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843481/HDFS-11201.4.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/23676/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          ajayydv Ajay Kumar added a comment - - edited

          Grant Sohn Patch doesn't apply to trunk anymore, mind rebasing the patch?

          ajayydv Ajay Kumar added a comment - - edited Grant Sohn Patch doesn't apply to trunk anymore, mind rebasing the patch?

          People

            gsohn Grant Sohn
            gsohn Grant Sohn

            Dates

              Created:
              Updated:

              Slack