Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11198

NN UI should link DN web address using hostnames

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The new NN UI shows links to DN web pages, but since the link is from the info address returned from jmx, it is in the IP address:port form. This breaks if users are using filters utilizing cookies.

      Since this is a new feature in 2.8, I didn't mark it as a blocker. I.e. it does not break any existing functions. It just doesn't work properly in certain environments.

      1. HDFS-11198.02.patch
        2 kB
        Weiwei Yang
      2. HDFS-11198.01.patch
        2 kB
        Weiwei Yang

        Issue Links

          Activity

          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Kihwal Lee

          I think I added DN links in HDFS-10493, I can work on this one if you don't mind.

          Show
          cheersyang Weiwei Yang added a comment - Hello Kihwal Lee I think I added DN links in HDFS-10493 , I can work on this one if you don't mind.
          Hide
          kihwal Kihwal Lee added a comment -

          sure go ahead.

          Show
          kihwal Kihwal Lee added a comment - sure go ahead.
          Hide
          kihwal Kihwal Lee added a comment -

          The build master is down at this moment.

          Show
          kihwal Kihwal Lee added a comment - The build master is down at this moment.
          Hide
          cheersyang Weiwei Yang added a comment -

          Thanks Kihwal Lee. I was waiting on the jenkins job result, I have tested the patch locally, both non-secure and secure setup worked fine. Will trigger a jenkins job later when the server comes back.

          Show
          cheersyang Weiwei Yang added a comment - Thanks Kihwal Lee . I was waiting on the jenkins job result, I have tested the patch locally, both non-secure and secure setup worked fine. Will trigger a jenkins job later when the server comes back.
          Hide
          cheersyang Weiwei Yang added a comment -

          Upload the patch again to trigger the jenkins job, v2 file is just a copy of v1 patch. I tried to "Cancel Patch" then "Submit Patch" over again but it did not trigger the job somehow.

          Show
          cheersyang Weiwei Yang added a comment - Upload the patch again to trigger the jenkins job, v2 file is just a copy of v1 patch. I tried to "Cancel Patch" then "Submit Patch" over again but it did not trigger the job somehow.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          0m 43s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11198
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841892/HDFS-11198.02.patch
          Optional Tests asflicense
          uname Linux 6e361f8ed188 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b2a3d6c
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17771/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 0m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11198 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841892/HDFS-11198.02.patch Optional Tests asflicense uname Linux 6e361f8ed188 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b2a3d6c modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17771/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          +1

          Show
          kihwal Kihwal Lee added a comment - +1
          Hide
          kihwal Kihwal Lee added a comment -

          I've committed this to trunk through branch-2.8. Thanks for working on this, Weiwei Yang.

          Show
          kihwal Kihwal Lee added a comment - I've committed this to trunk through branch-2.8. Thanks for working on this, Weiwei Yang .
          Hide
          cheersyang Weiwei Yang added a comment -

          Thanks Kihwal Lee

          Show
          cheersyang Weiwei Yang added a comment - Thanks Kihwal Lee
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10948 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10948/)
          HDFS-11198. NN UI should link DN web address using hostnames. (kihwal: rev 4dd4f3a4bb483795e8669ec34d3efcd6c1b8b465)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10948 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10948/ ) HDFS-11198 . NN UI should link DN web address using hostnames. (kihwal: rev 4dd4f3a4bb483795e8669ec34d3efcd6c1b8b465) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks for the contributions Weiwei Yang and Kihwal Lee. I added a link to HDFS-10440.

          Show
          xiaochen Xiao Chen added a comment - Thanks for the contributions Weiwei Yang and Kihwal Lee . I added a link to HDFS-10440 .
          Hide
          yzhangal Yongjun Zhang added a comment - - edited

          HI Xiao Chen,

          Per offline discussion, it seems HDFS-11198 breaks "NameNode UI Datanodes tab" which is fixed by HDFS-10440, in that case, we can make the link "broke" instead of just "related to".

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - - edited HI Xiao Chen , Per offline discussion, it seems HDFS-11198 breaks "NameNode UI Datanodes tab" which is fixed by HDFS-10440 , in that case, we can make the link "broke" instead of just "related to". Thanks.
          Hide
          xiaochen Xiao Chen added a comment -

          Re-added the link as 'is broken by' HDFS-10440 per Yongjun suggested. Thanks.

          Show
          xiaochen Xiao Chen added a comment - Re-added the link as 'is broken by' HDFS-10440 per Yongjun suggested. Thanks.

            People

            • Assignee:
              cheersyang Weiwei Yang
              Reporter:
              kihwal Kihwal Lee
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development