Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: rolling upgrades
    • Labels:
      None

      Description

      This is the inverse of HDFS-10398 and HADOOP-13142. Currently, trunk requires a software DN and NN version of 3.0.0-alpha1. This means we cannot perform a rolling upgrade from 2.x to 3.x.

      The first step towards supporting rolling upgrade is changing these back to a 2.x version. For reference, branch-2 has these versions set to "2.1.0-beta".

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        Patch attached. I grepped the java sources for "3.0.0" and found these tests which I ran locally (passed):

        -> % mvn test -Dtest=TestDatanodeRegistration,TestDatanodeRegister,TestPBHelper
        
        Show
        andrew.wang Andrew Wang added a comment - Patch attached. I grepped the java sources for "3.0.0" and found these tests which I ran locally (passed): -> % mvn test -Dtest=TestDatanodeRegistration,TestDatanodeRegister,TestPBHelper
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 55s trunk passed
        +1 compile 0m 54s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 4s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 56s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 53s the patch passed
        +1 compile 0m 49s the patch passed
        +1 javac 0m 49s the patch passed
        -0 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 397 unchanged - 2 fixed = 399 total (was 399)
        +1 mvnsite 0m 57s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 2s the patch passed
        +1 javadoc 0m 38s the patch passed
        +1 unit 71m 21s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        92m 38s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11188
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840969/HDFS-11188.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ed6018ed3c13 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8f6e143
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17707/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17707/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17707/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 55s trunk passed +1 compile 0m 54s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 53s the patch passed +1 compile 0m 49s the patch passed +1 javac 0m 49s the patch passed -0 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 397 unchanged - 2 fixed = 399 total (was 399) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 2s the patch passed +1 javadoc 0m 38s the patch passed +1 unit 71m 21s hadoop-hdfs in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 92m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11188 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840969/HDFS-11188.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ed6018ed3c13 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8f6e143 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17707/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17707/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17707/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Checkstyle looks ignorable, ready for review.

        Show
        andrew.wang Andrew Wang added a comment - Checkstyle looks ignorable, ready for review.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Hi Andrew Wang,

        Thanks for working on.

        The 2.1.0-beta was set by https://issues.apache.org/jira/browse/HDFS-5083. Are we sure we can upgrade from 2.1.0-beta to 3.0?

        Hi Kihwal Lee, would you please comment since you worked out HDFS-5083?

        Thanks.

        Show
        yzhangal Yongjun Zhang added a comment - Hi Andrew Wang , Thanks for working on. The 2.1.0-beta was set by https://issues.apache.org/jira/browse/HDFS-5083 . Are we sure we can upgrade from 2.1.0-beta to 3.0? Hi Kihwal Lee , would you please comment since you worked out HDFS-5083 ? Thanks.
        Hide
        andrew.wang Andrew Wang added a comment -

        Hi Yongjun, this is just setting the min software version back to the same settings as in branch-2. This will allow rolling upgrades from 2.x releases to 3.x releases.

        We could consider setting this to a slightly higher 2.x version like 2.4.0 (I think that's when we started supporting rolling upgrade), but it seems okay to be more permissive in this case.

        Show
        andrew.wang Andrew Wang added a comment - Hi Yongjun, this is just setting the min software version back to the same settings as in branch-2. This will allow rolling upgrades from 2.x releases to 3.x releases. We could consider setting this to a slightly higher 2.x version like 2.4.0 (I think that's when we started supporting rolling upgrade), but it seems okay to be more permissive in this case.
        Hide
        andrew.wang Andrew Wang added a comment -

        To further elaborate, I haven't done any rolling upgrade testing yet, but we need this patch to unblock it.

        Show
        andrew.wang Andrew Wang added a comment - To further elaborate, I haven't done any rolling upgrade testing yet, but we need this patch to unblock it.
        Hide
        andrew.wang Andrew Wang added a comment -

        Hi Yongjun Zhang could I get a re-review?

        Show
        andrew.wang Andrew Wang added a comment - Hi Yongjun Zhang could I get a re-review?
        Hide
        xiaochen Xiao Chen added a comment -

        The change and the discussion on more permissive makes sense to me. +1, committing this.

        Show
        xiaochen Xiao Chen added a comment - The change and the discussion on more permissive makes sense to me. +1, committing this.
        Hide
        xiaochen Xiao Chen added a comment - - edited

        No more tests needed since we already have coverage. I'm assuming (jenkins results are gone) checkstyle is 80-char so okay too.
        Committed to trunk, thanks Andrew!

        Show
        xiaochen Xiao Chen added a comment - - edited No more tests needed since we already have coverage. I'm assuming (jenkins results are gone) checkstyle is 80-char so okay too. Committed to trunk, thanks Andrew!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11006 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11006/)
        HDFS-11188. Change min supported DN and NN versions back to 2.x. (xiao: rev cee0c468b0ebe2ae8727502620e345745ba11f77)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11006 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11006/ ) HDFS-11188 . Change min supported DN and NN versions back to 2.x. (xiao: rev cee0c468b0ebe2ae8727502620e345745ba11f77) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java

          People

          • Assignee:
            andrew.wang Andrew Wang
            Reporter:
            andrew.wang Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development