Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The test TestAddStripedBlockInFBR#testAddBlockInFullBlockReport fails easily in trunk. It's easy to reproduce the failure, it fails 2~3 times when I run the test 4~-5 times in my local. Also it failed in the recent Jenkins(https://builds.apache.org/job/PreCommit-HDFS-Build/17667/testReport/), The stack infos:

      java.lang.AssertionError: expected:<9> but was:<7>
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.junit.Assert.failNotEquals(Assert.java:743)
      	at org.junit.Assert.assertEquals(Assert.java:118)
      	at org.junit.Assert.assertEquals(Assert.java:555)
      	at org.junit.Assert.assertEquals(Assert.java:542)
      	at org.apache.hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR.testAddBlockInFullBlockReport(TestAddStripedBlockInFBR.java:108)
      

      It's easy to have a fix: Use GenericTestUtils.waitFor to wait the full blocks being reported.

      1. HDFS-11178.001.patch
        2 kB
        Yiqun Lin
      2. HDFS-11178.002.patch
        3 kB
        Yiqun Lin
      3. HDFS-11178.003.patch
        3 kB
        Yiqun Lin

        Activity

        Hide
        linyiqun Yiqun Lin added a comment -

        Attach a patch to have a fix. Could you have a look Brahma Reddy Battula, .

        Show
        linyiqun Yiqun Lin added a comment - Attach a patch to have a fix. Could you have a look Brahma Reddy Battula , .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 20s trunk passed
        +1 compile 0m 52s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 58s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 44s trunk passed
        +1 javadoc 0m 45s trunk passed
        +1 mvninstall 0m 51s the patch passed
        +1 compile 0m 47s the patch passed
        +1 javac 0m 47s the patch passed
        -0 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
        +1 mvnsite 0m 54s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 48s the patch passed
        +1 javadoc 0m 39s the patch passed
        -1 unit 94m 6s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        114m 2s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11178
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840581/HDFS-11178.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 33a6b408af78 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 07825f2
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17668/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17668/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17668/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17668/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 20s trunk passed +1 compile 0m 52s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 51s the patch passed +1 compile 0m 47s the patch passed +1 javac 0m 47s the patch passed -0 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 94m 6s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 114m 2s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11178 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840581/HDFS-11178.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 33a6b408af78 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 07825f2 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17668/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17668/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17668/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17668/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        Yiqun Lin thanks for pinging me.

        Following can trigger only one DN..

            // trigger dn's FBR. The FBR will add block-dn mapping.
            DataNodeTestUtils.triggerBlockReport(dn);
        

        your approach looks fine for me. i.e replace with cluster.triggerBlockReports(); which will trigger on all DN's and using GenericTestUtils.waitFor.

        pinging Kai Zheng/SammiChen as they worked on HDFS-11117.

        Minor Nits:
        1) can we add assertion inside public Boolean get() itself ,such that we remove following which is already there..?

        // make sure NN has correct block-dn mapping
          BlockInfoStriped blockInfo = (BlockInfoStriped) cluster.getNamesystem()
                .getFSDirectory().getINode(ecFile.toString()).asFile().getLastBlock();
            NumberReplicas nr = spy.countNodes(blockInfo);
            Assert.assertEquals(groupSize, nr.liveReplicas());
            Assert.assertEquals(0, nr.excessReplicas());
        

        2) can you remove unused import import org.apache.hadoop.hdfs.DFSTestUtil;..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited Yiqun Lin thanks for pinging me. Following can trigger only one DN.. // trigger dn's FBR. The FBR will add block-dn mapping. DataNodeTestUtils.triggerBlockReport(dn); your approach looks fine for me. i.e replace with cluster.triggerBlockReports(); which will trigger on all DN's and using GenericTestUtils.waitFor . pinging Kai Zheng / SammiChen as they worked on HDFS-11117 . Minor Nits: 1) can we add assertion inside public Boolean get() itself ,such that we remove following which is already there..? // make sure NN has correct block-dn mapping BlockInfoStriped blockInfo = (BlockInfoStriped) cluster.getNamesystem() .getFSDirectory().getINode(ecFile.toString()).asFile().getLastBlock(); NumberReplicas nr = spy.countNodes(blockInfo); Assert.assertEquals(groupSize, nr.liveReplicas()); Assert.assertEquals(0, nr.excessReplicas()); 2) can you remove unused import import org.apache.hadoop.hdfs.DFSTestUtil; ..?
        Hide
        tasanuma0829 Takanobu Asanuma added a comment -

        Hi Yiqun Lin thanks for working on this and Brahma Reddy Battula for the review.

        I have looked into HDFS-10858 deeply. This patch looks good to me, and to do further refactoring by Brahma Reddy Battula also sounds good to me. (non-binding)

        Show
        tasanuma0829 Takanobu Asanuma added a comment - Hi Yiqun Lin thanks for working on this and Brahma Reddy Battula for the review. I have looked into HDFS-10858 deeply. This patch looks good to me, and to do further refactoring by Brahma Reddy Battula also sounds good to me. (non-binding)
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Brahma Reddy Battula and Takanobu Asanuma for the review. The comments look good to me. Post a new patch to address the comments.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Brahma Reddy Battula and Takanobu Asanuma for the review. The comments look good to me. Post a new patch to address the comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 26s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 41s trunk passed
        +1 javadoc 0m 40s trunk passed
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 44s the patch passed
        +1 javac 0m 44s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 48s the patch passed
        +1 javadoc 0m 39s the patch passed
        -1 unit 108m 47s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 25s The patch does not generate ASF License warnings.
        128m 30s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11178
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840609/HDFS-11178.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6c9fd0c3cf6e 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 209e805
        Default Java 1.8.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17671/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17671/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17671/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 26s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 41s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 0m 44s the patch passed +1 javac 0m 44s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 108m 47s hadoop-hdfs in the patch failed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 128m 30s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestDirectoryScanner Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11178 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840609/HDFS-11178.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6c9fd0c3cf6e 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 209e805 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17671/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17671/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17671/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        Is MiniDFSCluster#triggerBlockReports() blocking call? If so can we simply trigger full block reports on all DNs instead of DN0?

        Show
        liuml07 Mingliang Liu added a comment - Is MiniDFSCluster#triggerBlockReports() blocking call? If so can we simply trigger full block reports on all DNs instead of DN0?
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Mingliang Liu for taking a look.

        Is MiniDFSCluster#triggerBlockReports() blocking call?

        No, I think it's not a blocking call. MiniDFSCluster#triggerBlockReports() just traverse the DNs in cluster, and do the DataNodeTestUtils.triggerBlockReport(dn); for each DN, while DataNodeTestUtils.triggerBlockReport(dn) is a non-blocking call.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Mingliang Liu for taking a look. Is MiniDFSCluster#triggerBlockReports() blocking call? No, I think it's not a blocking call. MiniDFSCluster#triggerBlockReports() just traverse the DNs in cluster, and do the DataNodeTestUtils.triggerBlockReport(dn); for each DN, while DataNodeTestUtils.triggerBlockReport(dn) is a non-blocking call.
        Hide
        linyiqun Yiqun Lin added a comment -

        Hi Brahma Reddy Battula, I think we can hold on the commit these two days in case there are some further comments. What do you think?

        Show
        linyiqun Yiqun Lin added a comment - Hi Brahma Reddy Battula , I think we can hold on the commit these two days in case there are some further comments. What do you think?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Yiqun Lin thanks for updating patch and reminding me.

        I am thinking little cleaner way like following such that we can avoid if (groupSize == nr.liveReplicas())

        public Boolean get() {
                try {
                  // trigger dn's FBR. The FBR will add block-dn mapping.
                  cluster.triggerBlockReports();
        
                  // make sure NN has correct block-dn mapping
                  BlockInfoStriped blockInfo = (BlockInfoStriped) cluster
                      .getNamesystem().getFSDirectory().getINode(ecFile.toString())
                      .asFile().getLastBlock();
                  NumberReplicas nr = spy.countNodes(blockInfo);
                  return nr.excessReplicas() == 0 && nr.liveReplicas() == groupSize;
                } catch (Exception ignored) {
                  // Ignore the exception
                  return false;
                }
              }
            }, 3000, 60000);
          }
        

        we can remove import org.junit.Assert; after above modification.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Yiqun Lin thanks for updating patch and reminding me. I am thinking little cleaner way like following such that we can avoid if (groupSize == nr.liveReplicas()) public Boolean get() { try { // trigger dn's FBR. The FBR will add block-dn mapping. cluster.triggerBlockReports(); // make sure NN has correct block-dn mapping BlockInfoStriped blockInfo = (BlockInfoStriped) cluster .getNamesystem().getFSDirectory().getINode(ecFile.toString()) .asFile().getLastBlock(); NumberReplicas nr = spy.countNodes(blockInfo); return nr.excessReplicas() == 0 && nr.liveReplicas() == groupSize; } catch (Exception ignored) { // Ignore the exception return false ; } } }, 3000, 60000); } we can remove import org.junit.Assert; after above modification.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Brahma Reddy Battula for the review. The comment make sense for me. New patch attached.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Brahma Reddy Battula for the review. The comment make sense for me. New patch attached.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 9m 15s trunk passed
        +1 compile 0m 46s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        -1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings.
        +1 javadoc 0m 38s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 44s the patch passed
        +1 javadoc 0m 36s the patch passed
        +1 unit 60m 37s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        81m 33s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11178
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841214/HDFS-11178.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d348f7d12624 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1f7613b
        Default Java 1.8.0_111
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17724/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17724/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17724/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 15s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 14s trunk passed -1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 38s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 44s the patch passed +1 javadoc 0m 36s the patch passed +1 unit 60m 37s hadoop-hdfs in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 81m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11178 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841214/HDFS-11178.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d348f7d12624 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1f7613b Default Java 1.8.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17724/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17724/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17724/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        Yiqun Lin thanks for updating patch.LGTM..findbugs related to HDFS-10930,I already commented there.

        will commit this weekend if there is no comments from Mingliang Liu Or somebody.

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited Yiqun Lin thanks for updating patch.LGTM.. findbugs related to HDFS-10930 ,I already commented there. will commit this weekend if there is no comments from Mingliang Liu Or somebody.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Mingliang Liu do you comments on latest patch..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Mingliang Liu do you comments on latest patch..?
        Hide
        liuml07 Mingliang Liu added a comment -

        Sorry I'm not actively reviewing this patch. Please go ahead with this patch if it looks good to you. I was just asking the general question about triggering block report in test as I glimpsed the ibrManager was waiting. Thanks.

        Show
        liuml07 Mingliang Liu added a comment - Sorry I'm not actively reviewing this patch. Please go ahead with this patch if it looks good to you. I was just asking the general question about triggering block report in test as I glimpsed the ibrManager was waiting. Thanks.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Committed to trunk.Yiqun Hu thanks for your contribution and thanks to Takanobu Asanuma for your great review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Committed to trunk. Yiqun Hu thanks for your contribution and thanks to Takanobu Asanuma for your great review..
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10949 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10949/)
        HDFS-11178. TestAddStripedBlockInFBR#testAddBlockInFullBlockReport fails (brahma: rev ed89856755fd20e814d3ba58e2c183a85a9389d3)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddStripedBlockInFBR.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10949 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10949/ ) HDFS-11178 . TestAddStripedBlockInFBR#testAddBlockInFullBlockReport fails (brahma: rev ed89856755fd20e814d3ba58e2c183a85a9389d3) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddStripedBlockInFBR.java
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Brahma Reddy Battula for the commit.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Brahma Reddy Battula for the commit.

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            linyiqun Yiqun Lin
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development