Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11175

Document uppercase key names are not supported in TransparentEncryption.md

    Details

    • Hadoop Flags:
      Reviewed

      Description

      After HADOOP-11311, key names has been restricted and uppercase key names are not allowed. This section of TransparentEncryption.md should be modified.

      1. As the normal user, create a new encryption key
        hadoop key create myKey
      1. As the super user, create a new empty directory and make it an encryption zone
        hadoop fs -mkdir /zone
        hdfs crypto -createZone -keyName myKey -path /zone
      1. chown it to the normal user
        hadoop fs -chown myuser:myuser /zone
      1. As the normal user, put a file in, read it out
        hadoop fs -put helloWorld /zone
        hadoop fs -cat /zone/helloWorld

      "myKey" is not allowed here.

        Activity

        Hide
        linyiqun Yiqun Lin added a comment - - edited

        It's a good catch, thanks Yuanbo Liu for reporting this. One comment from me: I'm sure here the myKey has been updated to the mykey.The documenttion in trunk:

            # As the normal user, create a new encryption key
            hadoop key create mykey
        
            # As the super user, create a new empty directory and make it an encryption zone
            hadoop fs -mkdir /zone
            hdfs crypto -createZone -keyName mykey -path /zone
        

        I think we can make a change in the introduction of param keyName. Attach a patch. Correct me if I am wrong. Thanks.

        Show
        linyiqun Yiqun Lin added a comment - - edited It's a good catch, thanks Yuanbo Liu for reporting this. One comment from me: I'm sure here the myKey has been updated to the mykey .The documenttion in trunk: # As the normal user, create a new encryption key hadoop key create mykey # As the super user, create a new empty directory and make it an encryption zone hadoop fs -mkdir /zone hdfs crypto -createZone -keyName mykey -path /zone I think we can make a change in the introduction of param keyName . Attach a patch. Correct me if I am wrong. Thanks.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvninstall 7m 30s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvnsite 0m 52s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        10m 33s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11175
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840468/HDFS-11175.001.patch
        Optional Tests asflicense mvnsite
        uname Linux 90bd802d8e59 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 01665e4
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17662/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvninstall 7m 30s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvnsite 0m 52s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 10m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11175 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840468/HDFS-11175.001.patch Optional Tests asflicense mvnsite uname Linux 90bd802d8e59 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 01665e4 modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17662/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Yiqun Lin Thanks for your reminder.
        I'm +1(no-binding) for your patch.

        Show
        yuanbo Yuanbo Liu added a comment - Yiqun Lin Thanks for your reminder. I'm +1(no-binding) for your patch.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Andrew Wang
        Sorry to interrupt. Would you mind taking a look at the patch?
        I think adding the unsupported declaration will help users choose the right key name.

        Show
        yuanbo Yuanbo Liu added a comment - Andrew Wang Sorry to interrupt. Would you mind taking a look at the patch? I think adding the unsupported declaration will help users choose the right key name.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1.

        I'm sure here the myKey has been updated to the mykey.

        Yes. Fixed by HDFS-9784.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1. I'm sure here the myKey has been updated to the mykey. Yes. Fixed by HDFS-9784 .
        Hide
        yuanbo Yuanbo Liu added a comment -

        Akira Ajisaka Thanks for your comments.
        I was following 2.7.2 docs to setup kms and found this issue.

        Show
        yuanbo Yuanbo Liu added a comment - Akira Ajisaka Thanks for your comments. I was following 2.7.2 docs to setup kms and found this issue.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thanks Yuanbo Liu and Yiqun Lin for contributing to this issue!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Yuanbo Liu and Yiqun Lin for contributing to this issue!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10891 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10891/)
        HDFS-11175. Document uppercase key names are not supported in (aajisaka: rev 636f7547b7067c315cf5448d77e49a8fe55651b3)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10891 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10891/ ) HDFS-11175 . Document uppercase key names are not supported in (aajisaka: rev 636f7547b7067c315cf5448d77e49a8fe55651b3) (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Yuanbo Liu for the quick review and Akira Ajisaka for the commit!

        Show
        linyiqun Yiqun Lin added a comment - Thanks Yuanbo Liu for the quick review and Akira Ajisaka for the commit!

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            yuanbo Yuanbo Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development