Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11145

Implement getTrashRoot() for ViewFileSystem

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:

      Description

      ViewFileSystem doesn't have the custom implementation of FileSystem#getTrashRoot(Path) yet and hence irrespective of Paths passed in, ViewFileSystem always returns the user specific .Trash directory.

      ViewFileSystem should implement getTrashRoot(Path) and delegate the call to the respective mounted file system which can then examine about EZ or other criteria and return a proper Trash directory.

      1. HDFS-11145.01.patch
        10 kB
        Manoj Govindassamy

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10876 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10876/)
        HDFS-11145. Implement getTrashRoot() for ViewFileSystem. (Manoj (lei: rev 3a09e5970db7e6db4cc47f18dafc1daf0ff2538b)

        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemHdfs.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10876 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10876/ ) HDFS-11145 . Implement getTrashRoot() for ViewFileSystem. (Manoj (lei: rev 3a09e5970db7e6db4cc47f18dafc1daf0ff2538b) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemHdfs.java
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        +1. LGTM.

        Committed to trunk. Thanks Manoj Govindassamy.

        Show
        eddyxu Lei (Eddy) Xu added a comment - +1. LGTM. Committed to trunk. Thanks Manoj Govindassamy .
        Hide
        manojg Manoj Govindassamy added a comment -

        Above unit test failures are not related to the patch.

        Show
        manojg Manoj Govindassamy added a comment - Above unit test failures are not related to the patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 45s Maven dependency ordering for branch
        +1 mvninstall 7m 26s trunk passed
        +1 compile 10m 49s trunk passed
        +1 checkstyle 1m 38s trunk passed
        +1 mvnsite 2m 3s trunk passed
        +1 mvneclipse 0m 35s trunk passed
        +1 findbugs 3m 11s trunk passed
        +1 javadoc 1m 42s trunk passed
        0 mvndep 0m 19s Maven dependency ordering for patch
        +1 mvninstall 1m 36s the patch passed
        +1 compile 9m 51s the patch passed
        +1 javac 9m 51s the patch passed
        +1 checkstyle 1m 38s the patch passed
        +1 mvnsite 2m 16s the patch passed
        +1 mvneclipse 0m 35s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 56s the patch passed
        +1 javadoc 1m 40s the patch passed
        +1 unit 9m 31s hadoop-common in the patch passed.
        -1 unit 96m 37s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 49s The patch does not generate ASF License warnings.
        158m 42s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR
          hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-11145
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839676/HDFS-11145.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9af403cd995e 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7584fbf
        Default Java 1.8.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17615/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17615/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17615/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 45s Maven dependency ordering for branch +1 mvninstall 7m 26s trunk passed +1 compile 10m 49s trunk passed +1 checkstyle 1m 38s trunk passed +1 mvnsite 2m 3s trunk passed +1 mvneclipse 0m 35s trunk passed +1 findbugs 3m 11s trunk passed +1 javadoc 1m 42s trunk passed 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 1m 36s the patch passed +1 compile 9m 51s the patch passed +1 javac 9m 51s the patch passed +1 checkstyle 1m 38s the patch passed +1 mvnsite 2m 16s the patch passed +1 mvneclipse 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 56s the patch passed +1 javadoc 1m 40s the patch passed +1 unit 9m 31s hadoop-common in the patch passed. -1 unit 96m 37s hadoop-hdfs in the patch failed. +1 asflicense 0m 49s The patch does not generate ASF License warnings. 158m 42s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11145 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839676/HDFS-11145.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9af403cd995e 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7584fbf Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17615/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17615/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17615/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        manojg Manoj Govindassamy added a comment -

        Attached v01 patch which takes care of the following

        • Implemented getTrashRoot(Path), getTrashRoots(users)
        • Updated ViewFileSystemBaseTest base class test to verify getTrashRoot for all filesystem derived tests
        • Updated TestViewFileSystemHdfs to verify getTrashRoots under EZ settings.
        Show
        manojg Manoj Govindassamy added a comment - Attached v01 patch which takes care of the following Implemented getTrashRoot(Path) , getTrashRoots(users) Updated ViewFileSystemBaseTest base class test to verify getTrashRoot for all filesystem derived tests Updated TestViewFileSystemHdfs to verify getTrashRoots under EZ settings.

          People

          • Assignee:
            manojg Manoj Govindassamy
            Reporter:
            manojg Manoj Govindassamy
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development