Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11134

Fix bind exception threw in TestRenameWhileOpen

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I found two bind exceptions causing the unit tests fails in history Jenkins buildings. One is test TestRenameWhileOpen, the other one is TestPendingInvalidateBlock.

      Here are the stack infos of TestRenameWhileOpen(I can't find the stack infos of TestPendingInvalidateBlock now since the time of that happened is too early, but I'm sure it has failed due to bind exception.)

      java.net.BindException: Problem binding to [localhost:42155] java.net.BindException: Address already in use; For more details see:  http://wiki.apache.org/hadoop/BindException
      	at sun.nio.ch.Net.bind0(Native Method)
      	at sun.nio.ch.Net.bind(Net.java:433)
      	at sun.nio.ch.Net.bind(Net.java:425)
      	at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
      	at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
      	at org.apache.hadoop.ipc.Server.bind(Server.java:535)
      	at org.apache.hadoop.ipc.Server$Listener.<init>(Server.java:919)
      	at org.apache.hadoop.ipc.Server.<init>(Server.java:2667)
      	at org.apache.hadoop.ipc.RPC$Server.<init>(RPC.java:959)
      	at org.apache.hadoop.ipc.ProtobufRpcEngine$Server.<init>(ProtobufRpcEngine.java:367)
      	at org.apache.hadoop.ipc.ProtobufRpcEngine.getServer(ProtobufRpcEngine.java:342)
      	at org.apache.hadoop.ipc.RPC$Builder.build(RPC.java:801)
      	at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.<init>(NameNodeRpcServer.java:434)
      	at org.apache.hadoop.hdfs.server.namenode.NameNode.createRpcServer(NameNode.java:796)
      	at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:723)
      	at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:937)
      	at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:916)
      	at org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1633)
      	at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:1263)
      	at org.apache.hadoop.hdfs.MiniDFSCluster.configureNameService(MiniDFSCluster.java:1032)
      	at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:907)
      	at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:839)
      	at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:491)
      	at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:450)
      	at org.apache.hadoop.hdfs.TestRenameWhileOpen.testWhileOpenRenameToNonExistentDirectory(TestRenameWhileOpen.java:325)
      

      Here specifying the namenode port is not necessary, is similar to HDFS-11129. And I have run this test many times in my local, it all passed. This JIRA we are focusing on fix the bind exception threw in TestRenameWhileOpen.

      1. HDFS-11134.001.patch
        7 kB
        Yiqun Lin
      2. HDFS-11134.002.patch
        8 kB
        Yiqun Lin
      3. HDFS-11134.003.patch
        7 kB
        Yiqun Lin

        Issue Links

          Activity

          Hide
          linyiqun Yiqun Lin added a comment -

          Attach a patch to make a quick fix.

          Show
          linyiqun Yiqun Lin added a comment - Attach a patch to make a quick fix.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Yiqun Lin thanks for reporting this..

          Patch LGTM..Pending for jenkins and will hold for commit till weekend if there are no furhter comments from someone.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Yiqun Lin thanks for reporting this.. Patch LGTM..Pending for jenkins and will hold for commit till weekend if there are no furhter comments from someone.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 51s trunk passed
          +1 compile 0m 45s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 41s trunk passed
          +1 javadoc 0m 38s trunk passed
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 48s the patch passed
          +1 javadoc 0m 37s the patch passed
          -1 unit 72m 45s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          91m 13s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestRollingUpgrade



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11134
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838687/HDFS-11134.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5fb58da2bca6 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 96f4392
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17546/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17546/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17546/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 51s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 41s trunk passed +1 javadoc 0m 38s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 72m 45s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 91m 13s Reason Tests Failed junit tests hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11134 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838687/HDFS-11134.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5fb58da2bca6 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 96f4392 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17546/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17546/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17546/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -
                // restart cluster with the same namenode port as before.
                // This ensures that leases are persisted in fsimage.
          

          If this sentence is correct, we need to specify the same port. Hi Yiqun Lin and Brahma Reddy Battula, what do you think?
          If this is true, I'm thinking it's better to retry the test when BindException occurs.

          Show
          ajisakaa Akira Ajisaka added a comment - // restart cluster with the same namenode port as before. // This ensures that leases are persisted in fsimage. If this sentence is correct, we need to specify the same port. Hi Yiqun Lin and Brahma Reddy Battula , what do you think? If this is true, I'm thinking it's better to retry the test when BindException occurs.
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks Akira Ajisaka for taking a look. This sentence looks confused. It can be understanding in two meanings:

          1.Just restarting cluster can ensure the leases to be persisted in fsimage, the same namenode port is not a necessary condition.
          2.Restarting cluster and meanwhile keeping the same namenode port can ensure the leased to be persisted in fsimage.

          I prefer the first meaning. And if the leases have been persisted, it looks strange that we must keep the same port to read these leases. So I think this is not a necessary condition. This is just my thought. Thanks!

          Show
          linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for taking a look. This sentence looks confused. It can be understanding in two meanings: 1.Just restarting cluster can ensure the leases to be persisted in fsimage, the same namenode port is not a necessary condition. 2.Restarting cluster and meanwhile keeping the same namenode port can ensure the leased to be persisted in fsimage. I prefer the first meaning. And if the leases have been persisted, it looks strange that we must keep the same port to read these leases. So I think this is not a necessary condition. This is just my thought. Thanks!
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Yiqun Lin thanks for explanation.
          Yes, that comment was misleading.+1 on option 1.. can you update the patch..? Akira Ajisaka what do you feel..?

          Show
          brahmareddy Brahma Reddy Battula added a comment - Yiqun Lin thanks for explanation. Yes, that comment was misleading.+1 on option 1.. can you update the patch..? Akira Ajisaka what do you feel..?
          Hide
          linyiqun Yiqun Lin added a comment -

          can you update the patch..?

          Done. Post the v002 patch. This will be a safe way.

          Show
          linyiqun Yiqun Lin added a comment - can you update the patch..? Done. Post the v002 patch. This will be a safe way.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 27s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 56s trunk passed
          +1 compile 0m 51s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 1m 1s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 49s trunk passed
          +1 javadoc 0m 44s trunk passed
          +1 mvninstall 0m 52s the patch passed
          +1 compile 0m 49s the patch passed
          +1 javac 0m 49s the patch passed
          +1 checkstyle 0m 27s the patch passed
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 58s the patch passed
          +1 javadoc 0m 43s the patch passed
          -1 unit 60m 5s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          81m 19s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestEncryptionZones



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11134
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839097/HDFS-11134.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b4c8356d78c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 61c0bed
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17580/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17580/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17580/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 56s trunk passed +1 compile 0m 51s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 52s the patch passed +1 compile 0m 49s the patch passed +1 javac 0m 49s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 58s the patch passed +1 javadoc 0m 43s the patch passed -1 unit 60m 5s hadoop-hdfs in the patch failed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 81m 19s Reason Tests Failed junit tests hadoop.hdfs.TestEncryptionZones Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11134 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839097/HDFS-11134.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b4c8356d78c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 61c0bed Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17580/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17580/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17580/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          If this sentence is correct, we need to specify the same port. Hi Yiqun Lin and Brahma Reddy Battula, what do you think? If this is true, I'm thinking it's better to retry the test when BindException occurs.

          I dont think for any test in TestRenameWhileOpen same namenode port is required. Because all the streams and clients created before restart were unused after restart.
          I have verified in my local machine that without specifying the name all tests passed. There could be streamer threads running with different namenode addresses, which wont harm the tests. So for safety, these streams could be aborted and old clients could be closed before creating new client after restart.

          For TestPendingInvalidateBlock, its not only cluster.restartDataNode(..); which tries to restart the datanodes in same port, but cluster.restartNameNode(..); also restarts the namenode in same port. In-fact cluster.restartNameNode(..); calls are more than cluster.restartDataNode(..);.
          So I dont think changing only cluster.restartDataNode(..); will solve failures in TestPendingInvalidateBlock.

          Show
          vinayrpet Vinayakumar B added a comment - If this sentence is correct, we need to specify the same port. Hi Yiqun Lin and Brahma Reddy Battula, what do you think? If this is true, I'm thinking it's better to retry the test when BindException occurs. I dont think for any test in TestRenameWhileOpen same namenode port is required. Because all the streams and clients created before restart were unused after restart. I have verified in my local machine that without specifying the name all tests passed. There could be streamer threads running with different namenode addresses, which wont harm the tests. So for safety, these streams could be aborted and old clients could be closed before creating new client after restart. For TestPendingInvalidateBlock , its not only cluster.restartDataNode(..); which tries to restart the datanodes in same port, but cluster.restartNameNode(..); also restarts the namenode in same port. In-fact cluster.restartNameNode(..); calls are more than cluster.restartDataNode(..); . So I dont think changing only cluster.restartDataNode(..); will solve failures in TestPendingInvalidateBlock .
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks Vinayakumar B taking a look into this issue..
          TestRenameWhileOpen: Yes, No need to keep same port.I mentioned to remove the port and update the comment which is misleading.

          TestPendingInvalidateBlock: Currently Restart namenode is not provided with different port ,because namenode port is a static configurations for client and datanodes which are running but Datanodes' port change will only affect the client's and operations which were using old addresses.
          Hence as of now, no need to change here.If the intermittent failure rate is very frequent then we can try to find some other alternative.
          For example, run only these kind of tests in non-parallel way.

          Yiqun Lin we can change the defect title and update patch for TestRenameWhileOpen.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks Vinayakumar B taking a look into this issue.. TestRenameWhileOpen : Yes, No need to keep same port.I mentioned to remove the port and update the comment which is misleading. TestPendingInvalidateBlock : Currently Restart namenode is not provided with different port ,because namenode port is a static configurations for client and datanodes which are running but Datanodes' port change will only affect the client's and operations which were using old addresses. Hence as of now, no need to change here.If the intermittent failure rate is very frequent then we can try to find some other alternative. For example, run only these kind of tests in non-parallel way. Yiqun Lin we can change the defect title and update patch for TestRenameWhileOpen.
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks Vinayakumar B and Brahma Reddy Battula for the great comments. The comments look good to me. In the v001 patch, I have removed the specified port and updated the misleading comment. So I think I can just remove the changes related to TestPendingInvalidateBlock. Post the v003 patch based on v001 patch.

          Show
          linyiqun Yiqun Lin added a comment - Thanks Vinayakumar B and Brahma Reddy Battula for the great comments. The comments look good to me. In the v001 patch, I have removed the specified port and updated the misleading comment. So I think I can just remove the changes related to TestPendingInvalidateBlock . Post the v003 patch based on v001 patch.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks for updating patch. LGTM, will hold for commit till Vinayakumar B/Akira Ajisaka looks into this once.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks for updating patch. LGTM, will hold for commit till Vinayakumar B / Akira Ajisaka looks into this once.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 33s trunk passed
          +1 compile 0m 57s trunk passed
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 1m 6s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 2m 7s trunk passed
          +1 javadoc 0m 50s trunk passed
          +1 mvninstall 1m 1s the patch passed
          +1 compile 0m 54s the patch passed
          +1 javac 0m 54s the patch passed
          +1 checkstyle 0m 30s the patch passed
          +1 mvnsite 1m 4s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 7s the patch passed
          +1 javadoc 0m 51s the patch passed
          -1 unit 80m 50s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          104m 13s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestSafeModeWithStripedFile



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11134
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839152/HDFS-11134.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 73252743fc5f 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d656035
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17586/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17586/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17586/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 33s trunk passed +1 compile 0m 57s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 2m 7s trunk passed +1 javadoc 0m 50s trunk passed +1 mvninstall 1m 1s the patch passed +1 compile 0m 54s the patch passed +1 javac 0m 54s the patch passed +1 checkstyle 0m 30s the patch passed +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 0m 51s the patch passed -1 unit 80m 50s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 104m 13s Reason Tests Failed junit tests hadoop.hdfs.TestSafeModeWithStripedFile Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11134 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839152/HDFS-11134.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 73252743fc5f 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d656035 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17586/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17586/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17586/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Vinayakumar B, Brahma Reddy Battula, and Yiqun Lin for the comments. +1 for v3 patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Vinayakumar B , Brahma Reddy Battula , and Yiqun Lin for the comments. +1 for v3 patch.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Committed to trunk,branch-2 and branch-2.8..Thanks Yiqun Lin for contribution,and thanks to Akira Ajisaka,Vinayakumar B for additional review.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Committed to trunk,branch-2 and branch-2.8..Thanks Yiqun Lin for contribution,and thanks to Akira Ajisaka , Vinayakumar B for additional review.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10853 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10853/)
          HDFS-11134. Fix bind exception threw in TestRenameWhileOpen. Contributed (brahma: rev b2d4b7b1b902aa830d44889d7747a4e1b816ab9d)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRenameWhileOpen.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10853 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10853/ ) HDFS-11134 . Fix bind exception threw in TestRenameWhileOpen. Contributed (brahma: rev b2d4b7b1b902aa830d44889d7747a4e1b816ab9d) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRenameWhileOpen.java
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks Brahma Reddy Battula for the final commit and thanks for the others.

          Show
          linyiqun Yiqun Lin added a comment - Thanks Brahma Reddy Battula for the final commit and thanks for the others.

            People

            • Assignee:
              linyiqun Yiqun Lin
              Reporter:
              linyiqun Yiqun Lin
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development