Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11116

Fix javac warnings caused by deprecation of APIs in TestViewFsDefaultValue

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      ViewFileSystem#getServerDefaults(Path) throws NotInMountException instead of FileNotFoundException for unmounted path.

      Description

      There were some Jenkins warinings related with TestViewFsDefaultValue in each Jenkins building.

      [WARNING] /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java:[108,9] [deprecation] getDefaultBlockSize() in FileSystem has been deprecated
      [WARNING] /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java:[123,9] [deprecation] getDefaultReplication() in FileSystem has been deprecated
      [WARNING] /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java:[138,43] [deprecation] getServerDefaults() in FileSystem has been deprecated
      

      We should use the method getDefaultBlockSize(Path) replace with deprecation API getDefaultBlockSize. The same to the getDefaultReplication and getServerDefaults. The Path can be a not-in-mountpoint path in filesystem to trigger the NotInMountpointException in test.

      1. HDFS-11116.001.patch
        3 kB
        Yiqun Lin
      2. HDFS-11116.002.patch
        4 kB
        Yiqun Lin
      3. HDFS-11116.003.patch
        4 kB
        Yiqun Lin

        Activity

        Hide
        linyiqun Yiqun Lin added a comment -

        Attach a initial patch to make a fix. Thanks for the review!

        Show
        linyiqun Yiqun Lin added a comment - Attach a initial patch to make a fix. Thanks for the review!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 3m 45s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 5s trunk passed
        +1 compile 0m 44s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 42s trunk passed
        +1 javadoc 0m 39s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s hadoop-hdfs-project_hadoop-hdfs generated 0 new + 26 unchanged - 3 fixed = 26 total (was 29)
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 45s the patch passed
        +1 javadoc 0m 36s the patch passed
        -1 unit 53m 18s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        75m 21s



        Reason Tests
        Failed junit tests hadoop.fs.viewfs.TestViewFsDefaultValue



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:e809691
        JIRA Issue HDFS-11116
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837767/HDFS-11116.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 60763821b92f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f768955
        Default Java 1.8.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17455/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17455/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17455/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 3m 45s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 5s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 39s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s hadoop-hdfs-project_hadoop-hdfs generated 0 new + 26 unchanged - 3 fixed = 26 total (was 29) +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 36s the patch passed -1 unit 53m 18s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 75m 21s Reason Tests Failed junit tests hadoop.fs.viewfs.TestViewFsDefaultValue Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HDFS-11116 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837767/HDFS-11116.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 60763821b92f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f768955 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17455/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17455/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17455/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        The failed test is related, reupload the v001 patch to fix that.

        Show
        linyiqun Yiqun Lin added a comment - The failed test is related, reupload the v001 patch to fix that.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 47s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 52s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 42s trunk passed
        +1 javadoc 0m 40s trunk passed
        +1 mvninstall 0m 44s the patch passed
        +1 compile 0m 42s the patch passed
        +1 javac 0m 42s hadoop-hdfs-project_hadoop-hdfs generated 0 new + 26 unchanged - 3 fixed = 26 total (was 29)
        -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 46s the patch passed
        +1 javadoc 0m 36s the patch passed
        -1 unit 79m 41s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 25s The patch does not generate ASF License warnings.
        98m 9s



        Reason Tests
        Failed junit tests hadoop.fs.viewfs.TestViewFsDefaultValue



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:e809691
        JIRA Issue HDFS-11116
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837782/HDFS-11116.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 19c89d5c9070 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f768955
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17457/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17457/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17457/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17457/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 47s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 44s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s hadoop-hdfs-project_hadoop-hdfs generated 0 new + 26 unchanged - 3 fixed = 26 total (was 29) -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 36s the patch passed -1 unit 79m 41s hadoop-hdfs in the patch failed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 98m 9s Reason Tests Failed junit tests hadoop.fs.viewfs.TestViewFsDefaultValue Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HDFS-11116 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837782/HDFS-11116.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 19c89d5c9070 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f768955 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17457/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17457/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17457/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17457/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        It seemed that the v001 patch still failed. Post the v002 patch to make a quick fix.

        Show
        linyiqun Yiqun Lin added a comment - It seemed that the v001 patch still failed. Post the v002 patch to make a quick fix.
        Hide
        manojg Manoj Govindassamy added a comment -

        Yiqun Lin,

           @Override
           public FsServerDefaults getServerDefaults(Path f) throws IOException {
        
        +    } catch (FileNotFoundException e) {
        +      throw new NotInMountpointException(f, "getServerDefaults");
        +    }
        

        Semantically, it might not be right to replace FileNotFileFoundException with NotInMountPointException and especially after resolving the file using the target file system. Your thoughts please ?

        Show
        manojg Manoj Govindassamy added a comment - Yiqun Lin , @Override public FsServerDefaults getServerDefaults(Path f) throws IOException { + } catch (FileNotFoundException e) { + throw new NotInMountpointException(f, "getServerDefaults" ); + } Semantically, it might not be right to replace FileNotFileFoundException with NotInMountPointException and especially after resolving the file using the target file system. Your thoughts please ?
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Manoj Govindassamy for the comments. Here the FileNohtFoundException threw from the line fsState.resolve(getUriPath(f), true) is actually that the input path isn't in mountpoint. If the exception FileNohtFoundException is threw. and then we throw the NotInMountpointException}.This logic has been done in {{getDefaultBlcokSize(Path) and getDefaultReplication(Path), so I also apply it to the method getServerDefaults(Path).

        Show
        linyiqun Yiqun Lin added a comment - Thanks Manoj Govindassamy for the comments. Here the FileNohtFoundException threw from the line fsState.resolve(getUriPath(f), true) is actually that the input path isn't in mountpoint. If the exception FileNohtFoundException is threw. and then we throw the NotInMountpointException}.This logic has been done in {{getDefaultBlcokSize(Path) and getDefaultReplication(Path) , so I also apply it to the method getServerDefaults(Path) .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 14s Maven dependency ordering for branch
        +1 mvninstall 8m 19s trunk passed
        +1 compile 11m 56s trunk passed
        +1 checkstyle 1m 38s trunk passed
        +1 mvnsite 2m 25s trunk passed
        +1 mvneclipse 0m 46s trunk passed
        +1 findbugs 4m 11s trunk passed
        +1 javadoc 2m 6s trunk passed
        0 mvndep 0m 21s Maven dependency ordering for patch
        +1 mvninstall 2m 5s the patch passed
        +1 compile 10m 10s the patch passed
        +1 javac 10m 10s root generated 0 new + 691 unchanged - 3 fixed = 691 total (was 694)
        -0 checkstyle 1m 45s root: The patch generated 2 new + 65 unchanged - 1 fixed = 67 total (was 66)
        +1 mvnsite 2m 49s the patch passed
        +1 mvneclipse 0m 49s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 35s the patch passed
        +1 javadoc 2m 0s the patch passed
        -1 unit 8m 37s hadoop-common in the patch failed.
        -1 unit 65m 6s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 46s The patch does not generate ASF License warnings.
        132m 48s



        Reason Tests
        Failed junit tests hadoop.ha.TestZKFailoverController
          hadoop.hdfs.server.datanode.TestLargeBlockReport
          hadoop.hdfs.TestFileCorruption
          hadoop.hdfs.server.namenode.ha.TestHAAppend



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:e809691
        JIRA Issue HDFS-11116
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838101/HDFS-11116.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2a5490fcbab9 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 62d8c17
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17479/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17479/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17479/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17479/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17479/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 8m 19s trunk passed +1 compile 11m 56s trunk passed +1 checkstyle 1m 38s trunk passed +1 mvnsite 2m 25s trunk passed +1 mvneclipse 0m 46s trunk passed +1 findbugs 4m 11s trunk passed +1 javadoc 2m 6s trunk passed 0 mvndep 0m 21s Maven dependency ordering for patch +1 mvninstall 2m 5s the patch passed +1 compile 10m 10s the patch passed +1 javac 10m 10s root generated 0 new + 691 unchanged - 3 fixed = 691 total (was 694) -0 checkstyle 1m 45s root: The patch generated 2 new + 65 unchanged - 1 fixed = 67 total (was 66) +1 mvnsite 2m 49s the patch passed +1 mvneclipse 0m 49s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 35s the patch passed +1 javadoc 2m 0s the patch passed -1 unit 8m 37s hadoop-common in the patch failed. -1 unit 65m 6s hadoop-hdfs in the patch failed. +1 asflicense 0m 46s The patch does not generate ASF License warnings. 132m 48s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.hdfs.server.datanode.TestLargeBlockReport   hadoop.hdfs.TestFileCorruption   hadoop.hdfs.server.namenode.ha.TestHAAppend Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HDFS-11116 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838101/HDFS-11116.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2a5490fcbab9 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 62d8c17 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17479/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17479/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17479/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17479/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17479/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Hi Akira Ajisaka, could you help make a quick review for this? I think this is a minor change and will not cost you many time, . Thanks in advance.

        Show
        linyiqun Yiqun Lin added a comment - Hi Akira Ajisaka , could you help make a quick review for this? I think this is a minor change and will not cost you many time, . Thanks in advance.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Would you fix checkstyle warnings? I'm +1 if that is addressed.
        Adding incompatible change flag.

        Show
        ajisakaa Akira Ajisaka added a comment - Would you fix checkstyle warnings? I'm +1 if that is addressed. Adding incompatible change flag.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Hi Yiqun Lin, would you write a release note to document the incompatibility?

        Show
        ajisakaa Akira Ajisaka added a comment - Hi Yiqun Lin , would you write a release note to document the incompatibility?
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka for the review! Attach a new patch to fix the checkstyle warnings.

        would you write a release note to document the incompatibility?

        Done, feel free to update it if you think it need to make some changes.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for the review! Attach a new patch to fix the checkstyle warnings. would you write a release note to document the incompatibility? Done, feel free to update it if you think it need to make some changes.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thank you, and I'll update this.

        Show
        ajisakaa Akira Ajisaka added a comment - Thank you, and I'll update this.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 22s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 16s Maven dependency ordering for branch
        +1 mvninstall 8m 39s trunk passed
        +1 compile 12m 35s trunk passed
        +1 checkstyle 1m 44s trunk passed
        +1 mvnsite 2m 23s trunk passed
        +1 mvneclipse 0m 53s trunk passed
        +1 findbugs 3m 28s trunk passed
        +1 javadoc 1m 46s trunk passed
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 23s the patch passed
        +1 compile 11m 5s the patch passed
        +1 javac 11m 5s root generated 0 new + 691 unchanged - 3 fixed = 691 total (was 694)
        +1 checkstyle 1m 37s root: The patch generated 0 new + 66 unchanged - 1 fixed = 66 total (was 67)
        +1 mvnsite 2m 9s the patch passed
        +1 mvneclipse 0m 45s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 5s the patch passed
        +1 javadoc 1m 44s the patch passed
        +1 unit 9m 15s hadoop-common in the patch passed.
        -1 unit 80m 30s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 41s The patch does not generate ASF License warnings.
        146m 55s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
          hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR
          hadoop.hdfs.TestRollingUpgrade



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:e809691
        JIRA Issue HDFS-11116
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838143/HDFS-11116.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c1db11f28bcb 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 283fa33
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17485/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17485/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17485/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 8m 39s trunk passed +1 compile 12m 35s trunk passed +1 checkstyle 1m 44s trunk passed +1 mvnsite 2m 23s trunk passed +1 mvneclipse 0m 53s trunk passed +1 findbugs 3m 28s trunk passed +1 javadoc 1m 46s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 23s the patch passed +1 compile 11m 5s the patch passed +1 javac 11m 5s root generated 0 new + 691 unchanged - 3 fixed = 691 total (was 694) +1 checkstyle 1m 37s root: The patch generated 0 new + 66 unchanged - 1 fixed = 66 total (was 67) +1 mvnsite 2m 9s the patch passed +1 mvneclipse 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 5s the patch passed +1 javadoc 1m 44s the patch passed +1 unit 9m 15s hadoop-common in the patch passed. -1 unit 80m 30s hadoop-hdfs in the patch failed. +1 asflicense 0m 41s The patch does not generate ASF License warnings. 146m 55s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby   hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR   hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HDFS-11116 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838143/HDFS-11116.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c1db11f28bcb 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 283fa33 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17485/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17485/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17485/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, checking this in.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, checking this in.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk. Thanks Yiqun Lin for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Yiqun Lin for the contribution.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10816 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10816/)
        HDFS-11116. Fix javac warnings caused by deprecation of APIs in (aajisaka: rev 8848a8a76c7eadebb15b347171057f906f6fc69b)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10816 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10816/ ) HDFS-11116 . Fix javac warnings caused by deprecation of APIs in (aajisaka: rev 8848a8a76c7eadebb15b347171057f906f6fc69b) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka for the commit!

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for the commit!

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            linyiqun Yiqun Lin
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development