Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Introduce support for running async checks.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user arp7 closed the pull request at:

          https://github.com/apache/hadoop/pull/154

          Show
          githubbot ASF GitHub Bot added a comment - Github user arp7 closed the pull request at: https://github.com/apache/hadoop/pull/154
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Committed to branch-2 with the fixes for Java 7.

          Tracking the bad unit test in HDFS-11131.

          Show
          arpitagarwal Arpit Agarwal added a comment - Committed to branch-2 with the fixes for Java 7. Tracking the bad unit test in HDFS-11131 .
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks Steve.

          Kihwal Lee, I can't explain that failure. The test is supposed to be deterministic. I ran a few hundred iterations locally on two different machines and didn't see a repro. Will watch out for more instances of failures.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks Steve. Kihwal Lee , I can't explain that failure. The test is supposed to be deterministic. I ran a few hundred iterations locally on two different machines and didn't see a repro. Will watch out for more instances of failures.
          Hide
          kihwal Kihwal Lee added a comment -

          This failed recently.
          https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/220/testReport/junit/org.apache.hadoop.hdfs.server.datanode.checker/TestThrottledAsyncChecker/testContextIsPassed/

          Stacktrace
          
          java.lang.AssertionError: null
          	at org.junit.Assert.fail(Assert.java:86)
          	at org.junit.Assert.assertTrue(Assert.java:41)
          	at org.junit.Assert.assertFalse(Assert.java:64)
          	at org.junit.Assert.assertFalse(Assert.java:74)
          	at org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker.testContextIsPassed(TestThrottledAsyncChecker.java:174)
          
          Standard Output
          
          2016-11-09 09:25:11,786 [pool-2-thread-1] INFO  checker.TestThrottledAsyncChecker (TestThrottledAsyncChecker.java:check(245)) - LatchedCheckable org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker$LatchedCheckable@7aeb663a waiting.
          2016-11-09 09:25:11,790 [pool-2-thread-1] INFO  checker.TestThrottledAsyncChecker (TestThrottledAsyncChecker.java:onFailure(272)) - onFailure callback invoked for org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker$LatchedCheckable@7aeb663a with exception
          java.lang.InterruptedException
          	at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1302)
          	at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:231)
          	at org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker$LatchedCheckable.check(TestThrottledAsyncChecker.java:246)
          	at org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker$LatchedCheckable.check(TestThrottledAsyncChecker.java:239)
          	at org.apache.hadoop.hdfs.server.datanode.checker.ThrottledAsyncChecker$1.call(ThrottledAsyncChecker.java:130)
          	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
          	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
          	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
          	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
          	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
          	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
          	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
          	at java.lang.Thread.run(Thread.java:745)
          2016-11-09 09:25:11,817 [pool-5-thread-1] INFO  checker.TestThrottledAsyncChecker (TestThrottledAsyncChecker.java:check(245)) - LatchedCheckable org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker$LatchedCheckable@12aed2de waiting.
          
          Show
          kihwal Kihwal Lee added a comment - This failed recently. https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/220/testReport/junit/org.apache.hadoop.hdfs.server.datanode.checker/TestThrottledAsyncChecker/testContextIsPassed/ Stacktrace java.lang.AssertionError: null at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertFalse(Assert.java:64) at org.junit.Assert.assertFalse(Assert.java:74) at org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker.testContextIsPassed(TestThrottledAsyncChecker.java:174) Standard Output 2016-11-09 09:25:11,786 [pool-2-thread-1] INFO checker.TestThrottledAsyncChecker (TestThrottledAsyncChecker.java:check(245)) - LatchedCheckable org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker$LatchedCheckable@7aeb663a waiting. 2016-11-09 09:25:11,790 [pool-2-thread-1] INFO checker.TestThrottledAsyncChecker (TestThrottledAsyncChecker.java:onFailure(272)) - onFailure callback invoked for org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker$LatchedCheckable@7aeb663a with exception java.lang.InterruptedException at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1302) at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:231) at org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker$LatchedCheckable.check(TestThrottledAsyncChecker.java:246) at org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker$LatchedCheckable.check(TestThrottledAsyncChecker.java:239) at org.apache.hadoop.hdfs.server.datanode.checker.ThrottledAsyncChecker$1.call(ThrottledAsyncChecker.java:130) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) 2016-11-09 09:25:11,817 [pool-5-thread-1] INFO checker.TestThrottledAsyncChecker (TestThrottledAsyncChecker.java:check(245)) - LatchedCheckable org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker$LatchedCheckable@12aed2de waiting.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Yetus doesn't like mixing .patch and PR files; once you add a PR, patches get ignored. We've ended in some other patches (HADOOP-13560) with creating new JIRAs just to ensure that the testing went with what we want. I've now switched back to doing .patch files; a few extra lines of work, but that's all.

          Show
          stevel@apache.org Steve Loughran added a comment - Yetus doesn't like mixing .patch and PR files; once you add a PR, patches get ignored. We've ended in some other patches ( HADOOP-13560 ) with creating new JIRAs just to ensure that the testing went with what we want. I've now switched back to doing .patch files; a few extra lines of work, but that's all.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          -1 mvninstall 1m 20s root in branch-2 failed.
          +1 compile 0m 50s branch-2 passed with JDK v1.8.0_111
          +1 compile 0m 42s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 0m 28s branch-2 passed
          +1 mvnsite 0m 55s branch-2 passed
          +1 mvneclipse 0m 13s branch-2 passed
          +1 findbugs 1m 55s branch-2 passed
          +1 javadoc 0m 59s branch-2 passed with JDK v1.8.0_111
          +1 javadoc 1m 34s branch-2 passed with JDK v1.7.0_111
          -1 mvninstall 0m 44s hadoop-hdfs in the patch failed.
          +1 compile 0m 36s the patch passed with JDK v1.8.0_111
          +1 javac 0m 36s the patch passed
          +1 compile 0m 41s the patch passed with JDK v1.7.0_111
          +1 javac 0m 41s the patch passed
          -0 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 mvnsite 0m 50s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 10s the patch passed
          +1 javadoc 0m 53s the patch passed with JDK v1.8.0_111
          +1 javadoc 1m 33s the patch passed with JDK v1.7.0_111
          -1 unit 49m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          123m 50s



          Reason Tests
          JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.namenode.TestNamenodeCapacityReport



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HDFS-11114
          GITHUB PR https://github.com/apache/hadoop/pull/154
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1542552283ba 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 797c7bf
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17476/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17476/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17476/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17476/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17476/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17476/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. -1 mvninstall 1m 20s root in branch-2 failed. +1 compile 0m 50s branch-2 passed with JDK v1.8.0_111 +1 compile 0m 42s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 28s branch-2 passed +1 mvnsite 0m 55s branch-2 passed +1 mvneclipse 0m 13s branch-2 passed +1 findbugs 1m 55s branch-2 passed +1 javadoc 0m 59s branch-2 passed with JDK v1.8.0_111 +1 javadoc 1m 34s branch-2 passed with JDK v1.7.0_111 -1 mvninstall 0m 44s hadoop-hdfs in the patch failed. +1 compile 0m 36s the patch passed with JDK v1.8.0_111 +1 javac 0m 36s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_111 +1 javac 0m 41s the patch passed -0 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 10s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_111 +1 javadoc 1m 33s the patch passed with JDK v1.7.0_111 -1 unit 49m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 123m 50s Reason Tests JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.namenode.TestNamenodeCapacityReport Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-11114 GITHUB PR https://github.com/apache/hadoop/pull/154 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1542552283ba 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 797c7bf Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17476/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17476/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17476/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17476/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17476/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17476/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment - - edited

          I'd be happy to reattach the patch files. IIUC GitHub integration is officially supported so it shouldn't be a new workflow. I removed the attachments as Jenkins wasn't doing the right thing when I had patch files and pull request both.

          Show
          arpitagarwal Arpit Agarwal added a comment - - edited I'd be happy to reattach the patch files. IIUC GitHub integration is officially supported so it shouldn't be a new workflow. I removed the attachments as Jenkins wasn't doing the right thing when I had patch files and pull request both.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Arpit Agarwal. This seems a workflow change. It'd be nice to stick to the same workflow by attaching patch files to be consistent. What do you think? thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Arpit Agarwal . This seems a workflow change. It'd be nice to stick to the same workflow by attaching patch files to be consistent. What do you think? thanks.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Hi Yongjun Zhang, the changes are in the pull requests. #153 has two patches for trunk. #154 has the branch-2 patch.

          Show
          arpitagarwal Arpit Agarwal added a comment - Hi Yongjun Zhang , the changes are in the pull requests. #153 has two patches for trunk. #154 has the branch-2 patch.
          Hide
          yzhangal Yongjun Zhang added a comment -

          HI Arpit Agarwal,

          Thanks for working on this issue. I don't see patch files attached, and guess they were removed. Is it intentional? It'd be nice to have the patch files in the jira.

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - HI Arpit Agarwal , Thanks for working on this issue. I don't see patch files attached, and guess they were removed. Is it intentional? It'd be nice to have the patch files in the jira. Thanks.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user arp7 opened a pull request:

          https://github.com/apache/hadoop/pull/154

          HDFS-11114. Support for running async disk checks in DataNode.

          Patch for branch-2 to fix Java 7 compiler errors. Changes were minor - added final for variables referenced in anonymous inner classes and explicit type parameter when in the call to Futures.<V>immediateFailedFuture(result.exception).

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/arp7/hadoop branch-2

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/154.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #154


          commit cec4608d302af06d8ee01d2dc7ef5e453536bbc3
          Author: Arpit Agarwal <arp@apache.org>
          Date: 2016-11-08T21:53:07Z

          HDFS-11114. Support for running async disk checks in DataNode.

          Change-Id: Ifb2850ca4b9f9a60e23d456be0afa3e5ebd04b1b


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user arp7 opened a pull request: https://github.com/apache/hadoop/pull/154 HDFS-11114 . Support for running async disk checks in DataNode. Patch for branch-2 to fix Java 7 compiler errors. Changes were minor - added final for variables referenced in anonymous inner classes and explicit type parameter when in the call to Futures.<V>immediateFailedFuture(result.exception) . You can merge this pull request into a Git repository by running: $ git pull https://github.com/arp7/hadoop branch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/154.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #154 commit cec4608d302af06d8ee01d2dc7ef5e453536bbc3 Author: Arpit Agarwal <arp@apache.org> Date: 2016-11-08T21:53:07Z HDFS-11114 . Support for running async disk checks in DataNode. Change-Id: Ifb2850ca4b9f9a60e23d456be0afa3e5ebd04b1b
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for the heads up Kihwal Lee and Steve Loughran. I have reverted it from branch-2 for now.

          I usually compile on branch-2 before pushing but skipped it this time.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for the heads up Kihwal Lee and Steve Loughran . I have reverted it from branch-2 for now. I usually compile on branch-2 before pushing but skipped it this time.
          Hide
          kihwal Kihwal Lee added a comment -

          It broke branch-2. Steve Loughran also noticed it.

          Show
          kihwal Kihwal Lee added a comment - It broke branch-2. Steve Loughran also noticed it.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          The checkstyle issue is a false positive and the unit test failures are unrelated.

          I've committed this. Thanks for the code review Anu Engineer.

          Show
          arpitagarwal Arpit Agarwal added a comment - The checkstyle issue is a false positive and the unit test failures are unrelated. I've committed this. Thanks for the code review Anu Engineer .
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/hadoop/pull/153

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/hadoop/pull/153
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 15m 50s trunk passed
          +1 compile 1m 59s trunk passed
          +1 checkstyle 1m 11s trunk passed
          +1 mvnsite 1m 21s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 45s trunk passed
          +1 javadoc 0m 40s trunk passed
          +1 mvninstall 0m 50s the patch passed
          +1 compile 0m 41s the patch passed
          +1 javac 0m 41s the patch passed
          -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 45s the patch passed
          +1 javadoc 0m 36s the patch passed
          -1 unit 77m 41s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          107m 50s



          Reason Tests
          Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.namenode.ha.TestHAAppend



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HDFS-11114
          GITHUB PR https://github.com/apache/hadoop/pull/153
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 74ca2b1ed68f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / de3b4aa
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17459/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17459/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17459/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17459/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 15m 50s trunk passed +1 compile 1m 59s trunk passed +1 checkstyle 1m 11s trunk passed +1 mvnsite 1m 21s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 36s the patch passed -1 unit 77m 41s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 107m 50s Reason Tests Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.ha.TestHAAppend Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HDFS-11114 GITHUB PR https://github.com/apache/hadoop/pull/153 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 74ca2b1ed68f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / de3b4aa Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17459/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17459/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17459/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17459/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          anu Anu Engineer added a comment -

          +1, LGTM. Arpit Agarwal Thanks for providing this patch.

          Show
          anu Anu Engineer added a comment - +1, LGTM. Arpit Agarwal Thanks for providing this patch.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user arp7 commented on the issue:

          https://github.com/apache/hadoop/pull/153

          Renamed it to shutdownAndWait.

          Show
          githubbot ASF GitHub Bot added a comment - Github user arp7 commented on the issue: https://github.com/apache/hadoop/pull/153 Renamed it to shutdownAndWait.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user arp7 commented on a diff in the pull request:

          https://github.com/apache/hadoop/pull/153#discussion_r86861747

          — Diff: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/AsyncChecker.java —
          @@ -0,0 +1,62 @@
          +/**
          + * Licensed to the Apache Software Foundation (ASF) under one
          + * or more contributor license agreements. See the NOTICE file
          + * distributed with this work for additional information
          + * regarding copyright ownership. The ASF licenses this file
          + * to you under the Apache License, Version 2.0 (the
          + * "License"); you may not use this file except in compliance
          + * with the License. You may obtain a copy of the License at
          + * <p>
          + * http://www.apache.org/licenses/LICENSE-2.0
          + * <p>
          + * Unless required by applicable law or agreed to in writing, software
          + * distributed under the License is distributed on an "AS IS" BASIS,
          + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
          + * See the License for the specific language governing permissions and
          + * limitations under the License.
          + */
          +
          +package org.apache.hadoop.hdfs.server.datanode.checker;
          +
          +import com.google.common.util.concurrent.ListenableFuture;
          +import org.apache.hadoop.classification.InterfaceAudience;
          +import org.apache.hadoop.classification.InterfaceStability;
          +
          +import java.util.concurrent.ExecutorService;
          +import java.util.concurrent.TimeUnit;
          +
          +/**
          + * A class that can be used to schedule an asynchronous check on a given
          + *

          {@link Checkable}

          . If the check is successfully scheduled then a
          + *

          {@link ListenableFuture} is returned.
          + *
          + */
          +@InterfaceAudience.Private
          +@InterfaceStability.Unstable
          +public interface AsyncChecker<K, V> {
          +
          + /**
          + * Schedule an asynchronous check for the given object.
          + *
          + * @param target object to be checked.
          + *
          + * @param context the interpretation of the context depends on the
          + * target.
          + *
          + * @return returns a {@link ListenableFuture}

          that can be used to
          + * retrieve the result of the asynchronous check.
          + */
          + ListenableFuture<V> schedule(Checkable<K, V> target, K context);
          +
          + /**
          + * Cancel all executing checks and wait for them to complete.
          + * First attempts a graceful cancellation, then cancels forcefully.
          + * Waits for the supplied timeout after both attempts.
          + *
          + * See

          {@link ExecutorService#awaitTermination}

          for a description of
          + * the parameters.
          + *
          + * @throws InterruptedException
          + */
          + void join(long timeout, TimeUnit timeUnit) throws InterruptedException;
          — End diff –

          Thanks for taking a look @anuengineer. The method covers both shutdown and awaitTermination semantics. I could call it shutdownAndAwaitTermination() to make it clearer.

          Show
          githubbot ASF GitHub Bot added a comment - Github user arp7 commented on a diff in the pull request: https://github.com/apache/hadoop/pull/153#discussion_r86861747 — Diff: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/AsyncChecker.java — @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdfs.server.datanode.checker; + +import com.google.common.util.concurrent.ListenableFuture; +import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceStability; + +import java.util.concurrent.ExecutorService; +import java.util.concurrent.TimeUnit; + +/** + * A class that can be used to schedule an asynchronous check on a given + * {@link Checkable} . If the check is successfully scheduled then a + * {@link ListenableFuture} is returned. + * + */ +@InterfaceAudience.Private +@InterfaceStability.Unstable +public interface AsyncChecker<K, V> { + + /** + * Schedule an asynchronous check for the given object. + * + * @param target object to be checked. + * + * @param context the interpretation of the context depends on the + * target. + * + * @return returns a {@link ListenableFuture} that can be used to + * retrieve the result of the asynchronous check. + */ + ListenableFuture<V> schedule(Checkable<K, V> target, K context); + + /** + * Cancel all executing checks and wait for them to complete. + * First attempts a graceful cancellation, then cancels forcefully. + * Waits for the supplied timeout after both attempts. + * + * See {@link ExecutorService#awaitTermination} for a description of + * the parameters. + * + * @throws InterruptedException + */ + void join(long timeout, TimeUnit timeUnit) throws InterruptedException; — End diff – Thanks for taking a look @anuengineer. The method covers both shutdown and awaitTermination semantics. I could call it shutdownAndAwaitTermination() to make it clearer.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user anuengineer commented on a diff in the pull request:

          https://github.com/apache/hadoop/pull/153#discussion_r86860005

          — Diff: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/AsyncChecker.java —
          @@ -0,0 +1,62 @@
          +/**
          + * Licensed to the Apache Software Foundation (ASF) under one
          + * or more contributor license agreements. See the NOTICE file
          + * distributed with this work for additional information
          + * regarding copyright ownership. The ASF licenses this file
          + * to you under the Apache License, Version 2.0 (the
          + * "License"); you may not use this file except in compliance
          + * with the License. You may obtain a copy of the License at
          + * <p>
          + * http://www.apache.org/licenses/LICENSE-2.0
          + * <p>
          + * Unless required by applicable law or agreed to in writing, software
          + * distributed under the License is distributed on an "AS IS" BASIS,
          + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
          + * See the License for the specific language governing permissions and
          + * limitations under the License.
          + */
          +
          +package org.apache.hadoop.hdfs.server.datanode.checker;
          +
          +import com.google.common.util.concurrent.ListenableFuture;
          +import org.apache.hadoop.classification.InterfaceAudience;
          +import org.apache.hadoop.classification.InterfaceStability;
          +
          +import java.util.concurrent.ExecutorService;
          +import java.util.concurrent.TimeUnit;
          +
          +/**
          + * A class that can be used to schedule an asynchronous check on a given
          + *

          {@link Checkable}

          . If the check is successfully scheduled then a
          + *

          {@link ListenableFuture} is returned.
          + *
          + */
          +@InterfaceAudience.Private
          +@InterfaceStability.Unstable
          +public interface AsyncChecker<K, V> {
          +
          + /**
          + * Schedule an asynchronous check for the given object.
          + *
          + * @param target object to be checked.
          + *
          + * @param context the interpretation of the context depends on the
          + * target.
          + *
          + * @return returns a {@link ListenableFuture}

          that can be used to
          + * retrieve the result of the asynchronous check.
          + */
          + ListenableFuture<V> schedule(Checkable<K, V> target, K context);
          +
          + /**
          + * Cancel all executing checks and wait for them to complete.
          + * First attempts a graceful cancellation, then cancels forcefully.
          + * Waits for the supplied timeout after both attempts.
          + *
          + * See

          {@link ExecutorService#awaitTermination}

          for a description of
          + * the parameters.
          + *
          + * @throws InterruptedException
          + */
          + void join(long timeout, TimeUnit timeUnit) throws InterruptedException;
          — End diff –

          Just trying to understand this a little better, From the signature and implementation this function looks more a awaitTermination in executorService. That is this function will wait for a while and cancel and task if the timeout occurs, in that case would you consider calling this await or awaitTermination. Java "join" seems to imply a wait without timeouts. Just making sure that the intended was indeed a shutdown/await pattern.

          Show
          githubbot ASF GitHub Bot added a comment - Github user anuengineer commented on a diff in the pull request: https://github.com/apache/hadoop/pull/153#discussion_r86860005 — Diff: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/AsyncChecker.java — @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdfs.server.datanode.checker; + +import com.google.common.util.concurrent.ListenableFuture; +import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceStability; + +import java.util.concurrent.ExecutorService; +import java.util.concurrent.TimeUnit; + +/** + * A class that can be used to schedule an asynchronous check on a given + * {@link Checkable} . If the check is successfully scheduled then a + * {@link ListenableFuture} is returned. + * + */ +@InterfaceAudience.Private +@InterfaceStability.Unstable +public interface AsyncChecker<K, V> { + + /** + * Schedule an asynchronous check for the given object. + * + * @param target object to be checked. + * + * @param context the interpretation of the context depends on the + * target. + * + * @return returns a {@link ListenableFuture} that can be used to + * retrieve the result of the asynchronous check. + */ + ListenableFuture<V> schedule(Checkable<K, V> target, K context); + + /** + * Cancel all executing checks and wait for them to complete. + * First attempts a graceful cancellation, then cancels forcefully. + * Waits for the supplied timeout after both attempts. + * + * See {@link ExecutorService#awaitTermination} for a description of + * the parameters. + * + * @throws InterruptedException + */ + void join(long timeout, TimeUnit timeUnit) throws InterruptedException; — End diff – Just trying to understand this a little better, From the signature and implementation this function looks more a awaitTermination in executorService. That is this function will wait for a while and cancel and task if the timeout occurs, in that case would you consider calling this await or awaitTermination. Java "join" seems to imply a wait without timeouts. Just making sure that the intended was indeed a shutdown/await pattern.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user arp7 opened a pull request:

          https://github.com/apache/hadoop/pull/153

          HDFS-11114. Support for running async disk checks in DataNode.

          Interface for running async checks on a resource.

          The implementation ThrottledAsyncChecker supports throttling and result-caching. DataNode changes to use it will be done in another Jira.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/arp7/hadoop trunk

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/153.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #153


          commit 729705d8d6b839d1e835cc1d60f7a15e7052fac1
          Author: Arpit Agarwal <arp@apache.org>
          Date: 2016-11-07T20:00:22Z

          HDFS-11114. Support for running async disk checks in DataNode.

          Change-Id: Ib21cd21fe9b67ca35b38f8462c138e90b55f33df


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user arp7 opened a pull request: https://github.com/apache/hadoop/pull/153 HDFS-11114 . Support for running async disk checks in DataNode. Interface for running async checks on a resource. The implementation ThrottledAsyncChecker supports throttling and result-caching. DataNode changes to use it will be done in another Jira. You can merge this pull request into a Git repository by running: $ git pull https://github.com/arp7/hadoop trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/153.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #153 commit 729705d8d6b839d1e835cc1d60f7a15e7052fac1 Author: Arpit Agarwal <arp@apache.org> Date: 2016-11-07T20:00:22Z HDFS-11114 . Support for running async disk checks in DataNode. Change-Id: Ib21cd21fe9b67ca35b38f8462c138e90b55f33df
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 44s trunk passed
          +1 compile 0m 44s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 41s trunk passed
          +1 javadoc 0m 39s trunk passed
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 46s the patch passed
          +1 javadoc 0m 35s the patch passed
          -1 unit 88m 43s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          107m 5s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestLeaseRecovery2



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-11114
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837666/HDFS-11114.02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4107932395f1 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d8bab3d
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17443/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17443/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17443/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17443/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 44s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 41s trunk passed +1 javadoc 0m 39s trunk passed +1 mvninstall 0m 44s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 35s the patch passed -1 unit 88m 43s hadoop-hdfs in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 107m 5s Reason Tests Failed junit tests hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11114 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837666/HDFS-11114.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4107932395f1 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d8bab3d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17443/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17443/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17443/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17443/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          v02: checkstyle fixes.

          Show
          arpitagarwal Arpit Agarwal added a comment - v02: checkstyle fixes.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 5s trunk passed
          +1 compile 0m 45s trunk passed
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 40s trunk passed
          +1 javadoc 0m 40s trunk passed
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 16 new + 0 unchanged - 0 fixed = 16 total (was 0)
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 48s the patch passed
          +1 javadoc 0m 36s the patch passed
          +1 unit 73m 4s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          91m 46s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-11114
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837657/HDFS-11114.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2630915f8258 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d8bab3d
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17442/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17442/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17442/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 5s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 16 new + 0 unchanged - 0 fixed = 16 total (was 0) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 36s the patch passed +1 unit 73m 4s hadoop-hdfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 91m 46s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11114 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837657/HDFS-11114.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2630915f8258 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d8bab3d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17442/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17442/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17442/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Interface for running async checks on a resource.

          The implementation ThrottledAsyncChecker supports throttling and result-caching. DataNode changes to use it will be done in another Jira.

          Show
          arpitagarwal Arpit Agarwal added a comment - Interface for running async checks on a resource. The implementation ThrottledAsyncChecker supports throttling and result-caching. DataNode changes to use it will be done in another Jira.

            People

            • Assignee:
              arpitagarwal Arpit Agarwal
              Reporter:
              arpitagarwal Arpit Agarwal
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development