Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-111

UnderReplicationBlocks should use generic types

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Not A Problem
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      1. HADOOP-659 introduced new class UnderReplicationBlocks, and
      two new warnings about use of generic types
      TreeSet<Block>[] priorityQueues = new TreeSet[LEVEL];
      Iterator<Block>[] iterator = new Iterator[LEVEL];
      should resp. read
      TreeSet<Block>[] priorityQueues = new TreeSet<Block>[LEVEL];
      Iterator<Block>[] iterator = new Iterator<Block>[LEVEL];

      2. I'd rename class UnderReplicationBlocks to UnderReplicatedBlocks while it is still internal.

        Activity

        Hide
        Konstantin Shvachko added a comment -

        Clarifying on (2):
        The class name is somewhat misleading because it does not describe blocks, which are currently being replicated,
        that is under replication, but rather blocks that have low replication factor, that is under-replicated.

        Show
        Konstantin Shvachko added a comment - Clarifying on (2): The class name is somewhat misleading because it does not describe blocks, which are currently being replicated, that is under replication, but rather blocks that have low replication factor, that is under-replicated.
        Hide
        Harsh J added a comment -

        Both comments seem to have been addressed already today. Not a problem anymore, resolving.

        Show
        Harsh J added a comment - Both comments seem to have been addressed already today. Not a problem anymore, resolving.

          People

          • Assignee:
            Unassigned
            Reporter:
            Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development