Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.21.0, 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      hdfs-default.xml still has the old default value dfs.support.append = false. It should be changed to true, or removed from the default configuration and treated as true if not found.

      1. appendOn.patch
        4 kB
        Konstantin Shvachko
      2. appendOn.patch
        3 kB
        Konstantin Shvachko

        Issue Links

          Activity

          Hide
          Konstantin Shvachko added a comment -

          I think it should be fixed for 0.21.

          Show
          Konstantin Shvachko added a comment - I think it should be fixed for 0.21.
          Hide
          Konstantin Shvachko added a comment -

          I am going to remove dfs.support.append from hdfs-default.xml, and change the default value to true for this variable in the code, if there are no other suggestions.
          This should not be treated as incompatible change, as I cannot imagine programs that would strictly rely on that append is not supported and would fail if it suddenly is.

          Show
          Konstantin Shvachko added a comment - I am going to remove dfs.support.append from hdfs-default.xml , and change the default value to true for this variable in the code, if there are no other suggestions. This should not be treated as incompatible change, as I cannot imagine programs that would strictly rely on that append is not supported and would fail if it suddenly is.
          Hide
          Jakob Homan added a comment -

          +1

          Show
          Jakob Homan added a comment - +1
          Hide
          Eli Collins added a comment -

          +1

          Show
          Eli Collins added a comment - +1
          Hide
          Konstantin Shvachko added a comment -

          This patch turns appendon by default. But there is still a way to turn it off. The next radical step is to remove all checks in the code whether append is supported. I'll file another jira for that. It can be done in later in 0.22.

          Show
          Konstantin Shvachko added a comment - This patch turns appendon by default. But there is still a way to turn it off. The next radical step is to remove all checks in the code whether append is supported. I'll file another jira for that. It can be done in later in 0.22.
          Hide
          Hairong Kuang added a comment -

          Could you please change DFSConfigKeys#DFS_SUPPORT_APPEND_DEFAULT to be true?

          Show
          Hairong Kuang added a comment - Could you please change DFSConfigKeys#DFS_SUPPORT_APPEND_DEFAULT to be true?
          Hide
          Konstantin Shvachko added a comment -

          Changed DFS_SUPPORT_APPEND_DEFAULT and used it in NN and DN.

          Show
          Konstantin Shvachko added a comment - Changed DFS_SUPPORT_APPEND_DEFAULT and used it in NN and DN.
          Hide
          Hairong Kuang added a comment -

          +1

          Show
          Hairong Kuang added a comment - +1
          Hide
          Konstantin Shvachko added a comment -

          Hudson is out again. I ran tests locally with no failures.

          Show
          Konstantin Shvachko added a comment - Hudson is out again. I ran tests locally with no failures.
          Hide
          Konstantin Shvachko added a comment -

          I just committed this.

          Show
          Konstantin Shvachko added a comment - I just committed this.

            People

            • Assignee:
              Konstantin Shvachko
              Reporter:
              Konstantin Shvachko
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development