Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11061

Update dfs -count -t command line help and documentation

    Details

    • Hadoop Flags:
      Reviewed

      Description

      According to dfs -count command line help, -t option must be used along with -q.

      • However, the current behavior is that -t can be used without -q, it's just silently ignored.
      • In addition, -t may also be used with -u.
      • The FileSystemShell doc does not state -t must be used along with -q. This should either be enforced in the code, or update the doc/command line.
      • Also, the list of possible parameters for -t option is not described in the doc. Looking at the code (Count.java), the list of possible parameters are either empty string (="all"), "all", "ram_disk", "ssd", "disk" or "archive" (caseless)
      1. HDFS-11061.001.patch
        2 kB
        Yiqun Lin
      2. HDFS-11061.002.patch
        4 kB
        Yiqun Lin
      3. HDFS-11061.003.patch
        4 kB
        Yiqun Lin
      4. HDFS-11061.004.patch
        4 kB
        Yiqun Lin

        Activity

        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Wei-Chiu Chuang for the commit!

        Show
        linyiqun Yiqun Lin added a comment - Thanks Wei-Chiu Chuang for the commit!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10724 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10724/)
        HDFS-11061. Update dfs -count -t command line help and documentation. (weichiu: rev 112f04eb1b771e410ffd232a46e0ee2bc7b99d06)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java
        • (edit) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10724 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10724/ ) HDFS-11061 . Update dfs -count -t command line help and documentation. (weichiu: rev 112f04eb1b771e410ffd232a46e0ee2bc7b99d06) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Count.java (edit) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestCount.java
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Committed patch 004 to trunk, branch-2 and branch-2.8.
        Thanks Yiqun Lin for contributing the patch and Vinayakumar B and Xiaoyu Yao for review!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Committed patch 004 to trunk, branch-2 and branch-2.8. Thanks Yiqun Lin for contributing the patch and Vinayakumar B and Xiaoyu Yao for review!
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        +1. The failed test are flaky, related to this patch.

        Show
        jojochuang Wei-Chiu Chuang added a comment - +1. The failed test are flaky, related to this patch.
        Hide
        linyiqun Yiqun Lin added a comment -

        The asf warning is not related. Filed YARN-5794 to track that.

        Show
        linyiqun Yiqun Lin added a comment - The asf warning is not related. Filed YARN-5794 to track that.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 52s trunk passed
        +1 compile 7m 15s trunk passed
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 1m 0s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 20s trunk passed
        +1 javadoc 0m 41s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 6m 57s the patch passed
        +1 javac 6m 57s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 29s the patch passed
        +1 javadoc 0m 41s the patch passed
        -1 unit 6m 57s hadoop-common in the patch failed.
        -1 asflicense 14m 27s The patch generated 4 ASF License warnings.
        51m 18s



        Reason Tests
        Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11061
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835709/HDFS-11061.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3b68d7d2344c 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 57187fd
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17336/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17336/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/17336/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17336/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 52s trunk passed +1 compile 7m 15s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 57s the patch passed +1 javac 6m 57s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 29s the patch passed +1 javadoc 0m 41s the patch passed -1 unit 6m 57s hadoop-common in the patch failed. -1 asflicense 14m 27s The patch generated 4 ASF License warnings. 51m 18s Reason Tests Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11061 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835709/HDFS-11061.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3b68d7d2344c 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 57187fd Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17336/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17336/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/17336/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17336/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 13s trunk passed
        +1 compile 7m 10s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 22s trunk passed
        +1 javadoc 0m 43s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 7m 15s the patch passed
        +1 javac 7m 15s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 32s the patch passed
        +1 javadoc 0m 45s the patch passed
        +1 unit 8m 18s hadoop-common in the patch passed.
        -1 asflicense 15m 22s The patch generated 4 ASF License warnings.
        54m 27s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11061
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835709/HDFS-11061.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b2d2d287a346 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4df8ed6
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17335/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/17335/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17335/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 13s trunk passed +1 compile 7m 10s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 22s trunk passed +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 7m 15s the patch passed +1 javac 7m 15s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 8m 18s hadoop-common in the patch passed. -1 asflicense 15m 22s The patch generated 4 ASF License warnings. 54m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11061 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835709/HDFS-11061.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b2d2d287a346 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4df8ed6 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17335/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/17335/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17335/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment - - edited

        Thanks Wei-Chiu Chuang and Xiaoyu Yao for the review. Post a new patch to address the comments. In the v004 patch, I make a additional change.
        From

        It can also pass the value '' or 'all' to specify all the storage types.
        

        To

        It can also pass the value '', 'all' or 'ALL' to specify all the storage types.
        
        Show
        linyiqun Yiqun Lin added a comment - - edited Thanks Wei-Chiu Chuang and Xiaoyu Yao for the review. Post a new patch to address the comments. In the v004 patch, I make a additional change. From It can also pass the value '' or 'all' to specify all the storage types. To It can also pass the value '', 'all' or 'ALL' to specify all the storage types.
        Hide
        xyao Xiaoyu Yao added a comment -

        Agree with Wei-Chiu Chuang regarding case-insensitive usage of ALL in FileSystemShell.md. +1 after that is fixed.

        Show
        xyao Xiaoyu Yao added a comment - Agree with Wei-Chiu Chuang regarding case-insensitive usage of ALL in FileSystemShell.md. +1 after that is fixed.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hi Yiqun Lin thanks for working on the patch. I think the v03 patch looks mostly good to me.
        There's only one nit that I spotted:
        In FileSystemShell.md:

        that can be used in -t option(case insensitive except "" and "all"):

        I am pretty sure "ALL" can be specified as well.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Hi Yiqun Lin thanks for working on the patch. I think the v03 patch looks mostly good to me. There's only one nit that I spotted: In FileSystemShell.md: that can be used in -t option(case insensitive except "" and "all"): I am pretty sure "ALL" can be specified as well.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 35s trunk passed
        +1 compile 7m 38s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 1m 6s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 34s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 42s the patch passed
        +1 compile 8m 0s the patch passed
        +1 javac 8m 0s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 45s the patch passed
        +1 javadoc 0m 46s the patch passed
        +1 unit 9m 17s hadoop-common in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        42m 42s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11061
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835549/HDFS-11061.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2b68e0d0a0a1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4e403de
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17321/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17321/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 35s trunk passed +1 compile 7m 38s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 42s the patch passed +1 compile 8m 0s the patch passed +1 javac 8m 0s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 46s the patch passed +1 unit 9m 17s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 42m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11061 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835549/HDFS-11061.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2b68e0d0a0a1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4e403de Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17321/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17321/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Make a minor change on v003 patch. Reupload the patch.

        Show
        linyiqun Yiqun Lin added a comment - Make a minor change on v003 patch. Reupload the patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 17s trunk passed
        +1 compile 7m 15s trunk passed
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 21s trunk passed
        +1 javadoc 0m 40s trunk passed
        -1 mvninstall 0m 32s hadoop-common in the patch failed.
        -1 compile 0m 51s root in the patch failed.
        -1 javac 0m 51s root in the patch failed.
        -0 checkstyle 0m 19s hadoop-common-project/hadoop-common: The patch generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
        -1 mvnsite 0m 34s hadoop-common in the patch failed.
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 20s hadoop-common in the patch failed.
        +1 javadoc 0m 38s the patch passed
        -1 unit 0m 37s hadoop-common in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        23m 7s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11061
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835532/HDFS-11061.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d67a6960a134 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 77f2684
        Default Java 1.8.0_101
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/patch-compile-root.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/patch-compile-root.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17320/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17320/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 17s trunk passed +1 compile 7m 15s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 21s trunk passed +1 javadoc 0m 40s trunk passed -1 mvninstall 0m 32s hadoop-common in the patch failed. -1 compile 0m 51s root in the patch failed. -1 javac 0m 51s root in the patch failed. -0 checkstyle 0m 19s hadoop-common-project/hadoop-common: The patch generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13) -1 mvnsite 0m 34s hadoop-common in the patch failed. +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 20s hadoop-common in the patch failed. +1 javadoc 0m 38s the patch passed -1 unit 0m 37s hadoop-common in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 23m 7s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11061 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835532/HDFS-11061.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d67a6960a134 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 77f2684 Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/patch-compile-root.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17320/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17320/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17320/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Vinayakumar B for the comments. Post a new patch to correct the sentence.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Vinayakumar B for the comments. Post a new patch to correct the sentence.
        Hide
        vinayrpet Vinayakumar B added a comment - - edited
                 + "If a comma-separated list of storage types is given after the -t option, \n"
                 + "it displays the quota and usage for the specified types. \n"
                 + "Otherwise, it displays the quota and usage for all the storage \n"
        -        + "types that support quota \n"
        +        + "types that support quota. The list of possible storage "
        +        + "types(case insensitive):\n"
        +        + "empty string, all, ram_disk, ssd, disk and archive.\n"
        

        Empty string, is nothing but, only "-t" switch is given, but not any values after that. The result is same as 'all' passed as value for -t. So, this can be mentioned explicitly. But, 'empty string' and 'all' are not storagetypes. i.e. when 'all' cannot be combined with storagetypes. But actual storagetypes can be comma separated multiple values.
        I think this sentence can be corrected more.

        Show
        vinayrpet Vinayakumar B added a comment - - edited + "If a comma-separated list of storage types is given after the -t option, \n" + "it displays the quota and usage for the specified types. \n" + "Otherwise, it displays the quota and usage for all the storage \n" - + "types that support quota \n" + + "types that support quota. The list of possible storage " + + "types( case insensitive):\n" + + "empty string, all, ram_disk, ssd, disk and archive.\n" Empty string, is nothing but, only "-t" switch is given, but not any values after that. The result is same as 'all' passed as value for -t. So, this can be mentioned explicitly. But, 'empty string' and 'all' are not storagetypes. i.e. when 'all' cannot be combined with storagetypes. But actual storagetypes can be comma separated multiple values. I think this sentence can be corrected more.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 3s trunk passed
        +1 compile 7m 23s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 1m 5s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 23s trunk passed
        +1 javadoc 0m 42s trunk passed
        +1 mvninstall 0m 38s the patch passed
        +1 compile 9m 8s the patch passed
        +1 javac 9m 8s the patch passed
        +1 checkstyle 0m 22s the patch passed
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 42s the patch passed
        +1 javadoc 0m 50s the patch passed
        +1 unit 10m 19s hadoop-common in the patch passed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        43m 45s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11061
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835475/HDFS-11061.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux fc44fc7d0a08 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9f32364
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17309/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17309/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 3s trunk passed +1 compile 7m 23s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 5s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 42s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 9m 8s the patch passed +1 javac 9m 8s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 42s the patch passed +1 javadoc 0m 50s the patch passed +1 unit 10m 19s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 43m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11061 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835475/HDFS-11061.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fc44fc7d0a08 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9f32364 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17309/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17309/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        The failed test is related, post a new patch to make a fix.

        Show
        linyiqun Yiqun Lin added a comment - The failed test is related, post a new patch to make a fix.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 37s trunk passed
        +1 compile 8m 48s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 1m 10s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 34s trunk passed
        +1 javadoc 0m 54s trunk passed
        +1 mvninstall 0m 50s the patch passed
        +1 compile 9m 8s the patch passed
        +1 javac 9m 8s the patch passed
        +1 checkstyle 0m 28s the patch passed
        +1 mvnsite 1m 15s the patch passed
        +1 mvneclipse 0m 17s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 49s the patch passed
        +1 javadoc 0m 54s the patch passed
        -1 unit 9m 20s hadoop-common in the patch failed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        47m 31s



        Reason Tests
        Failed junit tests hadoop.fs.shell.TestCount



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11061
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835462/HDFS-11061.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 58b5fa982a7a 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9f32364
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17306/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17306/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17306/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 37s trunk passed +1 compile 8m 48s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 54s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 9m 8s the patch passed +1 javac 9m 8s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 54s the patch passed -1 unit 9m 20s hadoop-common in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 47m 31s Reason Tests Failed junit tests hadoop.fs.shell.TestCount Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11061 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835462/HDFS-11061.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 58b5fa982a7a 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9f32364 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17306/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17306/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17306/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 14s trunk passed
        +1 compile 7m 20s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 29s trunk passed
        +1 javadoc 0m 42s trunk passed
        +1 mvninstall 0m 35s the patch passed
        +1 compile 7m 20s the patch passed
        +1 javac 7m 20s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 56s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 29s the patch passed
        +1 javadoc 0m 42s the patch passed
        -1 unit 15m 42s hadoop-common in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        46m 54s



        Reason Tests
        Failed junit tests hadoop.fs.shell.TestCount



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11061
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835460/HDFS-11061.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f27ec5338e68 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 22ff0ef
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17305/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17305/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17305/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 14s trunk passed +1 compile 7m 20s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 29s trunk passed +1 javadoc 0m 42s trunk passed +1 mvninstall 0m 35s the patch passed +1 compile 7m 20s the patch passed +1 javac 7m 20s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 29s the patch passed +1 javadoc 0m 42s the patch passed -1 unit 15m 42s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 46m 54s Reason Tests Failed junit tests hadoop.fs.shell.TestCount Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11061 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835460/HDFS-11061.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f27ec5338e68 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 22ff0ef Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17305/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17305/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17305/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Wei-Chiu Chuang for reporting this, it's a good catch. I prefer to update related documentations in this JIRA. Attach a initial patch. Thanks for reviewing,

        Show
        linyiqun Yiqun Lin added a comment - Thanks Wei-Chiu Chuang for reporting this, it's a good catch. I prefer to update related documentations in this JIRA. Attach a initial patch. Thanks for reviewing,

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            jojochuang Wei-Chiu Chuang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development