Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11055

Update default-log4j.properties for httpfs to imporve test logging

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: httpfs, test
    • Labels:
      None

      Description

      I am debugging a httpfs issue but existing log4j.properties does not show execution logs in editors such as IntelliJ or in Jenkins. This makes debugging impossible.

      File this jira to improve this.

      1. HDFS-11055.001.patch
        1.0 kB
        Wei-Chiu Chuang

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10710 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10710/)
        HDFS-11055. Update default-log4j.properties for httpfs to imporve test (weichiu: rev 31ff42b51037632ec871f29efc0fa894e1b738d0)

        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/resources/default-log4j.properties
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10710 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10710/ ) HDFS-11055 . Update default-log4j.properties for httpfs to imporve test (weichiu: rev 31ff42b51037632ec871f29efc0fa894e1b738d0) (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/resources/default-log4j.properties
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Committed to trunk, branch-2 and branch-2.8.
        Thanks a lot to Xiao Chen and Xiaobing Zhou for the review!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Committed to trunk, branch-2 and branch-2.8. Thanks a lot to Xiao Chen and Xiaobing Zhou for the review!
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Committing the patch.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Committing the patch.
        Hide
        xiaochen Xiao Chen added a comment -

        SGTM. +1, thanks Wei-Chiu Chuang for the contribution and Xiaobing Zhou for the review.

        Show
        xiaochen Xiao Chen added a comment - SGTM. +1, thanks Wei-Chiu Chuang for the contribution and Xiaobing Zhou for the review.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Good idea Xiao Chen
        This change should only affect tests under hadoop-hdfs-project/hadoop-hdfs-httpfs/
        I ran all these tests locally and all 368 tests passed locally.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Good idea Xiao Chen This change should only affect tests under hadoop-hdfs-project/hadoop-hdfs-httpfs/ I ran all these tests locally and all 368 tests passed locally.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Wei-Chiu Chuang for the patch! Change LGTM. Having more logs in tests won't harm.

        I'm slightly uncomfortable on the pre-commit though, since it didn't run any actual tests. I'm +1 if you can confirm with this change, all existing tests can pass. (Because I remember sometimes tests could depend on stdout, like shell tests / log tests etc.)

        Show
        xiaochen Xiao Chen added a comment - Thanks Wei-Chiu Chuang for the patch! Change LGTM. Having more logs in tests won't harm. I'm slightly uncomfortable on the pre-commit though, since it didn't run any actual tests. I'm +1 if you can confirm with this change, all existing tests can pass. (Because I remember sometimes tests could depend on stdout, like shell tests / log tests etc.)
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Then, +1 the patch. Thanks.

        Show
        xiaobingo Xiaobing Zhou added a comment - Then, +1 the patch. Thanks.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks for review Xiaobing Zhou.
        I think ALL has too verbose. Similar sub components such as kms uses "log4j.rootLogger=INFO, stdout" so I think it's more appropriate that way.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks for review Xiaobing Zhou . I think ALL has too verbose. Similar sub components such as kms uses "log4j.rootLogger=INFO, stdout" so I think it's more appropriate that way.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thanks Wei-Chiu Chuang for the work. The patch LGTM. Do you want to keep ALL as default instead of INFO?

        Show
        xiaobingo Xiaobing Zhou added a comment - Thanks Wei-Chiu Chuang for the work. The patch LGTM. Do you want to keep ALL as default instead of INFO?
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 52s trunk passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 0m 15s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        10m 27s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11055
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835217/HDFS-11055.001.patch
        Optional Tests asflicense unit
        uname Linux 4a6af96ba612 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 084bdab
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17286/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17286/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 52s trunk passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 0m 15s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 10m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11055 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835217/HDFS-11055.001.patch Optional Tests asflicense unit uname Linux 4a6af96ba612 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 084bdab Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17286/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17286/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Attach patch 001

        Show
        jojochuang Wei-Chiu Chuang added a comment - Attach patch 001

          People

          • Assignee:
            jojochuang Wei-Chiu Chuang
            Reporter:
            jojochuang Wei-Chiu Chuang
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development