Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11050

Change log level to 'warn' when ssl initialization fails and defaults to DEFAULT_TIMEOUT_CONN_CONFIGURATOR

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In URLConnectionFactory, initialization failure is caught, logged as a debug and then init-ed to default connection silently. This JIRA changes the log level warn to cover such cases and warn against this failure.

      1. HDFS-11050.001.patch
        2 kB
        Kuhu Shukla
      2. HDFS-11050.002.patch
        2 kB
        Kuhu Shukla

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10685 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10685/)
        HDFS-11050. Change log level to 'warn' when ssl initialization fails and (kihwal: rev ce6bbfb23c9aafaf1aaeaeceba88286d4270b316)

        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/web/TestURLConnectionFactory.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10685 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10685/ ) HDFS-11050 . Change log level to 'warn' when ssl initialization fails and (kihwal: rev ce6bbfb23c9aafaf1aaeaeceba88286d4270b316) (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/web/TestURLConnectionFactory.java
        Hide
        kihwal Kihwal Lee added a comment -

        Thanks for working on the issue, Kuhu Shukla. I've committed this to trunk, branch-2 and branch-2.8.

        Show
        kihwal Kihwal Lee added a comment - Thanks for working on the issue, Kuhu Shukla . I've committed this to trunk, branch-2 and branch-2.8.
        Hide
        kihwal Kihwal Lee added a comment -

        +1 the patch looks good. Xiaobing Zhou, I think the unit test is adequate as is.

        Show
        kihwal Kihwal Lee added a comment - +1 the patch looks good. Xiaobing Zhou , I think the unit test is adequate as is.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thank you for the work Kihwal Lee. It looks good to me. Do you also want to add "Fallback to system-generic settings." to the assert?

        Show
        xiaobingo Xiaobing Zhou added a comment - Thank you for the work Kihwal Lee . It looks good to me. Do you also want to add "Fallback to system-generic settings." to the assert?
        Hide
        kshukla Kuhu Shukla added a comment -

        Kihwal Lee, request for comments/review.Thanks a lot!

        Show
        kshukla Kuhu Shukla added a comment - Kihwal Lee , request for comments/review.Thanks a lot!
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 28s trunk passed
        +1 compile 0m 30s trunk passed
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 34s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 29s trunk passed
        +1 javadoc 0m 24s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 0m 38s the patch passed
        +1 javac 0m 38s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvnsite 0m 42s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 55s the patch passed
        +1 javadoc 0m 23s the patch passed
        +1 unit 1m 8s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        18m 49s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11050
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835210/HDFS-11050.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8a281e56cbbb 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 86c735b
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17282/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17282/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 28s trunk passed +1 compile 0m 30s trunk passed +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 29s trunk passed +1 javadoc 0m 24s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 0m 38s the patch passed +1 javac 0m 38s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 42s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 55s the patch passed +1 javadoc 0m 23s the patch passed +1 unit 1m 8s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 18m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11050 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835210/HDFS-11050.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8a281e56cbbb 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 86c735b Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17282/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17282/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        kshukla Kuhu Shukla added a comment -

        Fixing test to not rely on stdout.

        Show
        kshukla Kuhu Shukla added a comment - Fixing test to not rely on stdout.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 2s trunk passed
        +1 compile 0m 31s trunk passed
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 37s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 38s trunk passed
        +1 javadoc 0m 22s trunk passed
        +1 mvninstall 0m 34s the patch passed
        +1 compile 0m 30s the patch passed
        +1 javac 0m 30s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 34s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 44s the patch passed
        +1 javadoc 0m 19s the patch passed
        -1 unit 1m 3s hadoop-hdfs-client in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        18m 31s



        Reason Tests
        Failed junit tests hadoop.hdfs.web.TestURLConnectionFactory



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11050
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835162/HDFS-11050.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4ff1c4456def 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f6367c5
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17275/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17275/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17275/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 2s trunk passed +1 compile 0m 31s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 38s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 34s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 44s the patch passed +1 javadoc 0m 19s the patch passed -1 unit 1m 3s hadoop-hdfs-client in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 18m 31s Reason Tests Failed junit tests hadoop.hdfs.web.TestURLConnectionFactory Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11050 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835162/HDFS-11050.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4ff1c4456def 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f6367c5 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17275/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17275/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17275/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        kshukla Kuhu Shukla added a comment -

        Initial patch with the log level change.

        Show
        kshukla Kuhu Shukla added a comment - Initial patch with the log level change.
        Hide
        kihwal Kihwal Lee added a comment -

        It was part of HDFS-5538. While loading ssl config is fine, silently ignoring errors and falling back to the insecure mode is not acceptable. Also it has a side effect of ignoring connection-related configs. If ssl is misconfigured, the user should be informed.

        Show
        kihwal Kihwal Lee added a comment - It was part of HDFS-5538 . While loading ssl config is fine, silently ignoring errors and falling back to the insecure mode is not acceptable. Also it has a side effect of ignoring connection-related configs. If ssl is misconfigured, the user should be informed.

          People

          • Assignee:
            kshukla Kuhu Shukla
            Reporter:
            kshukla Kuhu Shukla
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development