Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: logging
    • Labels:
      None

      Description

      When HADOOP_SECURE_DN_USER and HADOOP_PRIVILEGED_NFS_USER are not set, there are duplicate '-' in the log name.

      [centos@ip-172-31-21-203 logs]$ ls *.log
      hadoop--centos-datanode-ip-172-31-21-203.ap-northeast-1.compute.internal.log
      hadoop--centos-namenode-ip-172-31-21-203.ap-northeast-1.compute.internal.log
      hadoop-centos-nodemanager-ip-172-31-21-203.ap-northeast-1.compute.internal.log
      hadoop-centos-resourcemanager-ip-172-31-21-203.ap-northeast-1.compute.internal.log
      

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10668 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10668/)
        HDFS-11046. Duplicate '-' in the daemon log name. (aajisaka: rev dc3272bfe8ceebe2f56bd6ab3be7bdca6185dc00)

        • (edit) hadoop-common-project/hadoop-common/src/main/bin/hadoop
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10668 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10668/ ) HDFS-11046 . Duplicate '-' in the daemon log name. (aajisaka: rev dc3272bfe8ceebe2f56bd6ab3be7bdca6185dc00) (edit) hadoop-common-project/hadoop-common/src/main/bin/hadoop (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed to trunk. Thanks Andrew Wang for the review!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed to trunk. Thanks Andrew Wang for the review!
        Hide
        andrew.wang Andrew Wang added a comment -

        +1 thanks Akira, I checked the other usages and the yarn and mapred scripts are already doing this correctly.

        Show
        andrew.wang Andrew Wang added a comment - +1 thanks Akira, I checked the other usages and the yarn and mapred scripts are already doing this correctly.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        0 shelldocs 0m 4s Shelldocs was not available.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 1m 35s Maven dependency ordering for branch
        +1 mvninstall 6m 52s trunk passed
        +1 mvnsite 1m 53s trunk passed
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvnsite 1m 42s the patch passed
        +1 shellcheck 0m 12s There were no new shellcheck issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 1m 56s hadoop-common in the patch passed.
        +1 unit 0m 46s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        16m 5s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11046
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834884/HDFS-11046.01.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux 8dc4c40fc68c 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d0a3479
        shellcheck v0.4.4
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17261/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17261/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. 0 shelldocs 0m 4s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 35s Maven dependency ordering for branch +1 mvninstall 6m 52s trunk passed +1 mvnsite 1m 53s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvnsite 1m 42s the patch passed +1 shellcheck 0m 12s There were no new shellcheck issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 1m 56s hadoop-common in the patch passed. +1 unit 0m 46s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 16m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11046 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834884/HDFS-11046.01.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 8dc4c40fc68c 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d0a3479 shellcheck v0.4.4 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17261/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17261/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        First HADOOP_SUBCMD_SECURESERVICE is set to "false" by hadoop-functions.sh. When the variable is false, the else branch is not used in the following code.

        hdfs
          HADOOP_ROOT_LOGGER="${HADOOP_DAEMON_ROOT_LOGGER}"
          if [[ -n "${HADOOP_SUBCMD_SECURESERVICE}" ]]; then
            # shellcheck disable=SC2034
            HADOOP_LOGFILE="hadoop-${HADOOP_SECURE_USER}-${HADOOP_IDENT_STRING}-${HADOOP_SUBCMD}-${HOSTNAME}.log"
          else
            # shellcheck disable=SC2034
            HADOOP_LOGFILE="hadoop-${HADOOP_IDENT_STRING}-${HADOOP_SUBCMD}-${HOSTNAME}.log"
          fi
        

        I wrote a patch to use [[ "${HADOOP_SUBCMD_SECURESERVICE}" = true ]] instead.

        Show
        ajisakaa Akira Ajisaka added a comment - First HADOOP_SUBCMD_SECURESERVICE is set to "false" by hadoop-functions.sh. When the variable is false, the else branch is not used in the following code. hdfs HADOOP_ROOT_LOGGER= "${HADOOP_DAEMON_ROOT_LOGGER}" if [[ -n "${HADOOP_SUBCMD_SECURESERVICE}" ]]; then # shellcheck disable=SC2034 HADOOP_LOGFILE= "hadoop-${HADOOP_SECURE_USER}-${HADOOP_IDENT_STRING}-${HADOOP_SUBCMD}-${HOSTNAME}.log" else # shellcheck disable=SC2034 HADOOP_LOGFILE= "hadoop-${HADOOP_IDENT_STRING}-${HADOOP_SUBCMD}-${HOSTNAME}.log" fi I wrote a patch to use [[ "${HADOOP_SUBCMD_SECURESERVICE}" = true ]] instead.

          People

          • Assignee:
            ajisakaa Akira Ajisaka
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development