Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11042

Add missing cleanupSSLConfig() call for tests that use setupSSLConfig()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Tests that setup SSLConfigs can leave conf-files lingering unless they are cleaned up via KeyStoreTestUtil.cleanupSSLConfig call. Some tests are missing this call.

      If the cleanup method is not called explicitly, a modified ssl-client.xml is left in test-classes, affecting subsequent test cases. E.g. TestWebHdfsTimeouts would randomly fail, because the expected configuration fails to initialize and the default one with 60 second timeout was used.

      1. HDFS-11042.002.patch
        13 kB
        Kuhu Shukla
      2. HDFS-11042.001.patch
        13 kB
        Kuhu Shukla

        Issue Links

          Activity

          Hide
          kshukla Kuhu Shukla added a comment -

          Thank you Kihwal Lee. Opened HDFS-11050 for :

          When the SSL init fails, it falls back to insecure default silently. We should probably change the log level from debug to warn.

          Show
          kshukla Kuhu Shukla added a comment - Thank you Kihwal Lee . Opened HDFS-11050 for : When the SSL init fails, it falls back to insecure default silently. We should probably change the log level from debug to warn.
          Hide
          kihwal Kihwal Lee added a comment -

          E.g. TestWebHdfsTimeouts would randomly fail, because the expected configuration fails to initialize and the default one with 60 second timeout was used.

          Currently this happens silently. When the SSL init fails, it falls back to insecure default silently. We should probably change the log level from debug to warn.

          Show
          kihwal Kihwal Lee added a comment - E.g. TestWebHdfsTimeouts would randomly fail, because the expected configuration fails to initialize and the default one with 60 second timeout was used. Currently this happens silently. When the SSL init fails, it falls back to insecure default silently. We should probably change the log level from debug to warn.
          Hide
          kihwal Kihwal Lee added a comment -

          Thanks for fixing this, Kuhu Shukla. I've committed this to trunk through branch-2.8.

          Show
          kihwal Kihwal Lee added a comment - Thanks for fixing this, Kuhu Shukla . I've committed this to trunk through branch-2.8.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10665 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10665/)
          HDFS-11042. Add missing cleanupSSLConfig() call for tests that use (kihwal: rev b18f35f097a3ee33f449e506676961f9b9456bbd)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSecureEncryptionZoneWithKMS.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/TestHttpFSFWithSWebhdfsFileSystem.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestSecureNNWithQJM.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTokens.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeRespectsBindHostKeys.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/SaslDataTransferTestCase.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10665 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10665/ ) HDFS-11042 . Add missing cleanupSSLConfig() call for tests that use (kihwal: rev b18f35f097a3ee33f449e506676961f9b9456bbd) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSecureEncryptionZoneWithKMS.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/TestHttpFSFWithSWebhdfsFileSystem.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestSecureNNWithQJM.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTokens.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeRespectsBindHostKeys.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/SaslDataTransferTestCase.java
          Hide
          kihwal Kihwal Lee added a comment -

          +1 looks good.

          Show
          kihwal Kihwal Lee added a comment - +1 looks good.
          Hide
          kshukla Kuhu Shukla added a comment -

          Kihwal Lee, Request for comments/review. Thanks a lot!

          Show
          kshukla Kuhu Shukla added a comment - Kihwal Lee , Request for comments/review. Thanks a lot!
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
          0 mvndep 0m 27s Maven dependency ordering for branch
          +1 mvninstall 6m 49s trunk passed
          +1 compile 1m 19s trunk passed
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 1m 15s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          +1 findbugs 2m 3s trunk passed
          +1 javadoc 0m 50s trunk passed
          0 mvndep 0m 6s Maven dependency ordering for patch
          +1 mvninstall 1m 13s the patch passed
          +1 compile 1m 15s the patch passed
          +1 javac 1m 15s the patch passed
          -0 checkstyle 0m 29s hadoop-hdfs-project: The patch generated 4 new + 248 unchanged - 2 fixed = 252 total (was 250)
          +1 mvnsite 1m 10s the patch passed
          +1 mvneclipse 0m 19s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 14s the patch passed
          +1 javadoc 0m 48s the patch passed
          +1 unit 58m 8s hadoop-hdfs in the patch passed.
          +1 unit 3m 28s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          84m 35s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-11042
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834762/HDFS-11042.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e4197ea8cfcd 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / be72372
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17257/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17257/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17257/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. 0 mvndep 0m 27s Maven dependency ordering for branch +1 mvninstall 6m 49s trunk passed +1 compile 1m 19s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 15s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 2m 3s trunk passed +1 javadoc 0m 50s trunk passed 0 mvndep 0m 6s Maven dependency ordering for patch +1 mvninstall 1m 13s the patch passed +1 compile 1m 15s the patch passed +1 javac 1m 15s the patch passed -0 checkstyle 0m 29s hadoop-hdfs-project: The patch generated 4 new + 248 unchanged - 2 fixed = 252 total (was 250) +1 mvnsite 1m 10s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 14s the patch passed +1 javadoc 0m 48s the patch passed +1 unit 58m 8s hadoop-hdfs in the patch passed. +1 unit 3m 28s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 84m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11042 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834762/HDFS-11042.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e4197ea8cfcd 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / be72372 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17257/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17257/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17257/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
          0 mvndep 0m 34s Maven dependency ordering for branch
          -1 mvninstall 4m 22s root in trunk failed.
          +1 compile 1m 20s trunk passed
          +1 checkstyle 0m 31s trunk passed
          +1 mvnsite 1m 13s trunk passed
          +1 mvneclipse 0m 21s trunk passed
          +1 findbugs 2m 3s trunk passed
          +1 javadoc 0m 48s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          -1 mvninstall 0m 29s hadoop-hdfs in the patch failed.
          -1 compile 0m 49s hadoop-hdfs-project in the patch failed.
          -1 javac 0m 49s hadoop-hdfs-project in the patch failed.
          -0 checkstyle 0m 31s hadoop-hdfs-project: The patch generated 5 new + 248 unchanged - 2 fixed = 253 total (was 250)
          -1 mvnsite 0m 31s hadoop-hdfs in the patch failed.
          +1 mvneclipse 0m 19s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 12s hadoop-hdfs in the patch failed.
          +1 javadoc 0m 52s the patch passed
          -1 unit 0m 34s hadoop-hdfs in the patch failed.
          +1 unit 3m 56s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          22m 52s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-11042
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834736/HDFS-11042.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 274e409c1ca4 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 44eb2bd
          Default Java 1.8.0_101
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/patch-compile-hadoop-hdfs-project.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/patch-compile-hadoop-hdfs-project.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17256/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17256/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. 0 mvndep 0m 34s Maven dependency ordering for branch -1 mvninstall 4m 22s root in trunk failed. +1 compile 1m 20s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 13s trunk passed +1 mvneclipse 0m 21s trunk passed +1 findbugs 2m 3s trunk passed +1 javadoc 0m 48s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch -1 mvninstall 0m 29s hadoop-hdfs in the patch failed. -1 compile 0m 49s hadoop-hdfs-project in the patch failed. -1 javac 0m 49s hadoop-hdfs-project in the patch failed. -0 checkstyle 0m 31s hadoop-hdfs-project: The patch generated 5 new + 248 unchanged - 2 fixed = 253 total (was 250) -1 mvnsite 0m 31s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 12s hadoop-hdfs in the patch failed. +1 javadoc 0m 52s the patch passed -1 unit 0m 34s hadoop-hdfs in the patch failed. +1 unit 3m 56s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 22m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11042 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834736/HDFS-11042.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 274e409c1ca4 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 44eb2bd Default Java 1.8.0_101 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/patch-compile-hadoop-hdfs-project.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/patch-compile-hadoop-hdfs-project.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17256/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17256/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17256/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Patch that addresses only the hdfs-project tests that need the fix.

          Show
          kshukla Kuhu Shukla added a comment - Patch that addresses only the hdfs-project tests that need the fix.

            People

            • Assignee:
              kshukla Kuhu Shukla
              Reporter:
              kshukla Kuhu Shukla
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development