Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: datanode, test
    • Labels:
      None

      Description

      There are several cases to add in TestDataNodeVolumeFailure:

      • DataNode should not start in case of volumes failure
      • DataNode should not start in case of lacking data dir read/write permission
      • ...
      1. HDFS-11031.000.patch
        6 kB
        Mingliang Liu
      2. HDFS-11031.001.patch
        8 kB
        Mingliang Liu
      3. HDFS-11031.002.patch
        6 kB
        Mingliang Liu
      4. HDFS-11031.003.patch
        5 kB
        Mingliang Liu
      5. HDFS-11031.004.patch
        6 kB
        Mingliang Liu
      6. HDFS-11031.005.patch
        6 kB
        Mingliang Liu
      7. HDFS-11031-branch-2.001.patch
        8 kB
        Mingliang Liu
      8. HDFS-11031-branch-2.002.patch
        6 kB
        Mingliang Liu
      9. HDFS-11031-branch-2.003.patch
        5 kB
        Mingliang Liu
      10. HDFS-11031-branch-2.004.patch
        6 kB
        Mingliang Liu
      11. HDFS-11031-branch-2.005.patch
        6 kB
        Mingliang Liu

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 1s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 21s trunk passed
        +1 compile 0m 53s trunk passed
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 50s trunk passed
        +1 javadoc 0m 42s trunk passed
        +1 mvninstall 0m 55s the patch passed
        +1 compile 0m 53s the patch passed
        +1 javac 0m 53s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 57s the patch passed
        +1 javadoc 0m 39s the patch passed
        -1 unit 67m 53s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        89m 6s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11031
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834577/HDFS-11031.000.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ec4acacd2ee7 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 262827c
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17244/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17244/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17244/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 21s trunk passed +1 compile 0m 53s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 50s trunk passed +1 javadoc 0m 42s trunk passed +1 mvninstall 0m 55s the patch passed +1 compile 0m 53s the patch passed +1 javac 0m 53s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 57s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 67m 53s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 89m 6s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11031 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834577/HDFS-11031.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ec4acacd2ee7 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 262827c Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17244/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17244/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17244/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        I'd like to ping Jitendra Nath Pandey for code review.

        Show
        liuml07 Mingliang Liu added a comment - I'd like to ping Jitendra Nath Pandey for code review.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Mingliang Liu thanks for working on this. One straight forward question.
        How about having one common method for all these testcases(can pass dir,fail tolerate-number...) ?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Mingliang Liu thanks for working on this. One straight forward question. How about having one common method for all these testcases(can pass dir,fail tolerate-number...) ?
        Hide
        liuml07 Mingliang Liu added a comment -

        Brahma Reddy Battula that's a good idea. I'll update the patch with a common helper method. Thanks,

        Show
        liuml07 Mingliang Liu added a comment - Brahma Reddy Battula that's a good idea. I'll update the patch with a common helper method. Thanks,
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 46s trunk passed
        +1 compile 0m 54s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 6s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 2m 0s trunk passed
        +1 javadoc 0m 42s trunk passed
        +1 mvninstall 0m 55s the patch passed
        +1 compile 0m 45s the patch passed
        +1 javac 0m 45s the patch passed
        +1 checkstyle 0m 26s the patch passed
        +1 mvnsite 1m 2s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 27s the patch passed
        +1 javadoc 0m 42s the patch passed
        -1 unit 70m 2s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        91m 56s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11031
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834591/HDFS-11031.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 106e6d9a80e8 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 262827c
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17246/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17246/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17246/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 46s trunk passed +1 compile 0m 54s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 2m 0s trunk passed +1 javadoc 0m 42s trunk passed +1 mvninstall 0m 55s the patch passed +1 compile 0m 45s the patch passed +1 javac 0m 45s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 27s the patch passed +1 javadoc 0m 42s the patch passed -1 unit 70m 2s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 91m 56s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11031 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834591/HDFS-11031.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 106e6d9a80e8 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 262827c Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17246/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17246/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17246/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        V2 patch addresses Brahma Reddy Battula's comments.

        Show
        liuml07 Mingliang Liu added a comment - V2 patch addresses Brahma Reddy Battula 's comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 1s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 25s trunk passed
        +1 compile 0m 49s trunk passed
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 41s trunk passed
        +1 javadoc 0m 38s trunk passed
        +1 mvninstall 0m 44s the patch passed
        +1 compile 0m 41s the patch passed
        +1 javac 0m 41s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 47s the patch passed
        +1 javadoc 0m 35s the patch passed
        +1 unit 62m 52s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        81m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11031
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834603/HDFS-11031.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9a0e3b8bcb48 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 754cb4e
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17247/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17247/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 1s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 25s trunk passed +1 compile 0m 49s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 41s trunk passed +1 javadoc 0m 38s trunk passed +1 mvninstall 0m 44s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 35s the patch passed +1 unit 62m 52s hadoop-hdfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 81m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11031 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834603/HDFS-11031.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9a0e3b8bcb48 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 754cb4e Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17247/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17247/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 36s branch-2 passed
        +1 compile 0m 41s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 43s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 26s branch-2 passed
        +1 mvnsite 0m 52s branch-2 passed
        +1 mvneclipse 0m 15s branch-2 passed
        +1 findbugs 1m 54s branch-2 passed
        +1 javadoc 0m 55s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 36s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 44s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.8.0_101
        +1 javac 0m 39s the patch passed
        +1 compile 0m 42s the patch passed with JDK v1.7.0_111
        +1 javac 0m 42s the patch passed
        -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 57 unchanged - 0 fixed = 58 total (was 57)
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 8s the patch passed
        +1 javadoc 0m 52s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 34s the patch passed with JDK v1.7.0_111
        -1 unit 50m 13s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        125m 28s



        Reason Tests
        JDK v1.7.0_111 Failed junit tests hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-11031
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834605/HDFS-11031-branch-2.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux dc44252b42da 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 440a632
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17249/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17249/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17249/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17249/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 36s branch-2 passed +1 compile 0m 41s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 43s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 26s branch-2 passed +1 mvnsite 0m 52s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 1m 54s branch-2 passed +1 javadoc 0m 55s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 36s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 44s the patch passed +1 compile 0m 39s the patch passed with JDK v1.8.0_101 +1 javac 0m 39s the patch passed +1 compile 0m 42s the patch passed with JDK v1.7.0_111 +1 javac 0m 42s the patch passed -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 57 unchanged - 0 fixed = 58 total (was 57) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 34s the patch passed with JDK v1.7.0_111 -1 unit 50m 13s hadoop-hdfs in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 125m 28s Reason Tests JDK v1.7.0_111 Failed junit tests hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-11031 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834605/HDFS-11031-branch-2.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dc44252b42da 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 440a632 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17249/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17249/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17249/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17249/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        Brahma Reddy Battula would you kindly review the patch? Thank,

        Show
        liuml07 Mingliang Liu added a comment - Brahma Reddy Battula would you kindly review the patch? Thank,
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Thanks for updating the path..Overall LGTM.

        Minor nits:

        1) do we require following..?
        import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_DATA_DIR_KEY;

        can't be done like DFSConfigKeys.DFS_DATANODE_DATA_DIR_KEY

        2)Thinking following variable can be plural,as we are configuring two dir's..

        final String newDir = badDataDir.toString() + "," + data5.toString();

        3) we are starting only one DataNode..?

        // bring up one more DataNode
          cluster.startDataNodes(newConf, 1, false, null, null);

        4) can we improve the following..? like...tolerated true if one volume failure allowed

        * @param tolerated allowed one volume failures if true else false
        Show
        brahmareddy Brahma Reddy Battula added a comment - Thanks for updating the path..Overall LGTM. Minor nits: 1) do we require following..? import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_DATA_DIR_KEY; can't be done like DFSConfigKeys.DFS_DATANODE_DATA_DIR_KEY 2)Thinking following variable can be plural,as we are configuring two dir's.. final String newDir = badDataDir.toString() + "," + data5.toString(); 3) we are starting only one DataNode..? // bring up one more DataNode cluster.startDataNodes(newConf, 1, false , null , null ); 4) can we improve the following..? like...tolerated true if one volume failure allowed * @param tolerated allowed one volume failures if true else false
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks Brahma Reddy Battula for your review. The v3 patch addressed all the comments. Specially,

        we are starting only one DataNode..?

        We've started 2 == repl DataNodes in the setUp() @Before method which sets up the mini-cluster. This is based on the existing test class. Here we test the case where one DataNode should behave as expected when one of its disk fails. To make this clearer, I also added two new assertions like following:

            // bring up one more DataNode
            assertEquals(repl, cluster.getDataNodes().size());
            cluster.startDataNodes(newConf, 1, false, null, null);
            assertEquals(repl + 1, cluster.getDataNodes().size());
        
        Show
        liuml07 Mingliang Liu added a comment - Thanks Brahma Reddy Battula for your review. The v3 patch addressed all the comments. Specially, we are starting only one DataNode..? We've started 2 == repl DataNodes in the setUp() @Before method which sets up the mini-cluster. This is based on the existing test class. Here we test the case where one DataNode should behave as expected when one of its disk fails. To make this clearer, I also added two new assertions like following: // bring up one more DataNode assertEquals(repl, cluster.getDataNodes().size()); cluster.startDataNodes(newConf, 1, false , null , null ); assertEquals(repl + 1, cluster.getDataNodes().size());
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 17s trunk passed
        +1 compile 0m 46s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 45s trunk passed
        +1 javadoc 0m 41s trunk passed
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 57 unchanged - 0 fixed = 58 total (was 57)
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 48s the patch passed
        +1 javadoc 0m 39s the patch passed
        -1 unit 71m 30s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        90m 56s



        Reason Tests
        Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
          org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage
          org.apache.hadoop.hdfs.TestLeaseRecovery
          org.apache.hadoop.hdfs.server.namenode.TestFileTruncate
          org.apache.hadoop.hdfs.server.mover.TestStorageMover
          org.apache.hadoop.hdfs.server.mover.TestMover
          org.apache.hadoop.fs.TestUnbuffer
          org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure030
          org.apache.hadoop.hdfs.server.namenode.TestDeleteRace
          org.apache.hadoop.hdfs.server.namenode.TestAuditLogs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11031
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835168/HDFS-11031.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0f563464f01e 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9a8a386
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17276/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17276/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17276/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17276/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 17s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 57 unchanged - 0 fixed = 58 total (was 57) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 71m 30s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 90m 56s Reason Tests Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage   org.apache.hadoop.hdfs.TestLeaseRecovery   org.apache.hadoop.hdfs.server.namenode.TestFileTruncate   org.apache.hadoop.hdfs.server.mover.TestStorageMover   org.apache.hadoop.hdfs.server.mover.TestMover   org.apache.hadoop.fs.TestUnbuffer   org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure030   org.apache.hadoop.hdfs.server.namenode.TestDeleteRace   org.apache.hadoop.hdfs.server.namenode.TestAuditLogs Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11031 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835168/HDFS-11031.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0f563464f01e 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9a8a386 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17276/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17276/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17276/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17276/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        Checkstyle is fixed in new v3 patch and test failures are not related.

        Show
        liuml07 Mingliang Liu added a comment - Checkstyle is fixed in new v3 patch and test failures are not related.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 13m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 50s branch-2 passed
        +1 compile 0m 38s branch-2 passed with JDK v1.8.0_111
        +1 compile 0m 43s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 27s branch-2 passed
        +1 mvnsite 0m 52s branch-2 passed
        +1 mvneclipse 0m 15s branch-2 passed
        +1 findbugs 1m 54s branch-2 passed
        +1 javadoc 0m 54s branch-2 passed with JDK v1.8.0_111
        +1 javadoc 1m 38s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 44s the patch passed
        +1 compile 0m 37s the patch passed with JDK v1.8.0_111
        +1 javac 0m 37s the patch passed
        +1 compile 0m 41s the patch passed with JDK v1.7.0_111
        +1 javac 0m 41s the patch passed
        +1 checkstyle 0m 25s the patch passed
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 6s the patch passed
        +1 javadoc 0m 52s the patch passed with JDK v1.8.0_111
        +1 javadoc 1m 34s the patch passed with JDK v1.7.0_111
        -1 unit 52m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        142m 59s



        Reason Tests
        JDK v1.8.0_111 Failed junit tests hadoop.hdfs.TestDFSShell
        JDK v1.7.0_111 Failed junit tests hadoop.hdfs.TestDFSShell



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-11031
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835170/HDFS-11031-branch-2.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 30cd41e160be 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 590d19c
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17277/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17277/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17277/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 50s branch-2 passed +1 compile 0m 38s branch-2 passed with JDK v1.8.0_111 +1 compile 0m 43s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 27s branch-2 passed +1 mvnsite 0m 52s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 1m 54s branch-2 passed +1 javadoc 0m 54s branch-2 passed with JDK v1.8.0_111 +1 javadoc 1m 38s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 44s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_111 +1 javac 0m 37s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_111 +1 javac 0m 41s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_111 +1 javadoc 1m 34s the patch passed with JDK v1.7.0_111 -1 unit 52m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 142m 59s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.hdfs.TestDFSShell JDK v1.7.0_111 Failed junit tests hadoop.hdfs.TestDFSShell Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-11031 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835170/HDFS-11031-branch-2.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 30cd41e160be 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 590d19c Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17277/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17277/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17277/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Thanks for updating the patch..As these testcase always fails in windows, I am thinking we should add assumeNotWindows, what do you say..? and sorry for missing this comment earlier.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Thanks for updating the patch..As these testcase always fails in windows, I am thinking we should add assumeNotWindows , what do you say..? and sorry for missing this comment earlier.
        Hide
        liuml07 Mingliang Liu added a comment -

        Thank you Brahma Reddy Battula for your testing on Windows. Unfortunately I don't have a Windows dev machine for my testing, and was not aware of the problem. The assumeNotWindows() looks pretty well to skip the newly added tests.

        Perhaps this came up before, FWIW should we set up Jenkins builds for that?

        Show
        liuml07 Mingliang Liu added a comment - Thank you Brahma Reddy Battula for your testing on Windows. Unfortunately I don't have a Windows dev machine for my testing, and was not aware of the problem. The assumeNotWindows() looks pretty well to skip the newly added tests. Perhaps this came up before, FWIW should we set up Jenkins builds for that?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 2s trunk passed
        +1 compile 0m 44s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 49s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 40s trunk passed
        +1 javadoc 0m 41s trunk passed
        +1 mvninstall 0m 52s the patch passed
        +1 compile 0m 46s the patch passed
        +1 javac 0m 46s the patch passed
        +1 checkstyle 0m 25s the patch passed
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 56s the patch passed
        +1 javadoc 0m 38s the patch passed
        -1 unit 52m 19s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        71m 22s



        Reason Tests
        Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
          org.apache.hadoop.hdfs.server.datanode.TestBlockPoolSliceStorage
          org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter
          org.apache.hadoop.hdfs.server.datanode.TestDiskError
          org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics
          org.apache.hadoop.cli.TestHDFSCLI



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11031
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835422/HDFS-11031.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 00a607281cc0 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 22ff0ef
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17300/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17300/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 2s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 49s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 52s the patch passed +1 compile 0m 46s the patch passed +1 javac 0m 46s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 56s the patch passed +1 javadoc 0m 38s the patch passed -1 unit 52m 19s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 71m 22s Reason Tests Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade   org.apache.hadoop.hdfs.server.datanode.TestBlockPoolSliceStorage   org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter   org.apache.hadoop.hdfs.server.datanode.TestDiskError   org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache   org.apache.hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics   org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11031 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835422/HDFS-11031.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 00a607281cc0 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 22ff0ef Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17300/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17300/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 1s branch-2 passed
        +1 compile 0m 42s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 44s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 29s branch-2 passed
        +1 mvnsite 0m 55s branch-2 passed
        +1 mvneclipse 0m 15s branch-2 passed
        +1 findbugs 2m 2s branch-2 passed
        +1 javadoc 0m 57s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 52s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 57s the patch passed
        +1 compile 0m 49s the patch passed with JDK v1.8.0_101
        +1 javac 0m 49s the patch passed
        +1 compile 0m 51s the patch passed with JDK v1.7.0_111
        +1 javac 0m 51s the patch passed
        +1 checkstyle 0m 31s the patch passed
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 26s the patch passed
        +1 javadoc 1m 3s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 45s the patch passed with JDK v1.7.0_111
        +1 unit 48m 48s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        137m 2s



        Reason Tests
        JDK v1.8.0_101 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-11031
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835419/HDFS-11031-branch-2.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0da42ef2bc94 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 2aed61d
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17299/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17299/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 1s branch-2 passed +1 compile 0m 42s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 44s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 29s branch-2 passed +1 mvnsite 0m 55s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 2m 2s branch-2 passed +1 javadoc 0m 57s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 52s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 57s the patch passed +1 compile 0m 49s the patch passed with JDK v1.8.0_101 +1 javac 0m 49s the patch passed +1 compile 0m 51s the patch passed with JDK v1.7.0_111 +1 javac 0m 51s the patch passed +1 checkstyle 0m 31s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 26s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 45s the patch passed with JDK v1.7.0_111 +1 unit 48m 48s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 137m 2s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-11031 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835419/HDFS-11031-branch-2.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0da42ef2bc94 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 2aed61d Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17299/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17299/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        TestFailures are unrelated..Mingliang Liu thanks for updating the patch, LGTM, I will wait for commit till Jitendra Nath Pandey looks into this issue.

        Perhaps this came up before, FWIW should we set up Jenkins builds for that?

        I think, this can good idea. we can start discussion on this and let us see response from others.

        Show
        brahmareddy Brahma Reddy Battula added a comment - TestFailures are unrelated.. Mingliang Liu thanks for updating the patch, LGTM, I will wait for commit till Jitendra Nath Pandey looks into this issue. Perhaps this came up before, FWIW should we set up Jenkins builds for that? I think, this can good idea. we can start discussion on this and let us see response from others.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Jitendra Nath Pandey can you pitch in here(As Ming pinged you first)..? do I go head for commit..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Jitendra Nath Pandey can you pitch in here(As Ming pinged you first)..? do I go head for commit..?
        Hide
        jnp Jitendra Nath Pandey added a comment -

        Brahma Reddy Battula, thanks for reviewing this, please go ahead and commit. +1

        Show
        jnp Jitendra Nath Pandey added a comment - Brahma Reddy Battula , thanks for reviewing this, please go ahead and commit. +1
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Jitendra Nath Pandey thanks for reply..

        Mingliang Liu can you please rebase the patch..? current patch will not apply after HDFS-11030 changes..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Jitendra Nath Pandey thanks for reply.. Mingliang Liu can you please rebase the patch..? current patch will not apply after HDFS-11030 changes..
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks Brahma Reddy Battula for your prompt effort to commit. I rebased the patch and posted the v5 version.

        Show
        liuml07 Mingliang Liu added a comment - Thanks Brahma Reddy Battula for your prompt effort to commit. I rebased the patch and posted the v5 version.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 17s branch-2 passed
        +1 compile 0m 44s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 44s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 28s branch-2 passed
        +1 mvnsite 0m 52s branch-2 passed
        +1 mvneclipse 0m 15s branch-2 passed
        +1 findbugs 2m 0s branch-2 passed
        +1 javadoc 0m 55s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 36s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 44s the patch passed
        +1 compile 0m 54s the patch passed with JDK v1.8.0_101
        +1 javac 0m 54s the patch passed
        +1 compile 1m 20s the patch passed with JDK v1.7.0_111
        +1 javac 1m 20s the patch passed
        +1 checkstyle 0m 55s the patch passed
        +1 mvnsite 1m 31s the patch passed
        +1 mvneclipse 0m 30s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 34s the patch passed
        +1 javadoc 1m 57s the patch passed with JDK v1.8.0_101
        +1 javadoc 3m 10s the patch passed with JDK v1.7.0_111
        +1 unit 49m 1s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        136m 8s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-11031
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836402/HDFS-11031-branch-2.005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e44f4bbb98e4 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 045501a
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17370/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17370/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 17s branch-2 passed +1 compile 0m 44s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 44s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 28s branch-2 passed +1 mvnsite 0m 52s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 2m 0s branch-2 passed +1 javadoc 0m 55s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 36s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 44s the patch passed +1 compile 0m 54s the patch passed with JDK v1.8.0_101 +1 javac 0m 54s the patch passed +1 compile 1m 20s the patch passed with JDK v1.7.0_111 +1 javac 1m 20s the patch passed +1 checkstyle 0m 55s the patch passed +1 mvnsite 1m 31s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 34s the patch passed +1 javadoc 1m 57s the patch passed with JDK v1.8.0_101 +1 javadoc 3m 10s the patch passed with JDK v1.7.0_111 +1 unit 49m 1s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 136m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-11031 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836402/HDFS-11031-branch-2.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e44f4bbb98e4 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 045501a Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17370/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17370/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Committed to trunk,branch-2 and branch-2.8.

        Thanks Mingliang Liu for your contribution and sorry to bother to update so many times..Jitendra Nath Pandey for additional review..

        Note: jenkins did not run on latest trunk patch, I ran locally and only import org.apache.hadoop.test.GenericTestUtils; is diff with 004 where jenkins ran..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Committed to trunk,branch-2 and branch-2.8. Thanks Mingliang Liu for your contribution and sorry to bother to update so many times.. Jitendra Nath Pandey for additional review.. Note: jenkins did not run on latest trunk patch, I ran locally and only import org.apache.hadoop.test.GenericTestUtils; is diff with 004 where jenkins ran..
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10752 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10752/)
        HDFS-11031. Add additional unit test for DataNode startup behavior when (brahma: rev cb5cc0dc53d3543e13b7b7cf9425780ded0538cc)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10752 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10752/ ) HDFS-11031 . Add additional unit test for DataNode startup behavior when (brahma: rev cb5cc0dc53d3543e13b7b7cf9425780ded0538cc) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks for your continuous help and review, Brahma Reddy Battula! Thanks Jitendra Nath Pandey for review and offline discussion.

        Show
        liuml07 Mingliang Liu added a comment - Thanks for your continuous help and review, Brahma Reddy Battula ! Thanks Jitendra Nath Pandey for review and offline discussion.

          People

          • Assignee:
            liuml07 Mingliang Liu
            Reporter:
            liuml07 Mingliang Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development