Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10963

Reduce log level when network topology cannot find enough datanodes.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Credit to Harsh J who reported this.

      The change made by HDFS-10320 now causes all 1-rack cluster to keep printing below:
      WARN org.apache.hadoop.net.NetworkTopology
      Failed to find datanode (scope="" excludedScope="/default").

      This was added in HDFS-10320 to replace an exception that caused NN terminate. A warn log was added. But thinking closely, this should be debug to reduce confusion.

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 1s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 1m 38s Maven dependency ordering for branch
        +1 mvninstall 7m 24s trunk passed
        +1 compile 7m 29s trunk passed
        +1 checkstyle 1m 28s trunk passed
        +1 mvnsite 2m 18s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 3m 47s trunk passed
        +1 javadoc 1m 44s trunk passed
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 38s the patch passed
        +1 compile 9m 48s the patch passed
        +1 javac 9m 48s the patch passed
        +1 checkstyle 1m 28s root: The patch generated 0 new + 100 unchanged - 2 fixed = 100 total (was 102)
        +1 mvnsite 1m 51s the patch passed
        +1 mvneclipse 0m 26s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 26s the patch passed
        +1 javadoc 1m 43s the patch passed
        -1 unit 20m 0s hadoop-common in the patch failed.
        +1 unit 66m 47s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 27s The patch does not generate ASF License warnings.
        135m 19s



        Reason Tests
        Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10963
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831686/HDFS-10963.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2f9244726a8e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 31f8da2
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17016/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17016/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17016/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 38s Maven dependency ordering for branch +1 mvninstall 7m 24s trunk passed +1 compile 7m 29s trunk passed +1 checkstyle 1m 28s trunk passed +1 mvnsite 2m 18s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 47s trunk passed +1 javadoc 1m 44s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 38s the patch passed +1 compile 9m 48s the patch passed +1 javac 9m 48s the patch passed +1 checkstyle 1m 28s root: The patch generated 0 new + 100 unchanged - 2 fixed = 100 total (was 102) +1 mvnsite 1m 51s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 26s the patch passed +1 javadoc 1m 43s the patch passed -1 unit 20m 0s hadoop-common in the patch failed. +1 unit 66m 47s hadoop-hdfs in the patch passed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 135m 19s Reason Tests Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10963 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831686/HDFS-10963.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2f9244726a8e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 31f8da2 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17016/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17016/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17016/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        thanks Xiao Chen and Harsh J.Even I noticed in our cluster.Looks good to me..will commit tomorrow if no objections.

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited thanks Xiao Chen and Harsh J .Even I noticed in our cluster.Looks good to me..will commit tomorrow if no objections.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks for the review, Brahma Reddy Battula.

        Show
        xiaochen Xiao Chen added a comment - Thanks for the review, Brahma Reddy Battula .
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Committed to trunk,branch-2 and branch-2.8. Xiao Chen thanks for your contribution.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Committed to trunk,branch-2 and branch-2.8. Xiao Chen thanks for your contribution.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10553 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10553/)
        HDFS-10963. Reduce log level when network topology cannot find enough (brahma: rev b90fc70d671481564e468550c770c925f25d7db0)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10553 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10553/ ) HDFS-10963 . Reduce log level when network topology cannot find enough (brahma: rev b90fc70d671481564e468550c770c925f25d7db0) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
        Hide
        xiaochen Xiao Chen added a comment -
        Show
        xiaochen Xiao Chen added a comment - Thank you Brahma Reddy Battula !

          People

          • Assignee:
            xiaochen Xiao Chen
            Reporter:
            xiaochen Xiao Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development