Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10920

TestStorageMover#testNoSpaceDisk is failing intermittently

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TestStorageMover#testNoSpaceDisk test case is failing frequently in the build.

      References:
      HDFS-Build_16890, HDFS-Build_16895

        Activity

        Hide
        rakeshr Rakesh R added a comment -

        It looks like the test failed due to not waiting to see all its replicas after DFSTestUtil.createFile(). I'm attaching a patch by adding #waitForAllReplicas function. Also, tried an attempt to replace Thread.sleep(10000). Appreciate reviews, thanks!

        Show
        rakeshr Rakesh R added a comment - It looks like the test failed due to not waiting to see all its replicas after DFSTestUtil.createFile() . I'm attaching a patch by adding #waitForAllReplicas function. Also, tried an attempt to replace Thread.sleep(10000). Appreciate reviews, thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 53s trunk passed
        +1 compile 0m 53s trunk passed
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 1m 7s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 2m 12s trunk passed
        +1 javadoc 1m 0s trunk passed
        +1 mvninstall 0m 58s the patch passed
        +1 compile 0m 50s the patch passed
        +1 javac 0m 50s the patch passed
        +1 checkstyle 0m 27s the patch passed
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 9s the patch passed
        +1 javadoc 1m 1s the patch passed
        +1 unit 62m 49s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        86m 19s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10920
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830663/HDFS-10920-00.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d3429af91faa 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9b0fd01
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16905/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16905/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 53s trunk passed +1 compile 0m 53s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 12s trunk passed +1 javadoc 1m 0s trunk passed +1 mvninstall 0m 58s the patch passed +1 compile 0m 50s the patch passed +1 javac 0m 50s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 9s the patch passed +1 javadoc 1m 1s the patch passed +1 unit 62m 49s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 86m 19s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10920 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830663/HDFS-10920-00.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d3429af91faa 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9b0fd01 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16905/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16905/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        The patch LGTM and +1. Thanks Rakesh for the fix!

        Show
        drankye Kai Zheng added a comment - The patch LGTM and +1. Thanks Rakesh for the fix!
        Hide
        drankye Kai Zheng added a comment -

        Having committed to branch-2, branch-2.8 and trunk branches. Thanks Rakesh R for the contribution!

        Show
        drankye Kai Zheng added a comment - Having committed to branch-2, branch-2.8 and trunk branches. Thanks Rakesh R for the contribution!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10630 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10630/)
        HDFS-10920. TestStorageMover#testNoSpaceDisk is failing intermittently. (kai.zheng: rev d26a1bb9d60f50763887d66399579bac7ca81982)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestStorageMover.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10630 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10630/ ) HDFS-10920 . TestStorageMover#testNoSpaceDisk is failing intermittently. (kai.zheng: rev d26a1bb9d60f50763887d66399579bac7ca81982) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestStorageMover.java
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Kai Zheng for reviewing and commit.

        Show
        rakeshr Rakesh R added a comment - Thanks Kai Zheng for reviewing and commit.

          People

          • Assignee:
            rakeshr Rakesh R
            Reporter:
            rakeshr Rakesh R
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development