Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      It seems that setting up MiniDFSCluser once for all commands test will reduce the total time. To share a global cluster, the tests should use individual test directories to avoid conflict between test cases. Meanwhile, the MiniDFSCluster should not use the default root data directory; or else tests are not able to launch another cluster(s) by default.

      1. HDFS-10893.000.patch
        110 kB
        Mingliang Liu
      2. HDFS-10893.001.patch
        120 kB
        Mingliang Liu
      3. HDFS-10893.002.patch
        120 kB
        Mingliang Liu
      4. HDFS-10893-branch-2.000.patch
        113 kB
        Mingliang Liu
      5. HDFS-10893-branch-2.001.patch
        122 kB
        Mingliang Liu
      6. HDFS-10893-branch-2.002.patch
        122 kB
        Mingliang Liu
      7. HDFS-10893-branch-2.002.patch
        122 kB
        Mingliang Liu

        Activity

        Hide
        liuml07 Mingliang Liu added a comment -

        The v0 patch:

        • Sets up a global MiniDFSCluster for multiple test cases; and closes after tests
        • Sets up test case specific directories
        • Uses a dedicated root directory so that individual tests can launch another cluster without conflict

        Some of the tests are still using local cluster(s) because 1) they need ad hoc configurations 2) they need to restart the cluster 3) they may pollute the cluster state.

        Show
        liuml07 Mingliang Liu added a comment - The v0 patch: Sets up a global MiniDFSCluster for multiple test cases; and closes after tests Sets up test case specific directories Uses a dedicated root directory so that individual tests can launch another cluster without conflict Some of the tests are still using local cluster(s) because 1) they need ad hoc configurations 2) they need to restart the cluster 3) they may pollute the cluster state.
        Hide
        liuml07 Mingliang Liu added a comment -

        The overall running time on my laptop is reduced from 35+ seconds to ~12 seconds.

        Show
        liuml07 Mingliang Liu added a comment - The overall running time on my laptop is reduced from 35+ seconds to ~12 seconds.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 5s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 45s trunk passed
        +1 javadoc 0m 54s trunk passed
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 44s the patch passed
        +1 javac 0m 44s the patch passed
        -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 40 new + 115 unchanged - 64 fixed = 155 total (was 179)
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 53s the patch passed
        +1 javadoc 0m 56s the patch passed
        -1 unit 58m 38s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        78m 14s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10893
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830573/HDFS-10893.000.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 12332907450b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1831be8
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16885/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16885/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16885/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16885/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 5s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 54s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 44s the patch passed +1 javac 0m 44s the patch passed -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 40 new + 115 unchanged - 64 fixed = 155 total (was 179) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 53s the patch passed +1 javadoc 0m 56s the patch passed -1 unit 58m 38s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 78m 14s Reason Tests Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10893 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830573/HDFS-10893.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 12332907450b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1831be8 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16885/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16885/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16885/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16885/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        Test failure is not related. Specially, HDFS-10426 was supposed to have addressed this.

        Show
        liuml07 Mingliang Liu added a comment - Test failure is not related. Specially, HDFS-10426 was supposed to have addressed this.
        Hide
        liuml07 Mingliang Liu added a comment -

        Now attach the patch for branch-2.

        Show
        liuml07 Mingliang Liu added a comment - Now attach the patch for branch-2 .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 32s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 14s branch-2 passed
        +1 compile 0m 50s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 52s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 33s branch-2 passed
        +1 mvnsite 1m 0s branch-2 passed
        +1 mvneclipse 0m 16s branch-2 passed
        +1 findbugs 2m 12s branch-2 passed
        +1 javadoc 1m 2s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 40s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 46s the patch passed with JDK v1.8.0_101
        +1 javac 0m 46s the patch passed
        +1 compile 0m 46s the patch passed with JDK v1.7.0_111
        +1 javac 0m 46s the patch passed
        -0 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 54 new + 94 unchanged - 80 fixed = 148 total (was 174)
        +1 mvnsite 0m 57s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 29s the patch passed
        +1 javadoc 1m 4s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 46s the patch passed with JDK v1.7.0_111
        -1 unit 49m 27s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        134m 52s



        Reason Tests
        JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.namenode.TestStartup



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-10893
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830631/HDFS-10893-branch-2.000.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c60bea4ee1ab 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / e9a34ae
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16899/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16899/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16899/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16899/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 32s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 14s branch-2 passed +1 compile 0m 50s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 52s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 33s branch-2 passed +1 mvnsite 1m 0s branch-2 passed +1 mvneclipse 0m 16s branch-2 passed +1 findbugs 2m 12s branch-2 passed +1 javadoc 1m 2s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 40s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 49s the patch passed +1 compile 0m 46s the patch passed with JDK v1.8.0_101 +1 javac 0m 46s the patch passed +1 compile 0m 46s the patch passed with JDK v1.7.0_111 +1 javac 0m 46s the patch passed -0 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 54 new + 94 unchanged - 80 fixed = 148 total (was 174) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 29s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 46s the patch passed with JDK v1.7.0_111 -1 unit 49m 27s hadoop-hdfs in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 134m 52s Reason Tests JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.namenode.TestStartup Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-10893 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830631/HDFS-10893-branch-2.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c60bea4ee1ab 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / e9a34ae Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16899/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16899/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16899/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16899/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        Jitendra Nath Pandey would you like review this? Thanks.

        Show
        liuml07 Mingliang Liu added a comment - Jitendra Nath Pandey would you like review this? Thanks.
        Hide
        liuml07 Mingliang Liu added a comment -

        V1 patch rebased from trunk branch.

        Show
        liuml07 Mingliang Liu added a comment - V1 patch rebased from trunk branch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 54s branch-2 passed
        +1 compile 0m 40s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 43s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 29s branch-2 passed
        +1 mvnsite 0m 51s branch-2 passed
        +1 mvneclipse 0m 16s branch-2 passed
        -1 findbugs 1m 54s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings.
        +1 javadoc 0m 56s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 39s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.8.0_101
        +1 javac 0m 39s the patch passed
        +1 compile 0m 40s the patch passed with JDK v1.7.0_111
        +1 javac 0m 40s the patch passed
        -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 54 new + 94 unchanged - 80 fixed = 148 total (was 174)
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 8s the patch passed
        +1 javadoc 0m 54s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 36s the patch passed with JDK v1.7.0_111
        -1 unit 61m 22s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        148m 23s



        Reason Tests
        JDK v1.7.0_111 Failed junit tests hadoop.hdfs.TestEncryptionZones



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-10893
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831180/HDFS-10893-branch-2.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1e28675bb559 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 2551ff8
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16959/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16959/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16959/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16959/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16959/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 54s branch-2 passed +1 compile 0m 40s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 43s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 29s branch-2 passed +1 mvnsite 0m 51s branch-2 passed +1 mvneclipse 0m 16s branch-2 passed -1 findbugs 1m 54s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings. +1 javadoc 0m 56s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 39s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 46s the patch passed +1 compile 0m 39s the patch passed with JDK v1.8.0_101 +1 javac 0m 39s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_111 +1 javac 0m 40s the patch passed -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 54 new + 94 unchanged - 80 fixed = 148 total (was 174) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 36s the patch passed with JDK v1.7.0_111 -1 unit 61m 22s hadoop-hdfs in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 148m 23s Reason Tests JDK v1.7.0_111 Failed junit tests hadoop.hdfs.TestEncryptionZones Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-10893 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831180/HDFS-10893-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1e28675bb559 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 2551ff8 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16959/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16959/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16959/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16959/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16959/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        Rebased from trunk and branch-2 branches for resolving conflicts with HDFS-10934. Jitendra Nath Pandey Would you kindly review this? Thanks!

        Show
        liuml07 Mingliang Liu added a comment - Rebased from trunk and branch-2 branches for resolving conflicts with HDFS-10934 . Jitendra Nath Pandey Would you kindly review this? Thanks!
        Hide
        jnp Jitendra Nath Pandey added a comment -

        Mingliang Liu, sorry for not responding earlier. The patch looks good to me. +1.

        Show
        jnp Jitendra Nath Pandey added a comment - Mingliang Liu , sorry for not responding earlier. The patch looks good to me. +1.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 10m 33s branch-2 passed
        +1 compile 0m 38s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 42s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 29s branch-2 passed
        +1 mvnsite 0m 53s branch-2 passed
        +1 mvneclipse 0m 21s branch-2 passed
        +1 findbugs 1m 57s branch-2 passed
        +1 javadoc 0m 56s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 37s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 44s the patch passed
        +1 compile 0m 35s the patch passed with JDK v1.8.0_101
        +1 javac 0m 35s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.7.0_111
        +1 javac 0m 39s the patch passed
        -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 54 new + 94 unchanged - 80 fixed = 148 total (was 174)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 6s the patch passed
        +1 javadoc 0m 50s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 33s the patch passed with JDK v1.7.0_111
        +1 unit 47m 0s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        124m 17s



        Reason Tests
        JDK v1.8.0_101 Failed junit tests hadoop.hdfs.TestDFSShell



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-10893
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831452/HDFS-10893-branch-2.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 63e72722f5c3 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 612aa0c
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16990/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16990/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16990/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 10m 33s branch-2 passed +1 compile 0m 38s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 42s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 29s branch-2 passed +1 mvnsite 0m 53s branch-2 passed +1 mvneclipse 0m 21s branch-2 passed +1 findbugs 1m 57s branch-2 passed +1 javadoc 0m 56s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 37s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 44s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_101 +1 javac 0m 35s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_111 +1 javac 0m 39s the patch passed -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 54 new + 94 unchanged - 80 fixed = 148 total (was 174) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 0m 50s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 33s the patch passed with JDK v1.7.0_111 +1 unit 47m 0s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 124m 17s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.hdfs.TestDFSShell Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-10893 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831452/HDFS-10893-branch-2.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 63e72722f5c3 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 612aa0c Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16990/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16990/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16990/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10551 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10551/)
        HDFS-10893. Refactor TestDFSShell by setting up MiniDFSCluser once for (liuml07: rev 202325485d66dda7826218faa1fbd21fcd8b882e)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10551 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10551/ ) HDFS-10893 . Refactor TestDFSShell by setting up MiniDFSCluser once for (liuml07: rev 202325485d66dda7826218faa1fbd21fcd8b882e) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 13m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 51s branch-2 passed
        +1 compile 0m 41s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 44s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 29s branch-2 passed
        +1 mvnsite 0m 53s branch-2 passed
        +1 mvneclipse 0m 15s branch-2 passed
        +1 findbugs 1m 58s branch-2 passed
        +1 javadoc 0m 56s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 35s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.8.0_101
        +1 javac 0m 39s the patch passed
        +1 compile 0m 41s the patch passed with JDK v1.7.0_111
        +1 javac 0m 41s the patch passed
        -0 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 54 new + 94 unchanged - 80 fixed = 148 total (was 174)
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 11s the patch passed
        +1 javadoc 0m 52s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 33s the patch passed with JDK v1.7.0_111
        -1 unit 48m 30s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        137m 4s



        Reason Tests
        JDK v1.7.0_111 Failed junit tests hadoop.hdfs.web.TestWebHDFS
          hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-10893
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831894/HDFS-10893-branch-2.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d0aa80f943e4 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / a868cf4
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17040/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17040/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17040/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17040/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 51s branch-2 passed +1 compile 0m 41s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 44s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 29s branch-2 passed +1 mvnsite 0m 53s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 1m 58s branch-2 passed +1 javadoc 0m 56s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 35s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 46s the patch passed +1 compile 0m 39s the patch passed with JDK v1.8.0_101 +1 javac 0m 39s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_111 +1 javac 0m 41s the patch passed -0 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 54 new + 94 unchanged - 80 fixed = 148 total (was 174) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 11s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 33s the patch passed with JDK v1.7.0_111 -1 unit 48m 30s hadoop-hdfs in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 137m 4s Reason Tests JDK v1.7.0_111 Failed junit tests hadoop.hdfs.web.TestWebHDFS   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-10893 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831894/HDFS-10893-branch-2.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d0aa80f943e4 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / a868cf4 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17040/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17040/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17040/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17040/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        Committed to trunk and branch-2. Thanks for review, Jitendra Nath Pandey.

        Show
        liuml07 Mingliang Liu added a comment - Committed to trunk and branch-2 . Thanks for review, Jitendra Nath Pandey .

          People

          • Assignee:
            liuml07 Mingliang Liu
            Reporter:
            liuml07 Mingliang Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development